coilyco-flight-deck/ward

Fork 0

Finish one-file smart-default tunable source after #1365 #1370

New issue

Closed

opened 2026-07-15 09:34:30 +00:00 by coilyco-ops · 3 comments

coilyco-ops commented

2026-07-15 09:34:30 +00:00

Member

Problem

QA of merged PR #1365 against #1175 found that the change improves many test fixtures, but it does not meet the strict done condition from #1175:

changing engineer concurrency to 6 lands in exactly one file, with no test or doc edit anywhere

Current main still tracks the smart-default values in two files:

.ward/ward-kdl/ward-kdl.defaults.kdl
cmd/ward/defaultsassets/defaults.generated.kdl

Makefile target sync-defaults-assets copies the canonical KDL into the embedded asset, and TestDefaultsAssetMatchesCanonicalSource / TestBakedSmartDefaultsMatchesCanonicalSource enforce that duplicate. That means a real default bump still requires at least the canonical file plus the generated embed copy in the commit.

Acceptance

Make the smart-default tunables satisfy the #1175 done condition: changing engineer-container-limit should require one tracked source file and no test or doc edits.
Preserve the shipped binary's baked defaults behavior.
Keep or replace the drift protection so stale embedded defaults cannot silently ship.
Add/adjust tests so the one-source contract is explicit.

Related: #1175, #1365.

## Problem QA of merged PR #1365 against #1175 found that the change improves many test fixtures, but it does not meet the strict done condition from #1175: > changing engineer concurrency to 6 lands in exactly one file, with no test or doc edit anywhere Current `main` still tracks the smart-default values in two files: - `.ward/ward-kdl/ward-kdl.defaults.kdl` - `cmd/ward/defaultsassets/defaults.generated.kdl` `Makefile` target `sync-defaults-assets` copies the canonical KDL into the embedded asset, and `TestDefaultsAssetMatchesCanonicalSource` / `TestBakedSmartDefaultsMatchesCanonicalSource` enforce that duplicate. That means a real default bump still requires at least the canonical file plus the generated embed copy in the commit. ## Acceptance - Make the smart-default tunables satisfy the #1175 done condition: changing `engineer-container-limit` should require one tracked source file and no test or doc edits. - Preserve the shipped binary's baked defaults behavior. - Keep or replace the drift protection so stale embedded defaults cannot silently ship. - Add/adjust tests so the one-source contract is explicit. Related: #1175, #1365.

coilyco-ops added the

coherence-core

headless

labels

2026-07-15 09:34:30 +00:00

coilyco-ops commented

2026-07-15 09:34:51 +00:00

Author

Member

WARDED_WORKFLOW: reservation-held

reservation details

Holder: launch intent for container engineer-codex-ward-1370 on host kais-macbook-pro-2.local.

Accepted by ward agent --harness codex (reserved 2026-07-15T09:34:51Z). Concurrent ward agent runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). --override-reservation overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#1370 · branch issue-1370 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-1370 · ward v0.710.0 · dispatched 2026-07-15T09:34:44Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0).

— Codex, via ward agent

WARDED_WORKFLOW: reservation-held <details><summary>reservation details</summary> Holder: launch intent for container `engineer-codex-ward-1370` on host `kais-macbook-pro-2.local`. Accepted by `ward agent --harness codex` (reserved 2026-07-15T09:34:51Z). Concurrent `ward agent` runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). `--override-reservation` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#1370` · branch `issue-1370` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-1370` · ward `v0.710.0` · dispatched `2026-07-15T09:34:44Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue

2026-07-15 09:35:12 +00:00

Fleet tunables are multi-encoded across ward/ward-kdl - single-source them so a concurrency bump is a one-file change #1175

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-15 09:44:57 +00:00

Finish one-file smart-default tunable source after #1365 #1373

coilyco-ops closed this issue

2026-07-15 09:46:22 +00:00

coilyco-ops commented

2026-07-15 09:46:43 +00:00

Author

Member

WARDED_WORKFLOW: #1373

details

workflow: pull-request-and-merge; review summary: review gate intentionally skipped because the temporary ward default is pending brokered QA
implementation felt: mostly wiring, with the only surprise being the generated defaults asset needing to leave the index as well as the tree
confidence: high
follow-ups: merge PR #1373 once the director sweeps it

WARDED_WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1373 <details><summary>details</summary> workflow: pull-request-and-merge; review summary: review gate intentionally skipped because the temporary ward default is pending brokered QA implementation felt: mostly wiring, with the only surprise being the generated defaults asset needing to leave the index as well as the tree confidence: high follow-ups: merge PR #1373 once the director sweeps it </details>

coilyco-ops referenced this issue

2026-07-15 09:50:19 +00:00

Repair release build after ignored smart-defaults asset #1375

coilyco-ops referenced this issue

2026-07-15 09:51:01 +00:00

Repair failed release run after PR #1373 #1376

coilyco-ops commented

2026-07-15 09:51:13 +00:00

Author

Member

QA after merge #1373:

PR #1373 fixed the tracked-source shape and passed PR CI, but it did not fully satisfy #1370 because the release binary build path broke after the generated defaults asset became ignored.

Post-merge evidence:

run 8427 / #2181 success promote.yml push main "Finish one-file smart-default tunable source after #1365 (#1373)"
run 8431 / #2182 failure release.yml push release "Finish one-file smart-default tunable source after #1365 (#1373)"
publish-binaries failed:
cmd/ward/configsource.go:32:12: pattern defaultsassets/defaults.generated.kdl: no matching files found

Filed and dispatched follow-up #1375 with the same labels to repair the release build while preserving the one-file smart-default source contract.

QA after merge #1373: PR #1373 fixed the tracked-source shape and passed PR CI, but it did not fully satisfy #1370 because the release binary build path broke after the generated defaults asset became ignored. Post-merge evidence: ```text run 8427 / #2181 success promote.yml push main "Finish one-file smart-default tunable source after #1365 (#1373)" run 8431 / #2182 failure release.yml push release "Finish one-file smart-default tunable source after #1365 (#1373)" publish-binaries failed: cmd/ward/configsource.go:32:12: pattern defaultsassets/defaults.generated.kdl: no matching files found ``` Filed and dispatched follow-up #1375 with the same labels to repair the release build while preserving the one-file smart-default source contract.