Repair release build after ignored smart-defaults asset #1375

Closed
opened 2026-07-15 09:50:19 +00:00 by coilyco-ops · 3 comments
Member

Problem

Merged PR #1373 closed #1370, but post-merge release run 8431 / repository run #2182 failed in the publish-binaries job.

The failing job reached repository build code and failed because the release binary build path did not regenerate the ignored smart-defaults embed before go:embed was evaluated:

run 8431 (#2182) failure release.yml push release "Finish one-file smart-default tunable source after #1365 (#1373)"
publish-binaries: failure
cmd/ward/configsource.go:32:12: pattern defaultsassets/defaults.generated.kdl: no matching files found
Job 'publish-binaries' failed

This contradicts #1370 acceptance: the change must preserve the shipped binary's baked defaults behavior while making the tunable source one-file.

Acceptance

  • Repair the release/publish-binaries path so a fresh release checkout can build Ward with the ignored generated defaults asset.
  • Keep the one-file tracked smart-default source contract from #1370 intact.
  • Keep drift protection for the generated embed copy.
  • Verify the relevant release build path, not only make test / PR CI.
  • Confirm post-merge promote/release are green, or leave exact remaining blocker evidence.

Related: #1175, #1365, #1370, #1373, run 8431.

## Problem Merged PR #1373 closed #1370, but post-merge release run 8431 / repository run #2182 failed in the `publish-binaries` job. The failing job reached repository build code and failed because the release binary build path did not regenerate the ignored smart-defaults embed before `go:embed` was evaluated: ```text run 8431 (#2182) failure release.yml push release "Finish one-file smart-default tunable source after #1365 (#1373)" publish-binaries: failure cmd/ward/configsource.go:32:12: pattern defaultsassets/defaults.generated.kdl: no matching files found Job 'publish-binaries' failed ``` This contradicts #1370 acceptance: the change must preserve the shipped binary's baked defaults behavior while making the tunable source one-file. ## Acceptance - Repair the release/publish-binaries path so a fresh release checkout can build Ward with the ignored generated defaults asset. - Keep the one-file tracked smart-default source contract from #1370 intact. - Keep drift protection for the generated embed copy. - Verify the relevant release build path, not only `make test` / PR CI. - Confirm post-merge promote/release are green, or leave exact remaining blocker evidence. Related: #1175, #1365, #1370, #1373, run 8431.
Author
Member

WARDED_WORKFLOW: reservation-held

reservation details

Holder: launch intent for container engineer-codex-ward-1375 on host kais-macbook-pro-2.local.

Accepted by ward agent --harness codex (reserved 2026-07-15T09:50:43Z). Concurrent ward agent runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). --override-reservation overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)
  • Resolved: coilyco-flight-deck/ward#1375 · branch issue-1375 · harness codex · workflow pull-request-and-merge
  • Run: engineer-codex-ward-1375 · ward v0.710.0 · dispatched 2026-07-15T09:50:38Z
  • Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0).

— Codex, via ward agent

<!-- ward-agent-reservation --> WARDED_WORKFLOW: reservation-held <details><summary>reservation details</summary> Holder: launch intent for container `engineer-codex-ward-1375` on host `kais-macbook-pro-2.local`. Accepted by `ward agent --harness codex` (reserved 2026-07-15T09:50:43Z). Concurrent `ward agent` runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). `--override-reservation` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#1375` · branch `issue-1375` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-1375` · ward `v0.710.0` · dispatched `2026-07-15T09:50:38Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0). </details> </details> <!-- ward-agent-signature --> — Codex, via `ward agent`
Author
Member

WARDED_WORKFLOW: #1379

details

The in-container review gate was intentionally skipped because the temporary ward default pending brokered QA.
workflow: pull-request-and-merge; review summary: review gate skipped by the temporary ward default pending brokered QA
felt: straightforward; release only needed the missing defaults sync before the matrix build
confidence: high
surprises: none
follow-ups: keep the drift test and the release sync step paired

WARDED_WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1379 <details><summary>details</summary> The in-container review gate was intentionally skipped because the temporary ward default pending brokered QA. workflow: pull-request-and-merge; review summary: review gate skipped by the temporary ward default pending brokered QA felt: straightforward; release only needed the missing defaults sync before the matrix build confidence: high surprises: none follow-ups: keep the drift test and the release sync step paired </details>
Author
Member

QA follow-up: PASS. PR #1379 added make sync-defaults-assets before the release matrix build. Evidence: PR test run 8439 succeeded, post-merge promote run 8440 succeeded, and release run 8442 succeeded.

I also reran the focused local suite on current main after make sync-defaults-assets; it passed. This repairs the release break introduced when defaults.generated.kdl became an ignored generated asset.

QA follow-up: PASS. PR #1379 added `make sync-defaults-assets` before the release matrix build. Evidence: PR test run 8439 succeeded, post-merge promote run 8440 succeeded, and release run 8442 succeeded. I also reran the focused local suite on current main after `make sync-defaults-assets`; it passed. This repairs the release break introduced when `defaults.generated.kdl` became an ignored generated asset.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/ward#1375
No description provided.