coilyco-flight-deck/ward
2
0
Fork 0
Code Issues 107 Pull requests 2 Projects Releases 737 Packages Wiki Activity Actions

fix: distinguish Goose residual commit states #997

Closed
coilyco-ops wants to merge 1 commit from issue-993 into main
pull from: issue-993
merge into: coilyco-flight-deck:main
Conversation 2 Commits 1 Files changed 21 +6501 -22
coilyco-ops commented 2026-07-10 09:49:21 +00:00
Member
Copy link

closes #993

ward.workflow: pull-requests-and-merge

closes #993 ward.workflow: pull-requests-and-merge
fix: distinguish Goose residual commit states
Some checks failed
test / test (pull_request) Failing after 22s
Details
f802b5ef92 
closes #993
coilyco-ops commented 2026-07-10 09:51:13 +00:00
Author
Member
Copy link

verdict: block
confidence: high
summary: The patch adds useful salvage diagnostics, but it does not satisfy the issue's landing-path requirement. The live PR status is also red.
findings:

  • severity: high
    file: cmd/ward/container_reap.go
    line: 1151
    problem: The change classifies residual work only after the reaper is already salvaging it.
    impact: ward#993 asks for Goose work that modifies files to get a deterministic same-repo closing commit before teardown, or otherwise a clearer failure. This patch improves the clearer-failure branch, but it does not change the seed prompt, harness wrapper, or reaper path so a repeat of the infrastructure#523 shape would land with closes #523.
  • severity: high
    file: n/a
    line: n/a
    problem: The current PR head f802b5ef924869f6f0eb337d7da722975d8f904d has required status test / test (pull_request) = failure, description Failing after 22s.
    impact: The PR is not merge-ready even apart from the contract gap.
    conclusion: Review blocks PR #997. The diagnostics split is useful, but the issue contract also requires a normal successful Goose path that commits same-repo work with a closing reference before reaper landing, and this patch does not implement or test that path.
verdict: block confidence: high summary: The patch adds useful salvage diagnostics, but it does not satisfy the issue's landing-path requirement. The live PR status is also red. findings: - severity: high file: cmd/ward/container_reap.go line: 1151 problem: The change classifies residual work only after the reaper is already salvaging it. impact: `ward#993` asks for Goose work that modifies files to get a deterministic same-repo closing commit before teardown, or otherwise a clearer failure. This patch improves the clearer-failure branch, but it does not change the seed prompt, harness wrapper, or reaper path so a repeat of the infrastructure#523 shape would land with `closes #523`. - severity: high file: n/a line: n/a problem: The current PR head `f802b5ef924869f6f0eb337d7da722975d8f904d` has required status `test / test (pull_request)` = `failure`, description `Failing after 22s`. impact: The PR is not merge-ready even apart from the contract gap. conclusion: Review blocks PR #997. The diagnostics split is useful, but the issue contract also requires a normal successful Goose path that commits same-repo work with a closing reference before reaper landing, and this patch does not implement or test that path.
coilyco-ops commented 2026-07-10 09:51:36 +00:00
Author
Member
Copy link

ward exec test still fails in this container. cmd/ward/setup_test.go and cmd/ward/smartdefaults_test.go report that WARD_CONFIG_REF stays at the baked neutral default instead of pointing at the coilyco bundle for coilyco-flight-deck/ward. Action: investigate ward exec config-source bootstrap so repo verbs see the coilyco bundle.

ward exec test still fails in this container. cmd/ward/setup_test.go and cmd/ward/smartdefaults_test.go report that WARD_CONFIG_REF stays at the baked neutral default instead of pointing at the coilyco bundle for coilyco-flight-deck/ward. Action: investigate ward exec config-source bootstrap so repo verbs see the coilyco bundle.
coilysiren closed this pull request 2026-07-10 10:07:04 +00:00
Some checks failed
test / test (pull_request) Failing after 22s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
burndown-2026-06
Backlog burndown June 2026

  
pressure-test
Cold-read release pressure-test findings and coordination

  
sunday-sprint
Burn-down by Sunday 2026-06-07

  
coherence-core
Core review set for the warded control plane coherence milestone. These issues form the release spine; adjacent milestone issues are stretch or supporting work.

  
consult
A human decision, design, or external action must happen first. Fail-closed default for unlabeled/low-confidence.

  
headless
Agent can take it from open issue to merged change with no human in the loop. The auto-burndown queue.

  
interactive
Agent does the work but pauses at a human checkpoint mid-flight (design choice, destructive step, human-only verification).

  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
burndown-2026-06
pressure-test
sunday-sprint
coherence-core
consult
headless
interactive
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/ward!997
No description provided.