fix: distinguish Goose residual commit states

coilyco-ops commented

2026-07-10 09:49:21 +00:00

Owner

closes #993

ward.workflow: pull-requests-and-merge

closes #993 ward.workflow: pull-requests-and-merge

coilyco-ops added 1 commit

2026-07-10 09:49:21 +00:00

fix: distinguish Goose residual commit states

test / test (pull_request) Failing after 22s

Details

f802b5ef92

closes #993

coilyco-ops commented

2026-07-10 09:51:13 +00:00

Author

Owner

verdict: block
confidence: high
summary: The patch adds useful salvage diagnostics, but it does not satisfy the issue's landing-path requirement. The live PR status is also red.
findings:

severity: high
file: cmd/ward/container_reap.go
line: 1151
problem: The change classifies residual work only after the reaper is already salvaging it.
impact: ward#993 asks for Goose work that modifies files to get a deterministic same-repo closing commit before teardown, or otherwise a clearer failure. This patch improves the clearer-failure branch, but it does not change the seed prompt, harness wrapper, or reaper path so a repeat of the infrastructure#523 shape would land with closes #523.
severity: high
file: n/a
line: n/a
problem: The current PR head f802b5ef924869f6f0eb337d7da722975d8f904d has required status test / test (pull_request) = failure, description Failing after 22s.
impact: The PR is not merge-ready even apart from the contract gap.
conclusion: Review blocks PR #997. The diagnostics split is useful, but the issue contract also requires a normal successful Goose path that commits same-repo work with a closing reference before reaper landing, and this patch does not implement or test that path.

verdict: block confidence: high summary: The patch adds useful salvage diagnostics, but it does not satisfy the issue's landing-path requirement. The live PR status is also red. findings: - severity: high file: cmd/ward/container_reap.go line: 1151 problem: The change classifies residual work only after the reaper is already salvaging it. impact: `ward#993` asks for Goose work that modifies files to get a deterministic same-repo closing commit before teardown, or otherwise a clearer failure. This patch improves the clearer-failure branch, but it does not change the seed prompt, harness wrapper, or reaper path so a repeat of the infrastructure#523 shape would land with `closes #523`. - severity: high file: n/a line: n/a problem: The current PR head `f802b5ef924869f6f0eb337d7da722975d8f904d` has required status `test / test (pull_request)` = `failure`, description `Failing after 22s`. impact: The PR is not merge-ready even apart from the contract gap. conclusion: Review blocks PR #997. The diagnostics split is useful, but the issue contract also requires a normal successful Goose path that commits same-repo work with a closing reference before reaper landing, and this patch does not implement or test that path.

coilyco-ops referenced this pull request

2026-07-10 09:51:27 +00:00

Repair Goose residual landing path after PR #997 diagnostics-only fix #998

coilyco-ops commented

2026-07-10 09:51:36 +00:00

Author

Owner

ward exec test still fails in this container. cmd/ward/setup_test.go and cmd/ward/smartdefaults_test.go report that WARD_CONFIG_REF stays at the baked neutral default instead of pointing at the coilyco bundle for coilyco-flight-deck/ward. Action: investigate ward exec config-source bootstrap so repo verbs see the coilyco bundle.

coilyco-ops referenced this pull request

2026-07-10 10:04:10 +00:00

Repair Goose residual landing path after PR #997 diagnostics-only fix #1002

coilysiren closed this pull request

2026-07-10 10:07:04 +00:00

coilysiren referenced this pull request

2026-07-14 15:27:09 +00:00

director should emit colorized, space buffered, visually distinct messages about the categories of actions its performing on startup #1283

Rows
Columns

fix: distinguish Goose residual commit states #997