Repair failed promote run after PR #1421

coilyco-ops commented

2026-07-15 12:09:55 +00:00

Member

Problem

PR #1421 merged for #1408, but its post-merge promote run still failed.

Run evidence:

run 8530 (#2252) failure promote.yml push main "Repair promote gate tempdir cleanup failure after #1404 (#1421)"
job gate-and-promote
FAIL github.com/coilyco-flight-deck/ward/cmd/ward
make: *** [Makefile:178: test] Error 1

PR #1421 added an explicit cleanup of the dispatch artifact directory in TestRunHostDispatchBrokerRequestClearsBrokerEnvWhileLaunchRuns, and PR test run 8529 was green, but the main promote gate still failed after merge. The log does not expose a concise --- FAIL line in the tail captured by the director, so this needs a focused recovery trail rather than disappearing into closed #1408.

This is a missed acceptance follow-up for #1408, which required confirming the promote gate passes or leaving exact blocker evidence. A separate #1422 is already running for promote run 8528, but #1422 was dispatched before this run 8530 evidence existed and will not see this failure in its seed.

Acceptance

Inspect promote run 8530 / repository run #2252 after PR #1421.
Identify the exact failing test or runner condition from the full job log.
If the failure is real, repair it with a focused change.
If the failure is transient or already repaired by another active run, leave exact evidence and avoid duplicating code changes.
Confirm promote.yml succeeds on main, or leave the exact remaining blocker.

Related: #1408, #1421, #1422, run 8530 / #2252.

## Problem PR #1421 merged for #1408, but its post-merge promote run still failed. Run evidence: ```text run 8530 (#2252) failure promote.yml push main "Repair promote gate tempdir cleanup failure after #1404 (#1421)" job gate-and-promote FAIL github.com/coilyco-flight-deck/ward/cmd/ward make: *** [Makefile:178: test] Error 1 ``` PR #1421 added an explicit cleanup of the dispatch artifact directory in `TestRunHostDispatchBrokerRequestClearsBrokerEnvWhileLaunchRuns`, and PR test run 8529 was green, but the main promote gate still failed after merge. The log does not expose a concise `--- FAIL` line in the tail captured by the director, so this needs a focused recovery trail rather than disappearing into closed #1408. This is a missed acceptance follow-up for #1408, which required confirming the promote gate passes or leaving exact blocker evidence. A separate #1422 is already running for promote run 8528, but #1422 was dispatched before this run 8530 evidence existed and will not see this failure in its seed. ## Acceptance - Inspect promote run 8530 / repository run #2252 after PR #1421. - Identify the exact failing test or runner condition from the full job log. - If the failure is real, repair it with a focused change. - If the failure is transient or already repaired by another active run, leave exact evidence and avoid duplicating code changes. - Confirm promote.yml succeeds on main, or leave the exact remaining blocker. Related: #1408, #1421, #1422, run 8530 / #2252.

coilyco-ops added this to the warded control plane coherence milestone

2026-07-15 12:09:55 +00:00

coilyco-ops added the

headless

P1

labels

2026-07-15 12:09:55 +00:00

coilyco-ops referenced this issue

2026-07-15 12:10:04 +00:00

Repair promote gate tempdir cleanup failure after #1404 #1408

coilyco-ops commented

2026-07-15 12:10:27 +00:00

Author

Member

WARDED_WORKFLOW: reservation-held

reservation details

Holder: launch intent for container engineer-codex-ward-1423 on host kais-macbook-pro-2.local.

Accepted by ward agent --harness codex (reserved 2026-07-15T12:10:27Z). Concurrent ward agent runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). --override-reservation overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#1423 · branch issue-1423 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-1423 · ward v0.710.0 · dispatched 2026-07-15T12:10:20Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0).

— Codex, via ward agent

WARDED_WORKFLOW: reservation-held <details><summary>reservation details</summary> Holder: launch intent for container `engineer-codex-ward-1423` on host `kais-macbook-pro-2.local`. Accepted by `ward agent --harness codex` (reserved 2026-07-15T12:10:27Z). Concurrent `ward agent` runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). `--override-reservation` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#1423` · branch `issue-1423` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-1423` · ward `v0.710.0` · dispatched `2026-07-15T12:10:20Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue

2026-07-15 12:11:34 +00:00

Repair failed promote run after PR #1404 #1406

coilyco-ops referenced this issue

2026-07-15 12:17:25 +00:00

Inject pre-flight launch logs into the launched agent context #1335

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-15 12:19:56 +00:00

Repair failed promote run after PR #1421 #1426

coilyco-ops referenced this issue

2026-07-15 12:25:02 +00:00

Recover closed-unmerged PR #1426 for #1423 #1427

coilyco-ops referenced this issue

2026-07-15 12:25:35 +00:00

Repair current-main broker cleanup failure after PR #1426 #1428

coilyco-ops closed this issue

2026-07-15 12:25:46 +00:00

coilyco-ops commented

2026-07-15 12:27:50 +00:00

Author

Member

QA FAIL post-merge check on 2026-07-15: PR #1426 merged as cbc42f3b0c0b821346176b782bacfb843ac94af1, but current origin/main still fails the focused broker cleanup regression.

Evidence from /scratch/ward-main-qa after fetching current main:

HEAD is now at cbc42f3 Repair failed promote run after PR #1421 (#1426)
go test ./cmd/ward -run TestRunHostDispatchBrokerRequestClearsBrokerEnvWhileLaunchRuns -count=20
--- FAIL: TestRunHostDispatchBrokerRequestClearsBrokerEnvWhileLaunchRuns (0.00s)
agent_dispatch_broker_test.go:1739: runHostDispatchBrokerRequest returned early: {logPath:.../.ward/agent-logs/dispatch/.../console.log err:<nil>}
FAIL github.com/coilyco-flight-deck/ward/cmd/ward 20.059s

This misses the issue acceptance to repair the failure on the current main state. Follow-up #1428 is already filed with the same headless and P1 labels and has dispatch-deferred evidence because the repo is at 3/3 active engineers.

QA FAIL post-merge check on 2026-07-15: PR #1426 merged as `cbc42f3b0c0b821346176b782bacfb843ac94af1`, but current `origin/main` still fails the focused broker cleanup regression. Evidence from `/scratch/ward-main-qa` after fetching current main: ```text HEAD is now at cbc42f3 Repair failed promote run after PR #1421 (#1426) go test ./cmd/ward -run TestRunHostDispatchBrokerRequestClearsBrokerEnvWhileLaunchRuns -count=20 --- FAIL: TestRunHostDispatchBrokerRequestClearsBrokerEnvWhileLaunchRuns (0.00s) agent_dispatch_broker_test.go:1739: runHostDispatchBrokerRequest returned early: {logPath:.../.ward/agent-logs/dispatch/.../console.log err:<nil>} FAIL github.com/coilyco-flight-deck/ward/cmd/ward 20.059s ``` This misses the issue acceptance to repair the failure on the current main state. Follow-up #1428 is already filed with the same `headless` and `P1` labels and has dispatch-deferred evidence because the repo is at 3/3 active engineers.

coilyco-ops referenced this issue

2026-07-15 12:29:11 +00:00

Recover closed-unmerged PR #1426 for #1423 #1427

Rows
Columns

Repair failed promote run after PR #1421 #1423

Problem

Acceptance