Repair promote gate tempdir cleanup failure after #1404 #1421

Merged
coilyco-ops merged 1 commit from issue-1408 into main 2026-07-15 12:07:40 +00:00
Owner

This hardens the brokered-dispatch regression so the launch-success path proves its dispatch artifact tree is quiescent before t.TempDir teardown. That turns the cleanup race from an intermittent promote failure into an explicit test assertion.

  • Added an immediate RemoveAll check for the request's dispatch artifact directory after the launch returns.
  • Preserved the broker env restoration coverage for WARD_READONLY, WARD_DISPATCH_BROKER_ADDR, and WARD_DISPATCH_BROKER_TOKEN.
  • Verification: go test ./cmd/ward -count=1 and make test.

closes #1408
ward.workflow: pull-request-and-merge

This hardens the brokered-dispatch regression so the launch-success path proves its dispatch artifact tree is quiescent before `t.TempDir` teardown. That turns the cleanup race from an intermittent promote failure into an explicit test assertion. - Added an immediate `RemoveAll` check for the request's dispatch artifact directory after the launch returns. - Preserved the broker env restoration coverage for `WARD_READONLY`, `WARD_DISPATCH_BROKER_ADDR`, and `WARD_DISPATCH_BROKER_TOKEN`. - Verification: `go test ./cmd/ward -count=1` and `make test`. closes #1408 ward.workflow: pull-request-and-merge
test: harden dispatch broker cleanup regression
All checks were successful
test / test (pull_request) Successful in 53s
88bc0d51bb
Commenting is not possible because the repository is archived.
No reviewers
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-flight-deck/ward!1421
No description provided.