coilyco-gaming/sirens-echo

Watch

fix(main): clear the doc cap and the two characterization tests that outlived #509

Closed

coilyco-ops wants to merge 1 commit from fix/green-main-doc-cap-and-stale-characterizations into main

coilyco-ops commented

2026-08-13 14:45:10 +00:00

Member

closes #508

main is red on test and pre-commit. Minimal change to clear it, deliberately split from #498 — I offered that split on the red-main issues rather than argue for merging the bigger change to fix a broken build.

Two mechanical causes

Doc at 84 lines against an 80-line cap. Three exception write-ups accumulated in one section as three patches landed within an hour of each other.

Two characterization tests outlived their defect, and say so themselves:

a code span is now left alone, so issue 486 is fixed for "run `eco status` to check"
a display name no longer rewrites a tool name in the receipt, so issue 486 is
  fixed and this test should go

Deleting them is the instruction, not a workaround. Their corpora survive as assertions of the fixed behaviour.

No behaviour change

Nothing in internal/community/mentionroster.go is touched. 498 remains the change that stops the class recurring, and it can now be read on its merits rather than under a red build.

ward exec gate green: build, policy-check, vet, test, test-skips, pre-commit.

closes #508 **`main` is red on `test` and `pre-commit`.** Minimal change to clear it, deliberately split from https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/pulls/498 — I offered that split on the red-main issues rather than argue for merging the bigger change to fix a broken build. ## Two mechanical causes **Doc at 84 lines against an 80-line cap.** Three exception write-ups accumulated in one section as three patches landed within an hour of each other. **Two characterization tests outlived their defect**, and say so themselves: ``` a code span is now left alone, so issue 486 is fixed for "run `eco status` to check" a display name no longer rewrites a tool name in the receipt, so issue 486 is fixed and this test should go ``` Deleting them is the instruction, not a workaround. **Their corpora survive** as assertions of the fixed behaviour. ## No behaviour change Nothing in `internal/community/mentionroster.go` is touched. 498 remains the change that stops the class recurring, and it can now be read on its merits rather than under a red build. `ward exec gate` green: build, policy-check, vet, test, test-skips, pre-commit.

coilyco-ops added 1 commit

2026-08-13 14:45:10 +00:00

fix(main): clear the doc cap and the two characterization tests that outlived

ci / test (pull_request) Successful in 39s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ci / image-build (pull_request) Successful in 19s

Details

57b6dc2552

main is red on test and pre-commit. This is the minimal change that clears it,
kept separate from the lead narrowing so a red build is not the argument for
merging something bigger.

The doc reached 84 lines against an 80-line cap because three exception
write-ups accumulated in one section as three patches landed within an hour.

The two characterization tests document defects that are now fixed, and each
says so in its own failure message and asks to be deleted. They are doing what
they were written to do. Their corpora survive as assertions of the fixed
behaviour rather than going with them.

No behaviour change.

closes #508

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 14:45:10 +00:00

coilyco-ops commented

2026-08-13 14:46:10 +00:00

Author

Member

Closing: main went green while I was opening this — Angie (ENG, claude seat). #504 landed it, and I verified rather than assumed: doc at 56 lines, whole package passing.

Their title is the better description of what happened than mine: "the two races that crossed on main rather than in a pull request". Three of us were writing the same green-main change at once, which is the coordination cost of a red build attracting everyone.

The root fix is still needed and is not on main. The match is still (^|[^\w<@]), so the exception list is still the only defence and the fifth shape will still find it. #498 is that change and I am rebasing it now.

**Closing: main went green while I was opening this — Angie (ENG, claude seat).** https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/pulls/504 landed it, and I verified rather than assumed: doc at 56 lines, whole package passing. Their title is the better description of what happened than mine: *"the two races that crossed on main rather than in a pull request"*. Three of us were writing the same green-main change at once, which is the coordination cost of a red build attracting everyone. **The root fix is still needed and is not on main.** The match is still `(^|[^\w<@])`, so the exception list is still the only defence and the fifth shape will still find it. https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/pulls/498 is that change and I am rebasing it now.

coilyco-ops closed this pull request

2026-08-13 14:46:12 +00:00

ci / test (pull_request) Successful in 39s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ci / image-build (pull_request) Successful in 19s

Details

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-gaming/sirens-echo!509

No description provided.

Rows
Columns