fix(main): green again, on the two races that crossed on main rather than in a pull request #504

Merged
coilyco-ops merged 1 commit from coilyco-ops/main-is-red-on-the-486-characterization into main 2026-08-13 14:43:49 +00:00 AGit
Member

closes #501 - the 486 characterization test and the 486 fix both merged and disagreed, and the mentions doc crossed its line cap the same way. Both were green in isolation.

closes #501 - the 486 characterization test and the 486 fix both merged and disagreed, and the mentions doc crossed its line cap the same way. Both were green in isolation.
fix(main): green again, on the two races that crossed on main rather than in a pull request
All checks were successful
ci / image-build (pull_request) Successful in 21s
ci / test (pull_request) Successful in 33s
ci / publish-echo-image (pull_request) Has been skipped
ci / publish-observed (pull_request) Has been skipped
267245a6a8
main was red on two counts, measured on a clean worktree of origin/main with no
local changes, so neither is from my tree.

The tests. Pull request 495 pinned the broken behaviour of sirens-echo#486 as
characterization and pull request 496 fixed it. Both were right, both were green
against the base they were written on, and neither ran against the other:

  --- FAIL: TestANameInsideACodeSpanIsRewritten
      a code span is now left alone, so issue 486 is fixed
  --- FAIL: TestAToolNamedMemberRewritesTheFooter
      a display name no longer rewrites a tool name in the receipt, so issue
      486 is fixed and this test should go

Flipped rather than deleted, which is what keeps the coverage 495 added on
purpose. A characterization test that pins a defect becomes a regression test
that pins the fix. Verified by reverting 496, where both flipped cases fail, so
they are load-bearing rather than removed.

The doc cap. docs/sirens-echo-mentions.md reached 84 lines against an 80-line
cap, so pre-commit failed on main too. Same shape and no single pull request
did it: several added a few lines each and the sum crossed the line. One of
those was mine, in 484.

Split rather than trimmed, because the file was not padded, it was full. The
boundary rules are their own concern and are now their own doc, which also
gives the next boundary rule an obvious home instead of another few lines here.

Neither of these is a lapse by any seat. It is the shape Lucia recorded on
sirens-echo#305: two changes that pass separately and disagree together. The
setting that catches it was armed and then turned back off for throughput, both
correct calls on the evidence at the time. This is a data point for that thread,
not a re-litigation of it.

closes #501

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-gaming/sirens-echo!504
No description provided.