fix(main): green again, on the two races that crossed on main rather than in a pull request #504
No reviewers
Labels
No labels
move-to-repo
coilyco-bridge-deploy
move-to-repo
coilyco-flight-deck-agent-compose
move-to-repo
coilyco-gaming-eco-app
move-to-repo
coilysiren-inbox
move-to-repo
unknown
🔒⚠️📦⚠️🔒 SANDBOXED 🔒⚠️📦⚠️🔒
autonomy
async-consult
autonomy
epic
autonomy
headless
autonomy
live-collab
c#
priority
P0
priority
P1
priority
P2
priority
P3
priority
P4
role/ai
role/creator
role/design
role/director
role/engineer
role/exec
role/human
role/ops
role/qa
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
coilyco-gaming/sirens-echo!504
Loading…
Reference in a new issue
No description provided.
Delete branch "coilyco-ops/main-is-red-on-the-486-characterization"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #501 - the 486 characterization test and the 486 fix both merged and disagreed, and the mentions doc crossed its line cap the same way. Both were green in isolation.
main was red on two counts, measured on a clean worktree of origin/main with no local changes, so neither is from my tree. The tests. Pull request 495 pinned the broken behaviour of sirens-echo#486 as characterization and pull request 496 fixed it. Both were right, both were green against the base they were written on, and neither ran against the other: --- FAIL: TestANameInsideACodeSpanIsRewritten a code span is now left alone, so issue 486 is fixed --- FAIL: TestAToolNamedMemberRewritesTheFooter a display name no longer rewrites a tool name in the receipt, so issue 486 is fixed and this test should go Flipped rather than deleted, which is what keeps the coverage 495 added on purpose. A characterization test that pins a defect becomes a regression test that pins the fix. Verified by reverting 496, where both flipped cases fail, so they are load-bearing rather than removed. The doc cap. docs/sirens-echo-mentions.md reached 84 lines against an 80-line cap, so pre-commit failed on main too. Same shape and no single pull request did it: several added a few lines each and the sum crossed the line. One of those was mine, in 484. Split rather than trimmed, because the file was not padded, it was full. The boundary rules are their own concern and are now their own doc, which also gives the next boundary rule an obvious home instead of another few lines here. Neither of these is a lapse by any seat. It is the shape Lucia recorded on sirens-echo#305: two changes that pass separately and disagree together. The setting that catches it was armed and then turned back off for throughput, both correct calls on the evidence at the time. This is a data point for that thread, not a re-litigation of it. closes #501 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Kai Siren <coilysiren@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>