feat(worklog): name the reference a skill read delivered, and double the row cap #1067

Merged

coilysiren merged 1 commit from skill-read-worklog-detail into main

2026-08-19 09:01:48 +00:00

coilyco-ops commented

2026-08-19 09:00:12 +00:00

Member

Kai asked for the > ✅ 📖 astronomy form on the tool progress surfaces and a doubled report cap.

What changed

A resolved skills.read_skill row names the reference it delivered: > ✅ 📖 astronomy on the worklog element, > 🔨 ✅ 📖 astronomy in the disclosure footer. In-flight rows stay plain and resolve into the named form.
The name travels as a new Detail field on ToolResult and ExecutedTool, set only on the skill session's validated-path success branch, so the "arguments are never shown" rule keeps its teeth structurally: a refused or failed read can never echo the model's guessed path, pinned by test.
Runs collapse only when the reference matches too, so two different skills read back-to-back render as two named lines rather than a ×2.
maxWorklogRows doubles from 6 to 12 (SIRENS_ECHO_WORKLOG_ROWS still overrides). The disclosure footer has no row cap to double: it already lists every call and yields only to Discord's own message ceiling.
The notice shape admits stacked leading icons, which the new row form needs; the payload alphabet is unchanged.
docs/sirens-echo-worklog.md carries the carve-out and the new example; docs/sirens-echo-tool-markup.md points at it (that doc is 7993 of its 8000-char cap).

Verification

Six new tests in skillreaddetail_test.go cover the validated-detail path, the refusal-names-nothing guarantee, both rendered forms, the notice-shape conformance, and the no-collapse-across-references rule. just test and the full pre-commit suite are green.

🤖 Generated with Claude Code

Kai asked for the `> ✅ 📖 astronomy` form on the tool progress surfaces and a doubled report cap. ## What changed * A resolved `skills.read_skill` row names the reference it delivered: `> ✅ 📖 astronomy` on the worklog element, `> 🔨 ✅ 📖 astronomy` in the disclosure footer. In-flight rows stay plain and resolve into the named form. * The name travels as a new `Detail` field on `ToolResult` and `ExecutedTool`, set only on the skill session's validated-path success branch, so the "arguments are never shown" rule keeps its teeth structurally: a refused or failed read can never echo the model's guessed path, pinned by test. * Runs collapse only when the reference matches too, so two different skills read back-to-back render as two named lines rather than a `×2`. * `maxWorklogRows` doubles from 6 to 12 (`SIRENS_ECHO_WORKLOG_ROWS` still overrides). The disclosure footer has no row cap to double: it already lists every call and yields only to Discord's own message ceiling. * The notice shape admits stacked leading icons, which the new row form needs; the payload alphabet is unchanged. * `docs/sirens-echo-worklog.md` carries the carve-out and the new example; `docs/sirens-echo-tool-markup.md` points at it (that doc is 7993 of its 8000-char cap). ## Verification Six new tests in `skillreaddetail_test.go` cover the validated-detail path, the refusal-names-nothing guarantee, both rendered forms, the notice-shape conformance, and the no-collapse-across-references rule. `just test` and the full pre-commit suite are green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

coilyco-ops added 1 commit

2026-08-19 09:00:13 +00:00

feat(worklog): name the reference a skill read delivered, and double the row cap

ci / image-build (pull_request) Successful in 37s

Details

ci / test (pull_request) Successful in 1m3s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ec52f032fb

A resolved skills.read_skill row now reads '> ✅ 📖 astronomy' on the
worklog and '> 🔨 ✅ 📖 astronomy' on the disclosure footer. The name is
the session-validated reference path's basename, carried on ToolResult
and ExecutedTool as Detail, so the arguments-never-shown rule keeps its
teeth: only the validated closed set can reach a member surface and a
refused read names nothing, both pinned by test. Different references
never collapse into one counted run. maxWorklogRows doubles to 12 per
Kai's request, and the notice shape admits stacked icons.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>