coilyco-flight-deck/ward
2
0
Fork 0
Code Issues 105 Pull requests Projects Releases 737 Packages Wiki Activity Actions

Add a director queue view for stale reservations and redispatch candidates #984

Closed
coilyco-ops wants to merge 0 commits from issue-977 into main
pull from: issue-977
merge into: coilyco-flight-deck:main
Conversation 2 Commits - Files changed - +593 -2
coilyco-ops commented 2026-07-10 09:16:37 +00:00
Member
Copy link

closes #977
ward.workflow: pull-requests-and-merge

Add a director queue/status view for stale reservations, redispatch candidates, submitted PRs, and stale-open done issues.

closes #977 ward.workflow: pull-requests-and-merge Add a director queue/status view for stale reservations, redispatch candidates, submitted PRs, and stale-open done issues.
feat: add director queue status view
All checks were successful
test / test (pull_request) Successful in 28s
Details
50a13c9e3d
coilyco-ops commented 2026-07-10 09:24:10 +00:00
Author
Member
Copy link

verdict: block
confidence: high
summary: The queue command wires the requested states, but one PR classification branch compares a display prefix to the internal pull-request kind. That makes done PR carries look like closeable issues.
findings:

  • severity: high
    file: cmd/ward/agent_director_queue.go
    line: 231
    problem: classifyDirectorQueueOutcome checks item.Kind == backlogKindPullRequest, but classifyDirectorQueuePR stores Kind: backlogEntryKindPrefix(backlogKindPullRequest), which is the display string PR. The comparison can never be true for PR rows.
    impact: A pull request with WARD-OUTCOME: done is classified with action close stale-open done issue instead of wait, so the queue view can instruct the operator to close a PR carry as if it were a stale-open issue.
    conclusion: Review blocks PR #984. The queue surface is useful, but PR rows need to keep an internal kind or compare through backlogKindOf before the done-state action can be trusted.
verdict: block confidence: high summary: The queue command wires the requested states, but one PR classification branch compares a display prefix to the internal pull-request kind. That makes done PR carries look like closeable issues. findings: - severity: high file: cmd/ward/agent_director_queue.go line: 231 problem: `classifyDirectorQueueOutcome` checks `item.Kind == backlogKindPullRequest`, but `classifyDirectorQueuePR` stores `Kind: backlogEntryKindPrefix(backlogKindPullRequest)`, which is the display string `PR`. The comparison can never be true for PR rows. impact: A pull request with `WARD-OUTCOME: done` is classified with action `close stale-open done issue` instead of `wait`, so the queue view can instruct the operator to close a PR carry as if it were a stale-open issue. conclusion: Review blocks PR #984. The queue surface is useful, but PR rows need to keep an internal kind or compare through `backlogKindOf` before the done-state action can be trusted.
coilyco-ops commented 2026-07-10 17:15:28 +00:00
Author
Member
Copy link

Superseded by PR #1043 (issue #995): it merges this branch and repairs the review-blocking classification bug - classifyDirectorQueueOutcome compared item.Kind against backlogKindPullRequest while the queue items stored the display prefix from backlogEntryKindPrefix, so done PR carries were mis-actioned as closeable stale-open done issues. Closing this PR in favor of #1043.

Superseded by PR #1043 (issue #995): it merges this branch and repairs the review-blocking classification bug - `classifyDirectorQueueOutcome` compared `item.Kind` against `backlogKindPullRequest` while the queue items stored the display prefix from `backlogEntryKindPrefix`, so done PR carries were mis-actioned as closeable stale-open done issues. Closing this PR in favor of #1043.
coilyco-ops closed this pull request 2026-07-10 17:15:28 +00:00
All checks were successful
test / test (pull_request) Successful in 28s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
burndown-2026-06
Backlog burndown June 2026

  
pressure-test
Cold-read release pressure-test findings and coordination

  
sunday-sprint
Burn-down by Sunday 2026-06-07

  
coherence-core
Core review set for the warded control plane coherence milestone. These issues form the release spine; adjacent milestone issues are stretch or supporting work.

  
consult
A human decision, design, or external action must happen first. Fail-closed default for unlabeled/low-confidence.

  
headless
Agent can take it from open issue to merged change with no human in the loop. The auto-burndown queue.

  
interactive
Agent does the work but pauses at a human checkpoint mid-flight (design choice, destructive step, human-only verification).

  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
burndown-2026-06
pressure-test
sunday-sprint
coherence-core
consult
headless
interactive
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/ward!984
No description provided.