Repair director queue PR classification from PR #984 review #1043

Merged

coilysiren merged 5 commits from issue-995 into main

2026-07-10 18:20:08 +00:00

coilyco-ops commented

2026-07-10 17:15:13 +00:00

Member

Replaces PR #984 with the repaired director queue view.

PR #984 was review-blocked on a concrete classification bug: classifyDirectorQueueOutcome compared item.Kind against backlogKindPullRequest ("pull-request"), but the queue items stored the display prefix ("PR"/"issue") from backlogEntryKindPrefix, so a done PR carry could never match the PR branch and was mis-actioned as a closeable stale-open done issue.

This branch merges the issue-977 queue view and repairs it at the representation seam:

directorQueueItem.Kind now stores the canonical backlog kind (backlogKindIssue / backlogKindPullRequest); the display prefix is derived only at render time.
Done PR carries classify as done-but-still-open with next action wait, never close stale-open done issue.
Tests cover done PR and done issue outcomes separately, lock the canonical Kind on every classified item, and assert the rendered view keeps the PR/issue prefixes without counting the done PR toward the close-done action.
Also carries a hook repair: main's tip left a dead docs/ward-specs.md reference and an over-cap comment block in configsource.go that failed the pre-commit suite on every commit; the comment is shrunk to cap and the detail moved into docs/config-source.md.

closes #995

ward.workflow: pull-requests-and-merge

Replaces PR #984 with the repaired director queue view. PR #984 was review-blocked on a concrete classification bug: `classifyDirectorQueueOutcome` compared `item.Kind` against `backlogKindPullRequest` (`"pull-request"`), but the queue items stored the display prefix (`"PR"`/`"issue"`) from `backlogEntryKindPrefix`, so a done PR carry could never match the PR branch and was mis-actioned as a closeable stale-open done issue. This branch merges the issue-977 queue view and repairs it at the representation seam: * `directorQueueItem.Kind` now stores the canonical backlog kind (`backlogKindIssue` / `backlogKindPullRequest`); the display prefix is derived only at render time. * Done PR carries classify as done-but-still-open with next action `wait`, never `close stale-open done issue`. * Tests cover done PR and done issue outcomes separately, lock the canonical `Kind` on every classified item, and assert the rendered view keeps the `PR`/`issue` prefixes without counting the done PR toward the close-done action. * Also carries a hook repair: main's tip left a dead `docs/ward-specs.md` reference and an over-cap comment block in `configsource.go` that failed the pre-commit suite on every commit; the comment is shrunk to cap and the detail moved into `docs/config-source.md`. closes #995 ward.workflow: pull-requests-and-merge

coilyco-ops added 4 commits

2026-07-10 17:15:13 +00:00

feat: add director queue status view

test / test (pull_request) Successful in 28s

Details

50a13c9e3d

fix(hooks): repair main's dead doc ref and over-cap comment block 37e73184d2

Main's tip (60133a84) landed a configsource.go comment that points at
docs/ward-specs.md - a doc that lives in aos, not ward - and runs five
contiguous comment lines. Both trip the agentic-os pre-commit suite
(source-doc-refs, code-comments) on every subsequent commit in this
repo, blocking unrelated work.

Shrink the comment to the two-line cap and move the monolith constraint
detail into docs/config-source.md, which the comment already pointed at.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

merge: bring in director queue view from PR #984 (issue-977) 399aeb8f6f

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(director): classify queue PR rows by canonical backlog kind

test / test (pull_request) Successful in 24s

Details

15685fd511

classifyDirectorQueueOutcome compared item.Kind against
backlogKindPullRequest ("pull-request"), but the queue items stored the
display prefix ("PR"/"issue") from backlogEntryKindPrefix, so a done PR
carry could never match the PR branch and was mis-actioned as a
closeable stale-open done issue.

Store the canonical backlog kind on directorQueueItem and derive the
display prefix only at render time, so classification and formatting
each read the representation they expect. Tests now cover done PR and
done issue outcomes separately, lock the canonical Kind on every
classified item, and assert the rendered view keeps the PR/issue
prefixes without counting the done PR as a close-done action.

Repairs the review finding that blocked PR #984 (issue-977 branch,
merged into this branch).

closes #995

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coilyco-ops referenced this pull request

2026-07-10 17:15:28 +00:00

Add a director queue view for stale reservations and redispatch candidates #984

coilyco-ops referenced this pull request

2026-07-10 17:17:09 +00:00

Repair director queue PR classification from PR #984 review #995

coilyco-ops added 1 commit

2026-07-10 18:08:10 +00:00

merge: update issue-995 against main

test / test (pull_request) Successful in 27s

Details

8db427c123