coilyco-flight-deck/ward
2
0
Fork 0
Code Issues 107 Pull requests 3 Projects Releases 737 Packages Wiki Activity Actions 3

feat: add broker logs surface #987

Closed
coilyco-ops wants to merge 1 commit from issue-927 into main
pull from: issue-927
merge into: coilyco-flight-deck:main
Conversation 2 Commits 1 Files changed 11 +365 -11
coilyco-ops commented 2026-07-10 09:23:48 +00:00
Member
Copy link

closes #927
ward.workflow: pull-requests-and-merge

closes #927 ward.workflow: pull-requests-and-merge
feat: add broker logs surface
All checks were successful
test / test (pull_request) Successful in 25s
Details
b221f00490
coilyco-ops commented 2026-07-10 09:25:48 +00:00
Author
Member
Copy link

verdict: block
confidence: high
summary: The patch adds a useful broker-logs surface for dispatch wrapper and broker logs, but it misses the fresh issue-thread requirement for silent or exited engineer-log reads. ward agent logs <issue> can still choose a container/archive source and print no useful explanation.
findings:

  • severity: high
    file: cmd/ward/agent_logs.go
    line: 393
    problem: The diff routes file sources through tail/follow and adds broker-log sources, but it does not change the engineer-log path to explain an empty Docker/container/archive stream. The issue thread explicitly added a repro where warded logs coilyco-flight-deck/ward#943 --tail 120 printed the selected docker source and a container id, with no actual log lines and no explanation that the container was exited, empty, missing an archive, or failed before console capture.
    impact: The main TUI/director usability gap remains for a reserved issue whose engineer is no longer in warded list: the operator still cannot tell whether the run exited, had no logs, had no archive, or failed before capture. That is the exact state the issue asked the log surface to make legible after the initial body was amended.
    conclusion: Review blocks PR #987. Keep the new broker-log surface, but also make ward agent logs <issue> produce a clear empty-source explanation or fallback hint for the silent/exited container case, with a regression test for that repro shape.
verdict: block confidence: high summary: The patch adds a useful `broker-logs` surface for dispatch wrapper and broker logs, but it misses the fresh issue-thread requirement for silent or exited engineer-log reads. `ward agent logs <issue>` can still choose a container/archive source and print no useful explanation. findings: - severity: high file: cmd/ward/agent_logs.go line: 393 problem: The diff routes file sources through tail/follow and adds broker-log sources, but it does not change the engineer-log path to explain an empty Docker/container/archive stream. The issue thread explicitly added a repro where `warded logs coilyco-flight-deck/ward#943 --tail 120` printed the selected docker source and a container id, with no actual log lines and no explanation that the container was exited, empty, missing an archive, or failed before console capture. impact: The main TUI/director usability gap remains for a reserved issue whose engineer is no longer in `warded list`: the operator still cannot tell whether the run exited, had no logs, had no archive, or failed before capture. That is the exact state the issue asked the log surface to make legible after the initial body was amended. conclusion: Review blocks PR #987. Keep the new broker-log surface, but also make `ward agent logs <issue>` produce a clear empty-source explanation or fallback hint for the silent/exited container case, with a regression test for that repro shape.
coilyco-ops commented 2026-07-13 08:05:57 +00:00
Author
Member
Copy link

The burn-down session, working for Kai, reviewed this PR against current main and closes it as superseded.

Main absorbed the core acceptance of ward#927 while this branch sat 199 commits behind:

  • ward agent logs <ref> now falls back per-ref to the newest host dispatch wrapper log (latestDispatchLogPathForRef in cmd/ward/agent_logs.go), and the read forwards through the dispatch broker from a director surface.
  • Forwarded-dispatch failures always render a ready-to-run ward agent logs <ref> locator (cmd/ward/agent_dispatch_broker.go), so the operator never copies a host log path.
  • streamEmptyDockerAgentLogsSource plus the live transcript-tree fallback deliver the empty/silent-source legibility that the blocking review on this PR asked for.

Repo governance already recorded this disposition: ward#1149 (closed via merged PR #1163) called for closing #987 as superseded rather than rebasing it.

Landing this branch now would regress main in two spots. Its dispatchBrokerForwardedLine edit drops the per-ref locator in favor of a ref-less broker-logs --latest hint, and its keyword shim in resolveDispatchBrokerLogsSource intercepts targets ahead of main's per-issue resolution.

The still-novel remainder (no-ref latest-dispatch selection, a WARD_BROKER_LOG credential-broker read surface, and file --follow via tail) exceeds ward#927's acceptance criteria and belongs in a fresh issue against current main if still wanted. The burn-down session closes this PR and deletes branch issue-927.

The burn-down session, working for Kai, reviewed this PR against current main and closes it as superseded. Main absorbed the core acceptance of ward#927 while this branch sat 199 commits behind: * `ward agent logs <ref>` now falls back per-ref to the newest host dispatch wrapper log (`latestDispatchLogPathForRef` in `cmd/ward/agent_logs.go`), and the read forwards through the dispatch broker from a director surface. * Forwarded-dispatch failures always render a ready-to-run `ward agent logs <ref>` locator (`cmd/ward/agent_dispatch_broker.go`), so the operator never copies a host log path. * `streamEmptyDockerAgentLogsSource` plus the live transcript-tree fallback deliver the empty/silent-source legibility that the blocking review on this PR asked for. Repo governance already recorded this disposition: ward#1149 (closed via merged PR #1163) called for closing #987 as superseded rather than rebasing it. Landing this branch now would regress main in two spots. Its `dispatchBrokerForwardedLine` edit drops the per-ref locator in favor of a ref-less `broker-logs --latest` hint, and its keyword shim in `resolveDispatchBrokerLogsSource` intercepts targets ahead of main's per-issue resolution. The still-novel remainder (no-ref latest-dispatch selection, a `WARD_BROKER_LOG` credential-broker read surface, and file `--follow` via tail) exceeds ward#927's acceptance criteria and belongs in a fresh issue against current main if still wanted. The burn-down session closes this PR and deletes branch `issue-927`.
coilyco-ops closed this pull request 2026-07-13 08:06:08 +00:00
All checks were successful
test / test (pull_request) Successful in 25s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
burndown-2026-06
Backlog burndown June 2026

  
pressure-test
Cold-read release pressure-test findings and coordination

  
sunday-sprint
Burn-down by Sunday 2026-06-07

  
coherence-core
Core review set for the warded control plane coherence milestone. These issues form the release spine; adjacent milestone issues are stretch or supporting work.

  
consult
A human decision, design, or external action must happen first. Fail-closed default for unlabeled/low-confidence.

  
headless
Agent can take it from open issue to merged change with no human in the loop. The auto-burndown queue.

  
interactive
Agent does the work but pauses at a human checkpoint mid-flight (design choice, destructive step, human-only verification).

  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
burndown-2026-06
pressure-test
sunday-sprint
coherence-core
consult
headless
interactive
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/ward!987
No description provided.