Repair broker logs surface so issue-scoped agent logs explain missing output

coilyco-ops commented

2026-07-10 09:40:51 +00:00

Owner

Problem

PR ward#987 adds a useful broker-logs surface, but review blocked it because the original issue-thread requirement is still unmet for ward agent logs <issue>:

cmd/ward/agent_logs.go line 393: The diff routes file sources through the old raw path. If an issue-scoped lookup selects an exited container/archive with no log bytes, the command can still print only a container id or nothing useful, instead of explaining which source was selected and why no output is available.

The source issue ward#927 is consult-labeled, but this repair is a concrete headless behavior fix against the existing PR.

Acceptance criteria

Issue-scoped ward agent logs <issue> prints a useful explanation when the selected source has no readable log bytes.
The explanation names the selected source class enough for a director to know whether the broker log, dispatch wrapper log, running container, or archive path was used.
Tests cover the silent/exited source path, not only the new broker-logs command.
PR #987 is updated or replaced with the repaired implementation.

## Problem PR `ward#987` adds a useful `broker-logs` surface, but review blocked it because the original issue-thread requirement is still unmet for `ward agent logs <issue>`: ```text cmd/ward/agent_logs.go line 393: The diff routes file sources through the old raw path. If an issue-scoped lookup selects an exited container/archive with no log bytes, the command can still print only a container id or nothing useful, instead of explaining which source was selected and why no output is available. ``` The source issue `ward#927` is consult-labeled, but this repair is a concrete headless behavior fix against the existing PR. ## Acceptance criteria * Issue-scoped `ward agent logs <issue>` prints a useful explanation when the selected source has no readable log bytes. * The explanation names the selected source class enough for a director to know whether the broker log, dispatch wrapper log, running container, or archive path was used. * Tests cover the silent/exited source path, not only the new `broker-logs` command. * PR #987 is updated or replaced with the repaired implementation.

coilyco-ops added the

labels

2026-07-10 09:40:51 +00:00

coilyco-ops commented

2026-07-10 17:00:18 +00:00

Author

Owner

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-996 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-10T17:00:18Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#996 · branch issue-996 · harness codex · workflow pull-requests-and-merge
Run: engineer-codex-ward-996 · ward v0.584.0 · dispatched 2026-07-10T17:00:18Z
Comment thread: 1 included in the pre-flight read, 0 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-10T09:41:04Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-996` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-10T17:00:18Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#996` · branch `issue-996` · harness `codex` · workflow `pull-requests-and-merge` - **Run:** `engineer-codex-ward-996` · ward `v0.584.0` · dispatched `2026-07-10T17:00:18Z` - **Comment thread:** 1 included in the pre-flight read, 0 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T09:41:04Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops commented

2026-07-10 17:01:11 +00:00

Author

Owner

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-claude-ward-996 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness claude (reserved 2026-07-10T17:01:10Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#996 · branch issue-996 · harness claude · workflow pull-requests-and-merge
Run: engineer-claude-ward-996 · ward v0.584.0 · dispatched 2026-07-10T17:01:10Z
Comment thread: 2 included in the pre-flight read, 1 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-10T09:41:04Z), @coilyco-ops (2026-07-10T17:00:24Z)
- stripped: @coilyco-ops (2026-07-10T17:00:18Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0).

— Claude (she/her), via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-claude-ward-996` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness claude` (reserved 2026-07-10T17:01:10Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#996` · branch `issue-996` · harness `claude` · workflow `pull-requests-and-merge` - **Run:** `engineer-claude-ward-996` · ward `v0.584.0` · dispatched `2026-07-10T17:01:10Z` - **Comment thread:** 2 included in the pre-flight read, 1 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T09:41:04Z), @coilyco-ops (2026-07-10T17:00:24Z) - stripped: @coilyco-ops (2026-07-10T17:00:18Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0). </details> </details>  — Claude (she/her), via `ward agent`

coilyco-ops referenced this issue from a commit

2026-07-10 17:09:45 +00:00

fix: explain empty agent log sources

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-10 17:10:08 +00:00

Repair broker logs surface so issue-scoped agent logs explain missing output #1037

coilyco-ops referenced this issue

2026-07-10 17:10:42 +00:00

Report Codex residual commits that produce no PR or outcome #1039

coilyco-ops commented

2026-07-10 17:11:10 +00:00

Author

Owner

WARD-OUTCOME: merge-ready

details

workflow: pull-requests-and-merge; review summary: skip state (review gate skipped by `~/.ward/config.yaml` default) summary: issue-scoped empty archive reads now name the selected source class and explain the missing bytes. felt: small and direct. confidence: high. surprises: a repo-wide comment/doc-ref hook needed a tiny unrelated cleanup in `configsource.go` before commit. follow-ups: director can merge PR #1037 when ready.

WARD-OUTCOME: merge-ready <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: skip state (review gate skipped by `~/.ward/config.yaml` default) summary: issue-scoped empty archive reads now name the selected source class and explain the missing bytes. felt: small and direct. confidence: high. surprises: a repo-wide comment/doc-ref hook needed a tiny unrelated cleanup in `configsource.go` before commit. follow-ups: director can merge PR #1037 when ready. </details>

coilyco-ops commented

2026-07-10 18:16:12 +00:00

Author

Owner

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-996 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-10T18:16:11Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#996 · branch issue-996 · harness codex · workflow pull-requests-and-merge
Run: engineer-codex-ward-996 · ward v0.584.0 · dispatched 2026-07-10T18:16:11Z
Comment thread: 3 included in the pre-flight read, 2 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-10T09:41:04Z), @coilyco-ops (2026-07-10T17:00:24Z), @coilyco-ops (2026-07-10T17:11:10Z)
- stripped: @coilyco-ops (2026-07-10T17:00:18Z), @coilyco-ops (2026-07-10T17:01:11Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-996` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-10T18:16:11Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#996` · branch `issue-996` · harness `codex` · workflow `pull-requests-and-merge` - **Run:** `engineer-codex-ward-996` · ward `v0.584.0` · dispatched `2026-07-10T18:16:11Z` - **Comment thread:** 3 included in the pre-flight read, 2 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T09:41:04Z), @coilyco-ops (2026-07-10T17:00:24Z), @coilyco-ops (2026-07-10T17:11:10Z) - stripped: @coilyco-ops (2026-07-10T17:00:18Z), @coilyco-ops (2026-07-10T17:01:11Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops commented

2026-07-10 18:32:24 +00:00

Author

Owner

WARD-OUTCOME: merge-ready

details

workflow: pull-requests-and-merge; review summary: review gate skipped by ~/.ward/config.yaml default

Conflict repair only. The branch now tracks current origin/main and PR #1037 is mergeable again.

felt: mechanical after the repeated comment-only conflict.
confidence: high.
surprises: the remote main had moved again, so I had to refresh and remerge once more.
follow-ups: director can merge PR #1037.

WARD-OUTCOME: merge-ready <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: review gate skipped by ~/.ward/config.yaml default Conflict repair only. The branch now tracks current `origin/main` and PR #1037 is mergeable again. felt: mechanical after the repeated comment-only conflict. confidence: high. surprises: the remote `main` had moved again, so I had to refresh and remerge once more. follow-ups: director can merge PR #1037. </details>

coilyco-ops referenced this issue

2026-07-10 19:00:48 +00:00

Surface broker/pre-flight dispatch pathology by default: capability-detected status-line injection + out-of-band alerts #1076

coilyco-ops commented

2026-07-10 19:30:46 +00:00

Author

Owner

Post-mortem (director surface): PR #1037 for this issue was closed. It reintroduced .ward/ward-kdl/ specgen bundle files, which ward#1009 deleted and forbids restoring. This issue stays open. When the ward open-PR queue is under the backpressure threshold (6), re-cut a clean fix off current main that touches CONSUMER CODE ONLY and never restores .ward/ward-kdl/.

Post-mortem (director surface): PR #1037 for this issue was closed. It reintroduced `.ward/ward-kdl/` specgen bundle files, which ward#1009 deleted and forbids restoring. This issue stays open. When the ward open-PR queue is under the backpressure threshold (6), re-cut a clean fix off current main that touches CONSUMER CODE ONLY and never restores `.ward/ward-kdl/`.

coilysiren referenced this issue

2026-07-14 15:27:09 +00:00

director should emit colorized, space buffered, visually distinct messages about the categories of actions its performing on startup #1283

coilyco-ops commented

2026-07-15 01:17:41 +00:00

Author

Owner

WARDED_WORKFLOW: reservation-held

reservation details

Holder: launch intent for container engineer-codex-ward-996 on host kais-macbook-pro-2.local.

Accepted by ward agent --harness codex (reserved 2026-07-15T01:17:40Z). Concurrent ward agent runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). --override-reservation overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#996 · branch issue-996 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-996 · ward v0.693.0 · dispatched 2026-07-15T01:17:16Z
Comment thread: 3 included in the pre-flight read, 3 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-10T17:11:10Z), @coilyco-ops (2026-07-10T18:32:24Z), @coilyco-ops (2026-07-10T19:30:46Z)
- stripped: @coilyco-ops (2026-07-10T17:00:18Z), @coilyco-ops (2026-07-10T17:01:11Z), @coilyco-ops (2026-07-10T18:16:12Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.693.0).

— Codex, via ward agent

WARDED_WORKFLOW: reservation-held <details><summary>reservation details</summary> Holder: launch intent for container `engineer-codex-ward-996` on host `kais-macbook-pro-2.local`. Accepted by `ward agent --harness codex` (reserved 2026-07-15T01:17:40Z). Concurrent `ward agent` runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). `--override-reservation` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#996` · branch `issue-996` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-996` · ward `v0.693.0` · dispatched `2026-07-15T01:17:16Z` - **Comment thread:** 3 included in the pre-flight read, 3 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T17:11:10Z), @coilyco-ops (2026-07-10T18:32:24Z), @coilyco-ops (2026-07-10T19:30:46Z) - stripped: @coilyco-ops (2026-07-10T17:00:18Z), @coilyco-ops (2026-07-10T17:01:11Z), @coilyco-ops (2026-07-10T18:16:12Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.693.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops added this to the warded control plane coherence milestone

2026-07-15 05:14:56 +00:00

coilyco-ops added the

coherence-core

label

2026-07-15 05:28:22 +00:00

coilyco-ops commented

2026-07-15 06:55:29 +00:00

Author

Owner

Release triage note from Kai on 2026-07-15: headless carry is valid. ward agent logs <issue> should explain which source was selected and why no bytes are available, especially for exited-container and archive paths.

Release triage note from Kai on 2026-07-15: headless carry is valid. `ward agent logs <issue>` should explain which source was selected and why no bytes are available, especially for exited-container and archive paths.

coilyco-ops commented

2026-07-15 07:16:32 +00:00

Author

Owner

WARD-TRIAGE: warded control plane coherence milestone

This issue is part of the warded control plane coherence sprint. The release thesis is to make warded feel like one dependable control plane for agent work: higher safe parallelism, coherent config defaults, reliable broker/container behavior, human-feedback gates, and enough structured evidence for the next actor after a paused or failed run.

For this sprint, headless means an engineer should be able to carry the issue from current issue context to a merged change without new human decisions. If the issue discovers a missing decision, split or demote the unclear part instead of guessing.

WARD-TRIAGE: warded control plane coherence milestone This issue is part of the `warded control plane coherence` sprint. The release thesis is to make `warded` feel like one dependable control plane for agent work: higher safe parallelism, coherent config defaults, reliable broker/container behavior, human-feedback gates, and enough structured evidence for the next actor after a paused or failed run. For this sprint, `headless` means an engineer should be able to carry the issue from current issue context to a merged change without new human decisions. If the issue discovers a missing decision, split or demote the unclear part instead of guessing.

coilyco-ops commented

2026-07-15 07:16:46 +00:00

Author

Owner

WARD-TRIAGE: coherence-core label

This issue is part of the coherence-core review set for the warded control plane coherence sprint. Treat it as release-spine work: it should directly improve the safety, capacity, configuration coherence, observability, or recovery loop that makes director burndown trustworthy.

Core does not mean broader scope. Keep the implementation narrow, verify current main before reusing prior failed PRs, and split any design fork or lower-confidence follow-up out of the core path.

WARD-TRIAGE: coherence-core label This issue is part of the `coherence-core` review set for the `warded control plane coherence` sprint. Treat it as release-spine work: it should directly improve the safety, capacity, configuration coherence, observability, or recovery loop that makes director burndown trustworthy. Core does not mean broader scope. Keep the implementation narrow, verify current `main` before reusing prior failed PRs, and split any design fork or lower-confidence follow-up out of the core path.

coilyco-ops commented

2026-07-15 10:03:58 +00:00

Author

Owner

WARDED_WORKFLOW: reservation-held

reservation details

Holder: launch intent for container engineer-codex-ward-996 on host kais-macbook-pro-2.local.

Accepted by ward agent --harness codex (reserved 2026-07-15T10:03:57Z). Concurrent ward agent runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). --override-reservation overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#996 · branch issue-996 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-996 · ward v0.710.0 · dispatched 2026-07-15T10:03:51Z
Comment thread: 6 included in the pre-flight read, 4 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-10T17:11:10Z), @coilyco-ops (2026-07-10T18:32:24Z), @coilyco-ops (2026-07-10T19:30:46Z), @coilyco-ops (2026-07-15T06:55:29Z), @coilyco-ops (2026-07-15T07:16:32Z), @coilyco-ops (2026-07-15T07:16:46Z)
- stripped: @coilyco-ops (2026-07-10T17:00:18Z), @coilyco-ops (2026-07-10T17:01:11Z), @coilyco-ops (2026-07-10T18:16:12Z), @coilyco-ops (2026-07-15T01:17:41Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0).

— Codex, via ward agent

WARDED_WORKFLOW: reservation-held <details><summary>reservation details</summary> Holder: launch intent for container `engineer-codex-ward-996` on host `kais-macbook-pro-2.local`. Accepted by `ward agent --harness codex` (reserved 2026-07-15T10:03:57Z). Concurrent `ward agent` runs are blocked until this intent becomes visible or the intent is released. The stale-intent fallback is still TTL-bounded (3h TTL). `--override-reservation` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#996` · branch `issue-996` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-996` · ward `v0.710.0` · dispatched `2026-07-15T10:03:51Z` - **Comment thread:** 6 included in the pre-flight read, 4 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T17:11:10Z), @coilyco-ops (2026-07-10T18:32:24Z), @coilyco-ops (2026-07-10T19:30:46Z), @coilyco-ops (2026-07-15T06:55:29Z), @coilyco-ops (2026-07-15T07:16:32Z), @coilyco-ops (2026-07-15T07:16:46Z) - stripped: @coilyco-ops (2026-07-10T17:00:18Z), @coilyco-ops (2026-07-10T17:01:11Z), @coilyco-ops (2026-07-10T18:16:12Z), @coilyco-ops (2026-07-15T01:17:41Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.710.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-15 10:18:07 +00:00

Repair broker logs surface so issue-scoped agent logs explain missing output #1382

coilyco-ops closed this issue

2026-07-15 10:19:31 +00:00

coilyco-ops commented

2026-07-15 10:20:09 +00:00

Author

Owner

WARDED_WORKFLOW: #1382

details

workflow: pull-request-and-merge; review summary: skipped (temporary ward default pending brokered QA) review gate: intentionally skipped because the temporary ward default pending brokered QA. summary: issue-scoped empty archive and dispatch-log reads now name the selected source class and explain missing bytes. felt: mechanical after the merge refresh. confidence: high. surprises: the branch needed a sync-defaults-assets pass before tests. follow-ups: director can merge PR #1382 once ready.

WARDED_WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1382 <details><summary>details</summary> workflow: pull-request-and-merge; review summary: skipped (temporary ward default pending brokered QA) review gate: intentionally skipped because the temporary ward default pending brokered QA. summary: issue-scoped empty archive and dispatch-log reads now name the selected source class and explain missing bytes. felt: mechanical after the merge refresh. confidence: high. surprises: the branch needed a sync-defaults-assets pass before tests. follow-ups: director can merge PR #1382 once ready. </details>

coilyco-ops commented

2026-07-15 10:26:44 +00:00

Author

Owner

QA follow-up: PASS. PR #1382 merged at 8ba8a8c216. Its own PR test run 8448 succeeded; the immediate promote run 8451 was cancelled by the next main push, and the later #1384 promote/release path included #1382 on main and succeeded (promote 8452, release 8454).

Evidence checked:

Issue-scoped archive resolution now returns labeled file sources (archive path) and dispatch artifacts return dispatch log path.
ward agent logs writes using <selected source> before streaming and empty file sources print <selected source> has no readable bytes, so directors can tell which source was selected and why output is empty.
The test TestRunAgentLogsIssueScopedArchiveEmptyExplainsSelectedSource covers the silent/exited archive path required by the issue.
Focused local verification passed with broker forwarding disabled for the test shell: go test ./cmd/ward -run 'TestAgentList(PrunesFailedBeforeStartRowAfterSuccessfulDrain|KeepsFailedBeforeStartRowsVisibleButExcluded|MarksStalePrelaunchLaunchesCleanupNeeded|MarksPartialLaunchWhenReservationMarkerIsMissing|PrunesStaleReservationCacheEntry)|TestRunAgentLogsIssueScopedArchiveEmptyExplainsSelectedSource|TestRunAgentLogs(ReadsDispatchArtifact|ReadsArchivedContainer|LiveDockerEmpty)' -count=1.\n\nThe issue criteria are met; no follow-up issue needed.

QA follow-up: PASS. PR #1382 merged at 8ba8a8c21678975921505ac83d3b501ebe0d4c6e. Its own PR test run 8448 succeeded; the immediate promote run 8451 was cancelled by the next main push, and the later #1384 promote/release path included #1382 on main and succeeded (promote 8452, release 8454). Evidence checked: - Issue-scoped archive resolution now returns labeled file sources (`archive path`) and dispatch artifacts return `dispatch log path`. - `ward agent logs` writes `using <selected source>` before streaming and empty file sources print `<selected source> has no readable bytes`, so directors can tell which source was selected and why output is empty. - The test `TestRunAgentLogsIssueScopedArchiveEmptyExplainsSelectedSource` covers the silent/exited archive path required by the issue. - Focused local verification passed with broker forwarding disabled for the test shell: `go test ./cmd/ward -run 'TestAgentList(PrunesFailedBeforeStartRowAfterSuccessfulDrain|KeepsFailedBeforeStartRowsVisibleButExcluded|MarksStalePrelaunchLaunchesCleanupNeeded|MarksPartialLaunchWhenReservationMarkerIsMissing|PrunesStaleReservationCacheEntry)|TestRunAgentLogsIssueScopedArchiveEmptyExplainsSelectedSource|TestRunAgentLogs(ReadsDispatchArtifact|ReadsArchivedContainer|LiveDockerEmpty)' -count=1`.\n\nThe issue criteria are met; no follow-up issue needed.

Rows
Columns

Repair broker logs surface so issue-scoped agent logs explain missing output #996

Problem

Acceptance criteria