chore(typos): drop config that protects nothing (#969) #1184

Merged

coilyco-ops merged 2 commits from aos/969-typos-excludes into main

2026-08-22 21:42:15 +00:00

coilyco-ops commented

2026-08-22 21:37:37 +00:00

Member

Closes #969.

The premise did not survive checking

#969 said [files] extend-exclude "has no effect under pre-commit" and proposed a new [tool.agentic-os.typos] excludes key feeding an exclude: line into the generated block.

It does have an effect, conditionally. Measured against typos-cli 1.48.0, the same two explicit paths with evaluations/** excluded:

$ typos evaluations/answer.json prose.md            # both read
$ typos --force-exclude evaluations/answer.json prose.md   # only prose.md read

pre-commit hands typos explicit paths, so the flag is what makes the exclusion bind. #1152 restored --force-exclude to the generated block for eco-app#316 and never referenced this issue, which is why it stayed open. This repo's own *.json entry is live under the flag, verified the same way.

So the proposed new config key is not needed: it would add a second, lower-precision path-exclusion surface next to a .typos.toml that already works.

What was actually left

The issue's second half - "worth confirming whether this repo's existing entries should move, so the config does not appear to protect files it does not."

docs/ward-ops-forgejo-reference.md no longer exists.
Six accepted words matched nothing tracked. Each was checked by dropping it alone and running typos over git ls-files: unparseable, reqests, commiter, embeded, aks, ser. The five that still carry a real file (mis, requets, SOM, Iz, hashi) stay.

That directly answers the issue's own worry that word-level opt-outs "weaken the check for genuine prose and grow with every new evidence file."

A two-line header in .typos.toml now records why path exclusion binds, so the next reader does not re-file this. The flag itself is already guarded by an assertion in tests/test_apply_agentic_os_hooks.py, so it cannot silently go missing again.

pre-commit run --all-files passes, and typos over every tracked file exits 0.

Closes #969. ## The premise did not survive checking #969 said `[files] extend-exclude` "has no effect under pre-commit" and proposed a new `[tool.agentic-os.typos] excludes` key feeding an `exclude:` line into the generated block. It does have an effect, conditionally. Measured against typos-cli 1.48.0, the same two explicit paths with `evaluations/**` excluded: ``` $ typos evaluations/answer.json prose.md # both read $ typos --force-exclude evaluations/answer.json prose.md # only prose.md read ``` pre-commit hands typos explicit paths, so the flag is what makes the exclusion bind. #1152 restored `--force-exclude` to the generated block for eco-app#316 and never referenced this issue, which is why it stayed open. This repo's own `*.json` entry is live under the flag, verified the same way. So the proposed new config key is not needed: it would add a second, lower-precision path-exclusion surface next to a `.typos.toml` that already works. ## What was actually left The issue's second half - "worth confirming whether this repo's existing entries should move, so the config does not appear to protect files it does not." * `docs/ward-ops-forgejo-reference.md` no longer exists. * Six accepted words matched nothing tracked. Each was checked by dropping it alone and running typos over `git ls-files`: `unparseable`, `reqests`, `commiter`, `embeded`, `aks`, `ser`. The five that still carry a real file (`mis`, `requets`, `SOM`, `Iz`, `hashi`) stay. That directly answers the issue's own worry that word-level opt-outs "weaken the check for genuine prose and grow with every new evidence file." A two-line header in `.typos.toml` now records why path exclusion binds, so the next reader does not re-file this. The flag itself is already guarded by an assertion in `tests/test_apply_agentic_os_hooks.py`, so it cannot silently go missing again. `pre-commit run --all-files` passes, and typos over every tracked file exits 0.

coilyco-ops added 1 commit

2026-08-22 21:37:37 +00:00

chore(typos): drop config that protects nothing (#969 )

ci / aos-eval-tests (pull_request) Successful in 9s

Details

ci / aos-cli-tests (pull_request) Successful in 23s

Details

ci / ward-doctor (pull_request) Successful in 17s

Details

ci / gate (pull_request) Successful in 1m4s

Details

7c681e04cc

Path exclusion under pre-commit was the real complaint, and #1152 fixed it
by restoring --force-exclude to the generated hook: pre-commit hands typos
explicit paths, and without that flag `[files] extend-exclude` is inert.
That commit cited eco-app#316 and never closed this issue.

Verified against typos-cli 1.48.0 rather than assumed. The same two explicit
paths, with the exclude in place: without --force-exclude both are read,
with it the excluded one is skipped. This repo's own *.json entry is live
under the flag.

What was left was the second half of the issue, that the config should not
appear to protect files it does not:

* docs/ward-ops-forgejo-reference.md no longer exists.
* Six accepted words matched nothing tracked. Each was checked by dropping
  it alone and running typos over `git ls-files`: unparseable, reqests,
  commiter, embeded, aks, ser. The five that still carry a file stay.

The flag itself is already guarded by a test in test_apply_agentic_os_hooks,
so it cannot silently go missing again.

Closes #969

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops added 1 commit

2026-08-22 21:39:58 +00:00

Merge branch 'main' into aos/969-typos-excludes

ci / aos-eval-tests (pull_request) Successful in 8s

Details

ci / aos-cli-tests (pull_request) Successful in 28s

Details

ci / ward-doctor (pull_request) Successful in 18s

Details

ci / gate (pull_request) Successful in 1m7s

Details

f18636ae3a