fix(pre-commit): keep --force-exclude on the generated typos hook #1152

Merged

coilysiren merged 1 commit from fix/typos-force-exclude into main

2026-08-20 08:06:58 +00:00

coilyco-ops commented

2026-08-20 08:02:47 +00:00

Member

The generated block passed args: [] to drop upstream's --write-changes, which also dropped --force-exclude. pre-commit hands typos explicit paths, so without that flag a consumer's _typos.toml [files] extend-exclude is inert and only word lists take effect.

eco-app hit this while excluding its vendored Eco recipe graph (data/eco_gnome_data.json), whose item names and localized strings are upstream's spelling. Word-listing them instead would globally whitelist ba, sie, ist, ein, bord, and friends across real source.

The generated hook keeps reporting rather than rewriting, since --write-changes stays dropped.

Refs coilyco-gaming/eco-app#316

The generated block passed `args: []` to drop upstream's `--write-changes`, which also dropped `--force-exclude`. pre-commit hands typos explicit paths, so without that flag a consumer's `_typos.toml` `[files] extend-exclude` is inert and only word lists take effect. eco-app hit this while excluding its vendored Eco recipe graph (`data/eco_gnome_data.json`), whose item names and localized strings are upstream's spelling. Word-listing them instead would globally whitelist `ba`, `sie`, `ist`, `ein`, `bord`, and friends across real source. The generated hook keeps reporting rather than rewriting, since `--write-changes` stays dropped. Refs coilyco-gaming/eco-app#316

coilyco-ops added 1 commit

2026-08-20 08:02:48 +00:00

fix(pre-commit): keep --force-exclude on the generated typos hook

ci / aos-cli-tests (pull_request) Successful in 21s

Details

ci / aos-eval-tests (pull_request) Successful in 6s

Details

ci / ward-doctor (pull_request) Successful in 12s

Details

ci / gate (pull_request) Successful in 56s

Details

160bd8bffa

The generated block passed `args: []` to drop upstream's --write-changes,
which also dropped --force-exclude. pre-commit hands typos explicit paths,
so without that flag a consumer's `_typos.toml` `[files] extend-exclude` is
inert and only word lists take effect. eco-app hit this excluding its
vendored Eco recipe graph.

Refs coilyco-gaming/eco-app#316

coilyco-ops requested review from coilysiren

2026-08-20 08:02:48 +00:00

coilysiren merged commit 48ecbeaae2 into main

2026-08-20 08:06:58 +00:00

coilysiren referenced this pull request from a commit

2026-08-20 08:06:58 +00:00

fix(pre-commit): keep --force-exclude on the generated typos hook (#1152)

coilysiren deleted branch fix/typos-force-exclude

2026-08-20 08:06:58 +00:00

coilyco-ops referenced this pull request from coilyco-gaming/eco-app

2026-08-20 08:19:06 +00:00

The managed hook block is pinned to the retired v0.193.0 train, and bumping it opens 73 pre-existing violations #316