revert(shell): drop the acompose director carve-out #1039

Merged

coilysiren merged 1 commit from aos/claude/fx48 into main

2026-08-13 09:39:14 +00:00

coilyco-ops commented

2026-08-13 09:31:44 +00:00

Member

acompose director <harness> routed to aos --warded --composed --guarded while every other role went to the native shadow. Kai asked for the carve-out gone, so acompose now treats director like any other role.

This knowingly reverts the shell half of #815 and reopens #811. The root cause is still live:

WARD_BROKER_SOCK appears nowhere on the native path.
aos-cli/native_shadow.go has no broker wiring.

So a native director cannot dispatch engineers, and aosguard falls through to SSM for Forgejo credential resolution. A warded launch stays available by hand (aos --agent <harness> --role director --warded --composed --guarded) for sessions that need dispatch.

Scope

shell/common.sh - director branch deleted.
tests/test_shell_agent_launch.py - the warded-director test now asserts the native-shadow path, and the sibling test loses its now-meaningless non_director name.
docs/native-agent-workspaces.md - the claim that director uses warded AOS was false after this change.

Untouched, and still special-casing director: the director/engineer/qa fixed Ward lanes and argument rules in aos-cli/composition.go, and the director/ops kubeconfig mount in aos-cli/kubeconfig.go.

Validation

ward exec test - 522 passed
pre-commit run --all-files - all hooks passed

`acompose director <harness>` routed to `aos --warded --composed --guarded` while every other role went to the native shadow. Kai asked for the carve-out gone, so acompose now treats director like any other role. **This knowingly reverts the shell half of #815 and reopens #811.** The root cause is still live: * `WARD_BROKER_SOCK` appears nowhere on the native path. * `aos-cli/native_shadow.go` has no broker wiring. So a native director cannot dispatch engineers, and aosguard falls through to SSM for Forgejo credential resolution. A warded launch stays available by hand (`aos --agent <harness> --role director --warded --composed --guarded`) for sessions that need dispatch. ## Scope * `shell/common.sh` - director branch deleted. * `tests/test_shell_agent_launch.py` - the warded-director test now asserts the native-shadow path, and the sibling test loses its now-meaningless `non_director` name. * `docs/native-agent-workspaces.md` - the claim that director uses warded AOS was false after this change. Untouched, and still special-casing director: the `director`/`engineer`/`qa` fixed Ward lanes and argument rules in `aos-cli/composition.go`, and the `director`/`ops` kubeconfig mount in `aos-cli/kubeconfig.go`. ## Validation * `ward exec test` - 522 passed * `pre-commit run --all-files` - all hooks passed

coilyco-ops added 1 commit

2026-08-13 09:31:44 +00:00

revert(shell): drop the acompose director carve-out

ci / aos-cli-tests (pull_request) Successful in 33s

Details

ci / ward-doctor (pull_request) Successful in 18s

Details

ci / gate (pull_request) Successful in 1m3s

Details

94bdecee69

`acompose director <harness>` routed to `aos --warded --composed --guarded`
while every other role went to the native shadow. Kai asked for the carve-out
gone, so acompose now treats director like any other role.

This knowingly reverts the shell half of #815 and reopens #811. The root cause
is still live: `WARD_BROKER_SOCK` appears nowhere on the native path and
`aos-cli/native_shadow.go` has no broker wiring, so a native director cannot
dispatch engineers and aosguard falls through to SSM for Forgejo credentials.
A warded launch remains available by hand for the sessions that need dispatch.

The director/engineer/qa carve-outs in aos-cli (fixed Ward lanes, argument
rules) and the director/ops kubeconfig carve-out are untouched.

Validation:
* ward exec test: 522 passed
* pre-commit run --all-files: all hooks passed

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 09:31:44 +00:00