Remove aos-owned surface-check script #505

New issue

Closed

opened 2026-07-13 19:12:14 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-13 19:12:14 +00:00

Member

Remove .ward/surface-check.sh and the aos-owned surface self-check wiring.

Problem:

.ward/surface-check.sh should not exist in agentic-os as a shipped script.
It is an old role capability probe from the agentic-os#447 surface-tier design.
The file is still exposed as ward exec surface-check, and docs say it rides the ward-specs bundle.
If this capability is still needed, it belongs in ward's launch/reconcile path, where ward owns the container bring-up state and can make the check authoritative. An aos shell script that probes the live surface is the wrong ownership layer.

Current references found from the director surface:

.ward/surface-check.sh
.ward/ward.yaml exposes surface-check
docs/role-surface-tiers.md has a "self-check" section linking the script
docs/FEATURES.md advertises "Role surface tiers" plus the bring-up self-check
agentic_os/pre_commit/check_ward_specs_bundle.py still expects ./surface-check.sh in the old bundle file list

Required fix:

Delete .ward/surface-check.sh.
Remove the surface-check ward verb from .ward/ward.yaml.
Update docs/role-surface-tiers.md so it documents the role capability map only, not an aos-owned shell self-check. If the live check is still desired, point to a ward issue or ward-owned mechanism instead.
Update docs/FEATURES.md to remove the bring-up self-check claim.
Remove stale surface-check.sh references from tests, validators, release packaging, and docs.
Coordinate with the existing stale bundle-validator cleanup (#503): if agentic_os/pre_commit/check_ward_specs_bundle.py is already gone, do not reintroduce it. If it still exists, remove its surface-check expectation as part of deleting that validator.
Grep before landing: rg -n "surface-check|surface check|surface_check" .

Validation:

Run relevant docs/tests through ward.
Run ward doctor after removing the file from the ward config surface.

Acceptance:

.ward/surface-check.sh no longer exists.
ward exec surface-check is no longer advertised by this repo.
No aos docs claim this repo ships a live surface self-check script.
Any remaining role-surface documentation is explicitly descriptive, not a script contract.

Remove `.ward/surface-check.sh` and the aos-owned surface self-check wiring. Problem: - `.ward/surface-check.sh` should not exist in agentic-os as a shipped script. - It is an old role capability probe from the `agentic-os#447` surface-tier design. - The file is still exposed as `ward exec surface-check`, and docs say it rides the ward-specs bundle. - If this capability is still needed, it belongs in ward's launch/reconcile path, where ward owns the container bring-up state and can make the check authoritative. An aos shell script that probes the live surface is the wrong ownership layer. Current references found from the director surface: - `.ward/surface-check.sh` - `.ward/ward.yaml` exposes `surface-check` - `docs/role-surface-tiers.md` has a "self-check" section linking the script - `docs/FEATURES.md` advertises "Role surface tiers" plus the bring-up self-check - `agentic_os/pre_commit/check_ward_specs_bundle.py` still expects `./surface-check.sh` in the old bundle file list Required fix: - Delete `.ward/surface-check.sh`. - Remove the `surface-check` ward verb from `.ward/ward.yaml`. - Update `docs/role-surface-tiers.md` so it documents the role capability map only, not an aos-owned shell self-check. If the live check is still desired, point to a ward issue or ward-owned mechanism instead. - Update `docs/FEATURES.md` to remove the bring-up self-check claim. - Remove stale `surface-check.sh` references from tests, validators, release packaging, and docs. - Coordinate with the existing stale bundle-validator cleanup (#503): if `agentic_os/pre_commit/check_ward_specs_bundle.py` is already gone, do not reintroduce it. If it still exists, remove its surface-check expectation as part of deleting that validator. - Grep before landing: `rg -n "surface-check|surface check|surface_check" .` Validation: - Run relevant docs/tests through ward. - Run `ward doctor` after removing the file from the ward config surface. Acceptance: - `.ward/surface-check.sh` no longer exists. - `ward exec surface-check` is no longer advertised by this repo. - No aos docs claim this repo ships a live surface self-check script. - Any remaining role-surface documentation is explicitly descriptive, not a script contract.

~~coilyco-ops referenced this issue 2026-07-13 21:53:43 +00:00~~

Remove aos-owned surface-check script #507

coilyco-ops commented

2026-07-13 21:58:24 +00:00

Author

Member

WARDED_WORKFLOW: #507

details

workflow: pull-request-and-merge; review summary: skipped - temporary ward default pending brokered QA
felt like a small mechanical cleanup. confidence: high. surprises: none beyond the stale bundle expectation. follow-ups: merge the open PR once the gate is accepted.

WARDED_WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/agentic-os/pulls/507 <details><summary>details</summary> workflow: pull-request-and-merge; review summary: skipped - temporary ward default pending brokered QA felt like a small mechanical cleanup. confidence: high. surprises: none beyond the stale bundle expectation. follow-ups: merge the open PR once the gate is accepted. </details>

coilyco-ops commented

2026-07-13 22:02:35 +00:00

Author

Member

PR #507 is green but conflicted after #506 merged. Repair request: update branch issue-505 against current main, keep the .ward/surface-check.sh removal and doc updates, and drop the stale agentic_os/pre_commit/check_ward_specs_bundle.py edit because #506 deleted that file. Then rerun the repo validation and update the existing PR.

PR #507 is green but conflicted after #506 merged. Repair request: update branch `issue-505` against current `main`, keep the `.ward/surface-check.sh` removal and doc updates, and drop the stale `agentic_os/pre_commit/check_ward_specs_bundle.py` edit because #506 deleted that file. Then rerun the repo validation and update the existing PR.

coilyco-ops closed this issue

2026-07-14 07:40:35 +00:00