Remove stale ward specs bundle validator #503

New issue

Closed

opened 2026-07-13 18:56:48 +00:00 by coilyco-ops · 1 comment

coilyco-ops commented

2026-07-13 18:56:48 +00:00

Member

Remove the stale ward specs bundle pre-commit validator and all hardcoded bundle-path test residue.

Context:

agentic_os/pre_commit/check_ward_specs_bundle.py should not exist anymore.
Commit 27eccc205a1c76d9fff3996f0ca545e988f9b4f7 moved tests away from encoding config values, but a simple grep still finds stale bundle/default path coupling.
The current miss is visible with:
- rg -n "check_ward_specs_bundle|ward\\.bundle|ward specs bundle|bundle\\.kdl|defaults\\.kdl|workflow\\.kdl" .
At this surface snapshot, hits include:
- agentic_os/pre_commit/check_ward_specs_bundle.py
- tests/test_ward_specs_bundle.py

Required fix:

Delete agentic_os/pre_commit/check_ward_specs_bundle.py entirely.
Remove any packaging or entry-point reference to that hook if present.
Remove or rename tests/test_ward_specs_bundle.py content that is only testing hardcoded config paths.
Keep only tests that validate behavior not owned by ward's config loader. Config validity belongs to ward doctor, not pytest assertions against KDL paths or literals.
Grep the entire repo before finishing for these stale identifiers and remove or update every relevant hit:
- check_ward_specs_bundle
- ward.bundle.kdl
- defaults.kdl where it means the old workflow/defaults file
- ward-kdl.defaults.kdl
- ward specs bundle where the wording no longer matches the live model
Coordinate with the rename from .ward/defaults.kdl to .ward/workflow.kdl and the move from defaults.agent-workflow to a top-level workflow block. If that change has already landed, this fix should build on it. If it has not landed, preserve compatibility only where genuinely necessary and call out any follow-up.
Run the relevant unit tests and pre-commit through ward.

Acceptance:

agentic_os/pre_commit/check_ward_specs_bundle.py is gone.
No tests assert hardcoded ward config paths or hardcoded KDL config content.
The repo no longer has stale references to the removed bundle validator.
ward doctor remains the config-validity gate.

Remove the stale ward specs bundle pre-commit validator and all hardcoded bundle-path test residue. Context: - `agentic_os/pre_commit/check_ward_specs_bundle.py` should not exist anymore. - Commit `27eccc205a1c76d9fff3996f0ca545e988f9b4f7` moved tests away from encoding config values, but a simple grep still finds stale bundle/default path coupling. - The current miss is visible with: - `rg -n "check_ward_specs_bundle|ward\\.bundle|ward specs bundle|bundle\\.kdl|defaults\\.kdl|workflow\\.kdl" .` - At this surface snapshot, hits include: - `agentic_os/pre_commit/check_ward_specs_bundle.py` - `tests/test_ward_specs_bundle.py` Required fix: - Delete `agentic_os/pre_commit/check_ward_specs_bundle.py` entirely. - Remove any packaging or entry-point reference to that hook if present. - Remove or rename `tests/test_ward_specs_bundle.py` content that is only testing hardcoded config paths. - Keep only tests that validate behavior not owned by ward's config loader. Config validity belongs to `ward doctor`, not pytest assertions against KDL paths or literals. - Grep the entire repo before finishing for these stale identifiers and remove or update every relevant hit: - `check_ward_specs_bundle` - `ward.bundle.kdl` - `defaults.kdl` where it means the old workflow/defaults file - `ward-kdl.defaults.kdl` - `ward specs bundle` where the wording no longer matches the live model - Coordinate with the rename from `.ward/defaults.kdl` to `.ward/workflow.kdl` and the move from `defaults.agent-workflow` to a top-level `workflow` block. If that change has already landed, this fix should build on it. If it has not landed, preserve compatibility only where genuinely necessary and call out any follow-up. - Run the relevant unit tests and pre-commit through ward. Acceptance: - `agentic_os/pre_commit/check_ward_specs_bundle.py` is gone. - No tests assert hardcoded ward config paths or hardcoded KDL config content. - The repo no longer has stale references to the removed bundle validator. - `ward doctor` remains the config-validity gate.

coilyco-ops referenced this issue

2026-07-13 19:12:14 +00:00

Remove aos-owned surface-check script #505

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-13 21:53:20 +00:00

fix: remove stale ward specs bundle validator #506

coilyco-ops commented

2026-07-13 21:57:10 +00:00

Author

Member

WARD-OUTCOME: submitted

details

workflow: pull-request-and-merge; review summary: skip - in-container review gate intentionally skipped because the temporary ward default pending brokered QA
felt: straightforward cleanup, no config behavior changed
confidence: high
surprises: none after the live workflow rename had already landed
follow-ups: director merge once the PR stays green

WARD-OUTCOME: submitted <details><summary>details</summary> workflow: pull-request-and-merge; review summary: skip - in-container review gate intentionally skipped because the temporary ward default pending brokered QA felt: straightforward cleanup, no config behavior changed confidence: high surprises: none after the live workflow rename had already landed follow-ups: director merge once the PR stays green </details>

coilyco-ops closed this issue

2026-07-13 22:00:26 +00:00