Two leftovers from retiring the thread-prefill toggle

coilyco-ops commented

2026-08-15 17:18:33 +00:00

Member

This PR is no longer what its title said, because #834 landed the same change first. Rewritten to match what it now contains.

What happened

Two seats built the removal for #769 in parallel. #834 (wy58-thread-prefill-always) merged as 979ff6d while this branch was open. All four merge conflicts were the two versions of the same fix, and every one resolves to main's, which is the landed one.

Main's version is also better in one place worth naming. This branch deleted configured_channels from discord.ready along with the toggle, on the reading that it went in with it. It did go in with it, in b5a3422, but it counts DISCORD_CHANNEL_ID — the admission allowlist — rather than anything about prefill. It is useful boot context on its own, and main keeps it.

So the removal itself contributes nothing now. What survives is two things #834 left behind.

Leftover one: the features inventory still advertises the toggle

docs/features-response-service.md still read:

Whole-thread prefill inside a thread, per parent channel and off by default, dropping oldest first...

That is the behaviour #834 deleted. This file is the inventory of what ships, so a wrong line in it is worse than no line: it is the thing a reader consults instead of the code.

Leftover two: a comment justifying a field by a retired default

discord.ready still carried:

// Stated at boot rather than assumed, so default-off is observable.
slog.Int("configured_channels", len(a.cfg.DiscordChannelIDs)),

There is no default-off any more. The field stays, for the reason above, and the comment now says what it actually counts and notes that it outlived what it was added for.

Why not just close this

Closing it would have dropped both leftovers on the floor, and neither is visible from #834's diff — one is a file #834 never touched, the other is a comment that stayed true-looking while the thing it described was deleted. They are only findable from the collision.

If you would rather these landed under a different number, close this and I will re-file. The two commits are a merge and a four-line fix.

Verified

ward exec gate green: build, policy-check, vet, test, test-skips, pre-commit. The diff against main is docs/features-response-service.md plus the one comment.

**This PR is no longer what its title said, because #834 landed the same change first.** Rewritten to match what it now contains. ## What happened Two seats built the removal for #769 in parallel. #834 (`wy58-thread-prefill-always`) merged as `979ff6d` while this branch was open. All four merge conflicts were the two versions of the same fix, and every one resolves to main's, which is the landed one. Main's version is also better in one place worth naming. This branch deleted `configured_channels` from `discord.ready` along with the toggle, on the reading that it went in with it. It did go in with it, in `b5a3422`, but it counts `DISCORD_CHANNEL_ID` — the admission allowlist — rather than anything about prefill. It is useful boot context on its own, and main keeps it. So the removal itself contributes nothing now. What survives is two things #834 left behind. ## Leftover one: the features inventory still advertises the toggle `docs/features-response-service.md` still read: > Whole-thread prefill inside a thread, **per parent channel and off by default**, dropping oldest first... That is the behaviour #834 deleted. This file is the inventory of what ships, so a wrong line in it is worse than no line: it is the thing a reader consults instead of the code. ## Leftover two: a comment justifying a field by a retired default `discord.ready` still carried: ```go // Stated at boot rather than assumed, so default-off is observable. slog.Int("configured_channels", len(a.cfg.DiscordChannelIDs)), ``` There is no default-off any more. The field stays, for the reason above, and the comment now says what it actually counts and notes that it outlived what it was added for. ## Why not just close this Closing it would have dropped both leftovers on the floor, and neither is visible from #834's diff — one is a file #834 never touched, the other is a comment that stayed true-looking while the thing it described was deleted. They are only findable from the collision. If you would rather these landed under a different number, close this and I will re-file. The two commits are a merge and a four-line fix. ## Verified `ward exec gate` green: build, policy-check, vet, test, test-skips, pre-commit. The diff against `main` is `docs/features-response-service.md` plus the one comment.

coilyco-ops added 1 commit

2026-08-15 17:18:33 +00:00

fix(discord): read every thread whole, with nothing to switch on

ci / image-build (pull_request) Successful in 23s

Details

ci / test (pull_request) Successful in 42s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

63af061272

The spec called for a per-channel toggle and Kai removed it on the issue. A
thread is a bounded conversation someone deliberately opened, so reading it
whole is what the feature means everywhere rather than a per-channel
preference.

Being in a thread is now the whole condition. `SIRENS_ECHO_THREAD_PREFILL_CHANNELS`,
its boot validation, and the resolved counts on `discord.ready` are gone with
it, along with the tests that verified a default nobody has any more.

The context budget and the bounded walk are what hold the cost down. Both are
unchanged, as is the annotation that reports what either of them dropped.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-15 17:18:33 +00:00

coilyco-ops referenced this pull request

2026-08-15 17:18:49 +00:00

Discord prefills should pull the whole thread when inside one, per-channel toggle #769

coilyco-ops added 2 commits

2026-08-15 20:21:10 +00:00

Merge main, which already landed this change fdd51ae2bd

#834 landed the same removal from `wy58-thread-prefill-always` while
this branch was open, so all four conflicts are two seats having written
the same fix. Every one resolves to main's version, which is the landed
one.

Main's version is also the better one in one place. This branch deleted
`configured_channels` from `discord.ready` along with the toggle, but
that field counts `DISCORD_CHANNEL_ID`, the admission allowlist, rather
than anything about prefill. It is useful boot context on its own and
main keeps it.

What survives is one line main got wrong.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

docs(threads): stop describing the toggle #834 retired

ci / image-build (pull_request) Successful in 24s

Details

ci / test (pull_request) Successful in 42s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

3afa1fa960

Two leftovers from landing the removal.

`features-response-service.md` still advertised whole-thread prefill as
"per parent channel and off by default", which is the behaviour that was
just deleted. It reads as an inventory of what ships, so a wrong line
there is worse than no line.

`discord.ready` still justified `configured_channels` by making
"default-off observable". The field is worth keeping, because it counts
the admission allowlist rather than anything about prefill, but the
reason attached to it no longer exists.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops changed title from ~~fix(discord): read every thread whole, with nothing to switch on~~ to Two leftovers from retiring the thread-prefill toggle

2026-08-15 20:21:30 +00:00