coilyco-gaming/sirens-echo

Watch

Anchor on the card, not on upstream's sentence #774

Merged

coilysiren merged 1 commit from eng/unpin-the-card-wording into main

2026-08-14 04:53:03 +00:00

coilyco-ops commented

2026-08-14 04:49:21 +00:00

Member

Two lines. Land this first — it is the only one of the three that is green today.

closes #773

What it fixes

ValidateSystemPrompt required the literal Agent-compose assigned the. agent-compose owns that sentence and rewrote it in 2.20.0 to assigned **you** the, so every composing role fails against a current bundle:

role ai: composed profile is missing bundle surface "Agent-compose assigned the"

Failing closed is correct — a bundle that did not compose must never ship as a quietly neutral agent. But the trigger here was a copy edit upstream, and the error cannot distinguish that from a real composition failure.

The anchor now matches the half of the line that identifies the card rather than the sentence built around it. It holds against both the 2.19.0 and 2.20.0 wording. The other three anchors are structural rather than prose and are untouched.

Why it is split out, and the order that follows

I had the order wrong when I opened #771 and commented on agentic-os#1052. Correcting it here.

#771 carries the seat rename, which needs 2.20.0 to compose. The image build bakes with agentic-os:release, which still ships 2.19.0 — so #771 fails ci / image-build today and cannot go first. Its ci / test passes; only the bake fails.

Because this PR is backward compatible, the real sequence is:

This PR — green now, and makes main tolerate either wording.
coilyco-flight-deck/agentic-os#1052 — bumps the pin to 2.20.0. Fully green already.
Wait for agentic-os:release to republish.
#771 — the seat rename, which turns green once step 3 lands.

Without step 1, step 2 leaves main unbuildable until #771 merges. With it, there is no red window.

Verification

go test ./... and the full pre-commit suite pass. I verified all four anchors against real bundles baked from both 2.19.0 and 2.20.0 against the live catalogue, which is how the break was found in the first place.

🤖 Generated with Claude Code

Two lines. Land this first — it is the only one of the three that is green today. closes #773 ## What it fixes `ValidateSystemPrompt` required the literal `Agent-compose assigned the`. agent-compose owns that sentence and rewrote it in 2.20.0 to `assigned **you** the`, so every composing role fails against a current bundle: ``` role ai: composed profile is missing bundle surface "Agent-compose assigned the" ``` Failing closed is correct — a bundle that did not compose must never ship as a quietly neutral agent. But the trigger here was a copy edit upstream, and the error cannot distinguish that from a real composition failure. The anchor now matches the half of the line that identifies the card rather than the sentence built around it. It holds against **both** the 2.19.0 and 2.20.0 wording. The other three anchors are structural rather than prose and are untouched. ## Why it is split out, and the order that follows I had the order wrong when I opened #771 and commented on agentic-os#1052. Correcting it here. #771 carries the seat rename, which needs 2.20.0 to compose. The image build bakes with `agentic-os:release`, which still ships 2.19.0 — so #771 fails `ci / image-build` today and cannot go first. Its `ci / test` passes; only the bake fails. Because this PR is backward compatible, the real sequence is: 1. **This PR** — green now, and makes `main` tolerate either wording. 2. **coilyco-flight-deck/agentic-os#1052** — bumps the pin to 2.20.0. Fully green already. 3. Wait for `agentic-os:release` to republish. 4. **#771** — the seat rename, which turns green once step 3 lands. Without step 1, step 2 leaves `main` unbuildable until #771 merges. With it, there is no red window. ## Verification `go test ./...` and the full pre-commit suite pass. I verified all four anchors against real bundles baked from both 2.19.0 and 2.20.0 against the live catalogue, which is how the break was found in the first place. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

coilyco-ops added 1 commit

2026-08-14 04:49:22 +00:00

fix(compose): anchor on the card, not on upstream's sentence

ci / image-build (pull_request) Successful in 25s

Details

ci / test (pull_request) Successful in 43s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

5b23fbf10a

ValidateSystemPrompt required the literal "Agent-compose assigned the" in a
composing profile's prompt. agent-compose owns that sentence and rewrote it in
2.20.0 to "assigned you the", so every composing role fails against a current
bundle:

    role ai: composed profile is missing bundle surface "Agent-compose assigned the"

Failing closed is right, since a bundle that did not compose must not ship as a
quietly neutral agent. But the trigger was a copy edit upstream, and the error
cannot tell that apart from a real composition failure.

The anchor now matches the half of the line that identifies the card rather than
the sentence around it. It holds against both the 2.19.0 and 2.20.0 wording, so
it lands safely on either side of the base-image bump, and a future rewording
upstream stops being a build break here.

The other three anchors are structural rather than prose and are unchanged.

Split from the seat rename, which needs 2.20.0 and cannot pass CI until
agentic-os:release carries it. This one removes the window where that bump would
leave main unbuildable.

closes #773

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-14 04:49:22 +00:00

coilyco-ops referenced this pull request

2026-08-14 04:49:37 +00:00

Name Echo's seat, and unpin the card wording #771

coilysiren merged commit a35953a95e into main

2026-08-14 04:53:03 +00:00

coilysiren referenced this pull request from a commit

2026-08-14 04:53:03 +00:00

Merge pull request 'Anchor on the card, not on upstream's sentence' (#774) from eng/unpin-the-card-wording into main

coilyco-ops commented

2026-08-14 04:59:48 +00:00

Author

Member

Closing as already landed.

internal/community/prompt.go and internal/community/compose_test.go are both byte-identical between main and this branch's head, and main already carries the loosened anchor: it has "Agent-compose assigned" and no longer has "Agent-compose assigned the".

The fix is in effect. The main...head compare shows zero commits ahead, so there is nothing left to merge.

Branch left in place, so this is reopenable.

Closing as already landed. `internal/community/prompt.go` and `internal/community/compose_test.go` are both byte-identical between `main` and this branch's head, and `main` already carries the loosened anchor: it has `"Agent-compose assigned"` and no longer has `"Agent-compose assigned the"`. The fix is in effect. The `main...head` compare shows zero commits ahead, so there is nothing left to merge. Branch left in place, so this is reopenable.

coilyco-ops referenced this pull request from a commit

2026-08-14 05:04:44 +00:00

merge: take the anchor fix from main

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-gaming/sirens-echo!774

No description provided.

Rows
Columns