test(fetch): point the nine open label rows at the issue that is open #728

Merged

coilyco-ops merged 1 commit from quail/retag-label-rows into main

2026-08-13 21:01:53 +00:00

coilyco-ops commented

2026-08-13 20:58:06 +00:00

Member

Points nine failing rows at an issue that exists.

The problem

hostlabelshape_test.go reports nine open rows today:

9 rows still disagree with intended behaviour

Every one carried issue: "674". sirens-echo#674 closed at 18:38 today, when sirens-echo#680 merged and fixed three of the four shapes it named. The nine remaining shapes were measured after that and have been tracked on a closed issue since.

So the failure message a future author reads pointed them at something already closed — the corpus pattern's whole value is that the message tells you what to do, and it was telling them to look somewhere dead.

The change

Nine issue: tags, 674 to 726, plus the file header and the test's summary comment.

One reference to 674 is deliberately kept:

// This is the shape the fourth acceptance row on 674 named and the merged
// guard still admits.

That is a record of what the original issue asked for, not a pointer to act on. Retagging it would erase the provenance of the row.

Not a fix

The nine shapes still match. sirens-echo#726 carries the measured validHostLabel rule that closes them and the must-allow rows that constrain it. This PR only makes the tests name the live issue.

ward exec gate PASS on every step. Tests only.

Points nine failing rows at an issue that exists. ## The problem `hostlabelshape_test.go` reports nine open rows today: ``` 9 rows still disagree with intended behaviour ``` Every one carried `issue: "674"`. **sirens-echo#674 closed at 18:38 today**, when sirens-echo#680 merged and fixed three of the four shapes it named. The nine remaining shapes were measured after that and have been tracked on a closed issue since. So the failure message a future author reads pointed them at something already closed — the corpus pattern's whole value is that the message tells you what to do, and it was telling them to look somewhere dead. ## The change Nine `issue:` tags, `674` to `726`, plus the file header and the test's summary comment. One reference to 674 is deliberately kept: ```go // This is the shape the fourth acceptance row on 674 named and the merged // guard still admits. ``` That is a record of what the original issue asked for, not a pointer to act on. Retagging it would erase the provenance of the row. ## Not a fix The nine shapes still match. sirens-echo#726 carries the measured `validHostLabel` rule that closes them and the must-allow rows that constrain it. This PR only makes the tests name the live issue. `ward exec gate` PASS on every step. Tests only.

coilyco-ops added 1 commit

2026-08-13 20:58:06 +00:00

test(fetch): point the nine open label rows at the issue that is open

ci / image-build (pull_request) Successful in 24s

Details

ci / test (pull_request) Successful in 43s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

5e7b5623cc

sirens-echo#674 closed when sirens-echo#680 merged, which fixed three of
the four shapes it named. The nine rows these tests report still fail,
and every one of them cited the closed issue.

Retagged to sirens-echo#726. The one reference kept is the note recording
which shape 674 originally named, which is history rather than a pointer.

Refs sirens-echo#726

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 20:58:06 +00:00

coilyco-ops merged commit dc3c2a33f1 into main

2026-08-13 21:01:53 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 21:01:54 +00:00

Merge pull request 'test(fetch): point the nine open label rows at the issue that is open' (#728) from quail/retag-label-rows into main

coilyco-ops referenced this pull request

2026-08-13 21:15:04 +00:00

Nine invalid host-label shapes still match a wildcard allowlist entry, tracked only on closed 674 #726