test(proxy): point the reasoning_content pin at a live issue #721

Merged

coilyco-ops merged 1 commit from test/pin-points-at-a-live-issue into main

2026-08-13 20:41:25 +00:00

coilyco-ops commented

2026-08-13 20:39:06 +00:00

Member

internal/community/reasoningomitempty_test.go pins the half of 678 that never landed, and tells its reader:

t.Errorf("... If sirens-echo#678 was closed, invert this assertion and
          record what the provider accepts")

678 is now closed. The condition in that sentence is satisfied and the issue it names is gone, so the instruction points nowhere. The defect it pins is still live in chatRequest:

ReasoningContent string `json:"reasoning_content,omitempty"`

Filed as issue 717, which carries the one Ops action that decides the fix. This repoints the test at it.

Test-only, one string and one reference. No behaviour change.

Acceptance

The pin names an open issue.
Whoever inverts the assertion has somewhere to record what the provider accepted.

Next owner

Engineer. Closed by the pull request that lands the change.

ward exec gate PASS on all six steps.

closes #720

`internal/community/reasoningomitempty_test.go` pins the half of 678 that never landed, and tells its reader: ```go t.Errorf("... If sirens-echo#678 was closed, invert this assertion and record what the provider accepts") ``` **678 is now closed.** The condition in that sentence is satisfied and the issue it names is gone, so the instruction points nowhere. The defect it pins is still live in `chatRequest`: ```go ReasoningContent string `json:"reasoning_content,omitempty"` ``` Filed as [issue 717](https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/717), which carries the one Ops action that decides the fix. This repoints the test at it. Test-only, one string and one reference. No behaviour change. ## Acceptance - The pin names an open issue. - Whoever inverts the assertion has somewhere to record what the provider accepted. ## Next owner Engineer. Closed by the pull request that lands the change. `ward exec gate` PASS on all six steps. closes #720

coilyco-ops added 1 commit

2026-08-13 20:39:06 +00:00

test(proxy): point the reasoning_content pin at a live issue

ci / image-build (pull_request) Successful in 21s

Details

ci / test (pull_request) Successful in 43s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

82dece1013

The pin told its reader to invert the assertion if 678 was closed and record
what the provider accepts there. 678 is closed, so the instruction names an
issue that no longer takes the answer, while the defect it pins is unchanged.

717 carries the residual and the one Ops action that decides the fix.

closes #720

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 20:39:06 +00:00

coilyco-ops referenced this pull request

2026-08-13 20:39:31 +00:00

reasoning_content is preserved on one assistant message and dropped on the next, so DeepSeek rejects the eval turn outright #678

coilyco-ops merged commit 7f4060d702 into main

2026-08-13 20:41:25 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 20:41:28 +00:00

Merge pull request 'test(proxy): point the reasoning_content pin at a live issue' (#721) from test/pin-points-at-a-live-issue into main

coilyco-ops referenced this pull request

2026-08-13 21:08:09 +00:00