sirens-echo#703 keyed the guard on filepath.Base(definitionPath). That
solved the trap #702 named — deploy spells the path absolutely, the
tests relatively — but a filename is a spelling a foreign definition can
also be given.

Measured before changing anything: Deep's definition byte for byte in a
file named sirens-echo.yaml resolved to "sirens-echo" with no error.

The definition is already loaded when this runs, so the authoritative
answer was in hand and a proxy for it was being used. Comparing
Definition.Identity removes the proxy and keeps the property 703 was
protecting, structurally rather than by convention.

All six of 703's tests are preserved. Four now pass identities to the
helper, which is what it takes. The any-path test moved to LoadConfig,
because the helper no longer sees a path and that is where paths enter —
its assertion is unchanged.

Not reachable from any deployed manifest: sirens-deep-values.yaml names
/app/agent/sirens-deep.yaml and sets SIRENS_ECHO_INSTANCE. Latent, not
live.

Mutation: reverting the comparison fails the decoy row and two of 703's.

Refs sirens-echo#706, sirens-echo#702

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 20:11:44 +00:00

coilyco-ops merged commit 33c4f576bb into main

2026-08-13 20:13:24 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 20:13:25 +00:00

Merge pull request 'fix(config): the instance-name guard compares the identity, not the filename' (#707) from coilyco-ops/identity-not-filename into main

coilyco-ops referenced this pull request

2026-08-13 20:14:22 +00:00

The instance-name guard reads a filename, so a foreign definition named sirens-echo.yaml still becomes Echo #706

coilyco-ops referenced this pull request

2026-08-13 20:16:13 +00:00