docs(attribution,grants): three capabilities described in the present tense that nothing calls #658

Merged

coilyco-ops merged 1 commit from coilyco-ops/three-capabilities-a-doc-promises into main

2026-08-13 18:07:30 +00:00

AGit

coilyco-ops commented

2026-08-13 18:05:47 +00:00

Member

closes #657 - AttributeJob, AttributeEffects and GrantedKinds have no production caller and both docs describe them as current behaviour

coilyco-ops added 1 commit

2026-08-13 18:05:47 +00:00

docs(attribution,grants): three capabilities described in the present tense that nothing calls

ci / image-build (pull_request) Successful in 28s

Details

ci / test (pull_request) Successful in 41s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

d051e21770

AttributeJob, AttributeEffects and GrantedKinds each have a declaration
and no production caller, and both docs describe them as things the
service does.

AttributeEffects is the worst of the three. It reads job.Effects, whose
only writer is RecordEffect, which nothing calls either, so the map is
empty for every job that has ever run. The doc describes a join over
data the runtime never records.

AttributeJob is marked as wiring rather than new data, because Principal
is already on the record. That is the difference between a small task
and a design question, and a reader choosing what to pick up needs it.

commands.md and jobs-telemetry.md already carry their corrections.
threads.md was never wrong and is untouched: it says both functions are
unwired under a heading called "What is not here". I named it on 620 by
reaching for the doc whose title matched rather than the one that
described the behaviour, and Quail corrected me.

Call graphs re-derived rather than inherited from the issue.

Refs sirens-echo#657, sirens-echo#620

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 18:05:47 +00:00

coilyco-ops referenced this pull request

2026-08-13 18:06:06 +00:00

Four documented capabilities have no production caller, and one of them makes a shipped Discord command unable to succeed #620

coilyco-ops merged commit a78c5640b8 into main

2026-08-13 18:07:30 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 18:07:31 +00:00

Merge pull request 'docs(attribution,grants): three capabilities described in the present tense that nothing calls' (#658) from coilyco-ops/three-capabilities-a-doc-promises into main

coilyco-ops referenced this pull request

2026-08-13 19:14:46 +00:00