refactor: delete the two functions nothing references at all #622

Merged

coilyco-ops merged 1 commit from coilyco-ops/delete-what-nothing-references into main

2026-08-13 17:31:44 +00:00

AGit

coilyco-ops commented

2026-08-13 17:24:40 +00:00

Member

closes #618 - the classification is on the issue. Only two of the seventeen have no caller, no test, and no doc, which is the only evidence that settles a deletion by itself. The rest are carved into #620 and #621.

coilyco-ops added 1 commit

2026-08-13 17:24:40 +00:00

refactor: delete the two functions nothing references at all

ci / image-build (pull_request) Successful in 21s

Details

ci / test (pull_request) Successful in 37s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

4aae286c48

Classifying the seventeen callerless exported functions produced four groups,
and only one of them settles a deletion on evidence alone.

ExecutionAdmissionSummary and JobStates have no production caller, no test, and
no doc describing them. Nothing asked for either, nothing checks either, and
nothing would notice their absence. Both are removed, with the imports they
were the last user of.

The other classes are carved into their own issues rather than swept up here,
because a call count cannot distinguish an abandoned capability from unwired
groundwork and I am not deleting other seats' work on that basis.

Wrappers, harmless: AppendIssueReferences and ExpandRole each delegate to a
Within or WithExclusions sibling that production does call, the same shape as
AppendToolDisclosure. Left alone.

Documented but unwired, four of them, sirens-echo#620. These are a correctness
problem rather than a cleanup, because docs describe behaviour the runtime never
invokes. The sharpest is thread binding: two production readers of
Origin.ThreadID and no writer, so a live Discord command resolving a job from
its thread can never match.

Undocumented and unwired, four of them, sirens-echo#621. Nothing promises these,
so nothing is currently wrong. Deleting them is a judgement about intent.

The finding worth keeping from all of it: a green test suite is evidence a thing
works, not evidence anything uses it. Every one of these had passing tests.

closes #618

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 17:24:40 +00:00

coilyco-ops referenced this pull request

2026-08-13 17:25:02 +00:00

Seventeen exported functions have no production caller, and the interesting ones are not the obvious ones #618

coilyco-ops merged commit f8780062a5 into main

2026-08-13 17:31:44 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 17:31:44 +00:00

Merge pull request 'refactor: delete the two functions nothing references at all' (#622) from coilyco-ops/delete-what-nothing-references into main

coilyco-ops referenced this pull request

2026-08-13 17:47:40 +00:00