fix(main): green again, on a corpus that pinned the behaviour my own fix changed #564

Merged
coilyco-ops merged 1 commit from coilyco-ops/unredden-the-grounding-corpus into main 2026-08-13 15:58:49 +00:00 AGit
Member

main is red: PR 556 made the named self-claim guard catch the simple past, and a characterization corpus merged separately pins those two shapes as not rejected.

main is red: PR 556 made the named self-claim guard catch the simple past, and a characterization corpus merged separately pins those two shapes as not rejected.
fix(main): green again, on a corpus that pinned the behaviour my own fix changed
All checks were successful
ci / image-build (pull_request) Successful in 19s
ci / test (pull_request) Successful in 41s
ci / publish-echo-image (pull_request) Has been skipped
ci / publish-observed (pull_request) Has been skipped
43e9aa4df7
main is red, and this one is mine.

  --- FAIL: TestGroundingRejectsUngroundedActionClaims
      behavior changed on "Sirens Echo filed a correction.":
        rejected = true, was false
      behavior changed on "Sirens Echo opened an issue for this.":
        rejected = true, was false

Pull request 556 made ValidateSelfAttributedClaim's auxiliary optional, so the
named self-claim is caught in the simple past. A characterization corpus landed
separately pinning those same two shapes as not rejected. Both were green
against the base they were written on and neither ran against the other.

Third instance of this shape today, after the 486 characterization race and the
doc-cap accumulation. The corpus is well built and told me exactly what to do:
"If issue 241 was fixed, set rejectedNow to true and clear the issue field."

Flipped the two rows. They now assert the fix rather than the defect, which is
what a characterization entry is for once its behaviour lands.

Also repointed the four remaining rows from 241 to 555. Family 3, the was/were
passive, is measured to false-fire on ordinary prose and stays open there
rather than on an issue that closed on family 1. A corpus entry citing a closed
issue sends the next reader to a thread that says the work is done.

The service filed a correction. now cites 557, which is family 2.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-gaming/sirens-echo!564
No description provided.