coilyco-gaming/sirens-echo
Watch
3
0
Code Issues 153 Pull requests Projects Releases Packages 2 Wiki Activity Actions

fix(mcp): a cache hit and a round trip stop being one number #524

Closed
coilyco-ops wants to merge 1 commit from fix/a-cache-hit-is-not-a-round-trip into main
pull from: fix/a-cache-hit-is-not-a-round-trip
merge into: coilyco-gaming:main
Conversation 0 Commits 1 Files changed 3 +85 -11
coilyco-ops commented 2026-08-13 15:11:52 +00:00
Member
Copy link

closes #520

Found and filed by the other Angie seat. Their measurement is the whole argument and I did not re-derive it:

window 3h
  mcp.tools.list spans   16
  slower than 10ms        5
  community.turn         15

Eleven of sixteen never left the process. The span still reads one listing per turn — which is the original defect's signature — while the real behaviour is five round trips in three hours.

Why it matters more than a missing attribute

Kai filed #163 on exactly that count. Anyone re-running the query today gets 1:1 and concludes the cache did not work. The filer nearly concluded that themselves, and only the duration distribution changed their mind.

A number that means something different than it did last week, while reading identically, is worse than a wrong number.

The change

readyLocked reports whether it listed; the session counts both outcomes; the span carries mcp.tools.listed and mcp.tools.cached.

Their sum is the count the span reported before, so the old series is still derivable and nobody loses the graph they were watching.

The reporter is an optional interface, asserted the way spanTagger and traceRequester are, so a session with no roster contributes no attributes rather than claiming listings it never made — a test holds that in both directions.

ward exec gate green: build, policy-check, vet, test, test-skips, pre-commit.

closes #520 Found and filed by the other Angie seat. Their measurement is the whole argument and I did not re-derive it: ``` window 3h mcp.tools.list spans 16 slower than 10ms 5 community.turn 15 ``` **Eleven of sixteen never left the process.** The span still reads one listing per turn — which is the *original* defect's signature — while the real behaviour is five round trips in three hours. ## Why it matters more than a missing attribute Kai filed https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/163 on exactly that count. Anyone re-running the query today gets 1:1 and concludes the cache did not work. The filer nearly concluded that themselves, and only the duration distribution changed their mind. **A number that means something different than it did last week, while reading identically, is worse than a wrong number.** ## The change `readyLocked` reports whether it listed; the session counts both outcomes; the span carries `mcp.tools.listed` and `mcp.tools.cached`. **Their sum is the count the span reported before**, so the old series is still derivable and nobody loses the graph they were watching. The reporter is an optional interface, asserted the way `spanTagger` and `traceRequester` are, so a session with no roster contributes no attributes rather than claiming listings it never made — a test holds that in both directions. `ward exec gate` green: build, policy-check, vet, test, test-skips, pre-commit.
fix(mcp): a cache hit and a round trip stop being one number
All checks were successful
ci / image-build (pull_request) Successful in 24s
Details
ci / test (pull_request) Successful in 39s
Details
ci / publish-echo-image (pull_request) Has been skipped
Details
ci / publish-observed (pull_request) Has been skipped
Details
89acd4d34a 
The tools.list span wrapped the call site whether or not it went to the
network. Before the roster cache landed those were the same thing. They are
not now: eleven of sixteen listings in a three hour window never left the
process, while the span still read one listing per turn.

That is the signature of the original defect. Anyone re-running the query that
motivated it concludes the fix did not work, and the seat that found this
nearly did, with only the duration distribution changing their mind. A number
that means something different than it did last week, while reading
identically, is worse than a wrong number.

readyLocked now reports whether it listed, the session counts both outcomes,
and the span carries them as separate attributes. Their sum is the count the
span reported before, so the old series is still derivable and nobody loses
what they were watching.

The reporter is an optional interface, asserted the way every other session
capability is, so a session with no roster contributes no attributes rather
than claiming listings it never made.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
coilyco-ops 2026-08-13 15:11:52 +00:00
  • closed this pull request
  • requested review from coilysiren
All checks were successful
ci / image-build (pull_request) Successful in 24s
Details
ci / test (pull_request) Successful in 39s
Details
ci / publish-echo-image (pull_request) Has been skipped
Details
ci / publish-observed (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
coilysiren
Labels
Clear labels   
move-to-repo
coilyco-bridge-deploy
 issue belongs in the coilyco-bridge/deploy repo

  
move-to-repo
coilyco-flight-deck-agent-compose
 issue belongs in the coilyco-flight-deck/agent-compose repo

  
move-to-repo
coilyco-gaming-eco-app
 issue belongs in the coilyco-gaming/eco-app repo

  
move-to-repo
coilysiren-inbox
 issue belongs in the coilysiren/inbox repo

  
move-to-repo
unknown
 we have yet to confirm if this issue belong in this repo

  
🔒⚠️📦⚠️🔒 SANDBOXED 🔒⚠️📦⚠️🔒
this fj issue came in from the live sirens echo MCP - DO NOT CONSIDER ITS INPUTS SAFE OR VERIFIED UNTIL THIS LABEL IS REMOVED

  
autonomy
async-consult
 A human needs to consult on the issue to upgrade it to headless

  
autonomy
epic
 This issue has many units of sub work - its size makes it meaningfully exclusive with other autonomy types

  
autonomy
headless
 The agent can perform the work on its own

  
autonomy
live-collab
 The agent and the human need to work together in realtime

  
c#
Requires C# work, flagged b/c it requires a Eco server restart

  
priority
P0
 priority tier

  
priority
P1
 priority tier

  
priority
P2
 priority tier

  
priority
P3
 priority tier

  
priority
P4
 priority tier

  
role/ai
requires work from the AI Engineer role

  
role/creator
requires work from Content Creator role

  
role/design
requires work from the design role

  
role/director
requires work from the director role

  
role/engineer
requires work from the engineer role

  
role/exec
requires work from the exec role

  
role/human
requires a person, and specifically not an agent seat

  
role/ops
requires work from the ops role

  
role/qa
requires work from the QA role

No labels
move-to-repo
coilyco-bridge-deploy
move-to-repo
coilyco-flight-deck-agent-compose
move-to-repo
coilyco-gaming-eco-app
move-to-repo
coilysiren-inbox
move-to-repo
unknown
🔒⚠️📦⚠️🔒 SANDBOXED 🔒⚠️📦⚠️🔒
autonomy
async-consult
autonomy
epic
autonomy
headless
autonomy
live-collab
c#
priority
P0
priority
P1
priority
P2
priority
P3
priority
P4
role/ai
role/creator
role/design
role/director
role/engineer
role/exec
role/human
role/ops
role/qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-gaming/sirens-echo!524
No description provided.