test(mentions): one footer fixture, built rather than copied #511

Merged

coilyco-ops merged 1 commit from coilyco-ops/one-footer-fixture-not-two into main

2026-08-13 14:50:32 +00:00

AGit

coilyco-ops commented

2026-08-13 14:49:30 +00:00

Member

closes #510 - a literal copy of a rendered footer cannot notice the footer changing, and the helper-built case already asserts strictly more.

coilyco-ops added 1 commit

2026-08-13 14:49:30 +00:00

test(mentions): one footer fixture, built rather than copied

ci / image-build (pull_request) Successful in 18s

Details

ci / test (pull_request) Successful in 45s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

240e938644

Two tests asserted that a member named after a tool does not rewrite the
disclosure receipt. One built the fixture through AppendToolDisclosure. The
other wrote the rendered footer out as a string literal, hardcoding the glyph,
the status glyph, the quoting, the blank line, and the no-results suffix.

The literal is worse than redundant. If the footer's shape changes it keeps
passing while asserting a receipt the service no longer produces, so it would
be green and measuring nothing. That is not hypothetical: the disclosure
vocabulary changed today in 447, and tooldisclosure.go defines its glyphs as
references to the reaction constants precisely so the two surfaces cannot
drift. Copying the rendered result into a test opts out of that guarantee.

Removed the literal. The helper-built case asserts strictly more: the reply is
unchanged, both tool names survive, and nothing is pinged.

Same call the repository already made in "compare a case by marshalling it,
not by listing its fields".

The observation is the other ENG seat's, from the body of sirens-echo#505.

closes #510

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 14:49:30 +00:00

coilyco-ops referenced this pull request

2026-08-13 14:49:49 +00:00

Two tests assert the same footer, and the one written as a literal cannot notice the footer changing #510

coilyco-ops merged commit c1ca0eed65 into main

2026-08-13 14:50:32 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 14:50:33 +00:00

Merge pull request 'test(mentions): one footer fixture, built rather than copied' (#511) from coilyco-ops/one-footer-fixture-not-two into main