coilyco-gaming/sirens-echo

Watch

test(mentions): the code-span pins assert the fixed behaviour #507

Closed

coilyco-ops wants to merge 2 commits from eng/main-is-green-again into main

coilyco-ops commented

2026-08-13 14:43:16 +00:00

Member

Stacked on #503, which must merge first. This branch is cut from that one, not from main, because neither red can be validated alone: with the doc cap broken, the pre-commit hook refuses the commit for this fix, on a file it does not touch. The lane's stacked detection should defer this until 503 lands.

What was red

--- FAIL: TestAToolNamedMemberRewritesTheFooter
--- FAIL: TestANameInsideACodeSpanIsRewritten

Run against origin/main at 24f9aa3, not inferred from the diff.

Both are characterization tests from #495, written while the code-span collision was live and explicitly asking to be removed once it was fixed. #496 fixed it and merged first, so they landed already-failing. Neither pull request was wrong; the merge order decided it.

Replaced, not deleted

#495 carries a better idea than the one #496 shipped. footerWithToolNames() builds the receipt through the real AppendToolDisclosure instead of a string literal, so the assertion cannot drift from the actual footer format. The positive test now uses Quail's helper, and the hand-written literal I put in mentionurl_test.go is gone.

TestANameInProseStillResolvesBesideCode covers bold and quoted prose, which my tests did not. Untouched, still passing.

Net coverage against #486 is higher than before this change, not lower.

The pattern, twice in ten minutes

Two greens summing to a red is now the second instance today, after #500. Both times the branch was measured and the merge was what shipped. Noted on both issues for someone whose surface the lane is.

closes #505

**Stacked on #503, which must merge first.** This branch is cut from that one, not from `main`, because neither red can be validated alone: with the doc cap broken, the pre-commit hook refuses the commit for this fix, on a file it does not touch. The lane's stacked detection should defer this until 503 lands. ## What was red ``` --- FAIL: TestAToolNamedMemberRewritesTheFooter --- FAIL: TestANameInsideACodeSpanIsRewritten ``` Run against `origin/main` at `24f9aa3`, not inferred from the diff. Both are characterization tests from #495, written while the code-span collision was live and explicitly asking to be removed once it was fixed. #496 fixed it and merged first, so they landed already-failing. Neither pull request was wrong; the merge order decided it. ## Replaced, not deleted #495 carries a better idea than the one #496 shipped. `footerWithToolNames()` builds the receipt through the real `AppendToolDisclosure` instead of a string literal, so the assertion cannot drift from the actual footer format. The positive test now uses Quail's helper, and the hand-written literal I put in `mentionurl_test.go` is gone. `TestANameInProseStillResolvesBesideCode` covers bold and quoted prose, which my tests did not. Untouched, still passing. Net coverage against #486 is higher than before this change, not lower. ## The pattern, twice in ten minutes Two greens summing to a red is now the second instance today, after #500. Both times the branch was measured and the merge was what shipped. Noted on both issues for someone whose surface the lane is. closes #505

coilyco-ops added 2 commits

2026-08-13 14:43:16 +00:00

docs(mentions): split where a name is read into its own doc

ci / image-build (pull_request) Successful in 20s

Details

ci / test (pull_request) Failing after 27s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

917bc9d06d

main was red: two changes to this doc each passed the gate against their
own base and the merge summed them to 84 lines against an 80-line cap, so
every branch cut from main failed on a file its author never touched.

Where a name is read is now its own subject. The mentions doc keeps the
roster, the never-parse rule and the bounds on who gets reached; the scope
doc holds the prose-only rule, the dotted-identifier rule, and why the
non-prose runs are the enumerated ones rather than the other way around.

closes #500

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

test(mentions): the code-span pins assert the fixed behaviour

ci / image-build (pull_request) Successful in 18s

Details

ci / test (pull_request) Successful in 32s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

0b071b64f3

Two characterization tests from 495 landed after 496 fixed the defect
they pinned, so main was red on tests. Both pull requests were green
against their own bases and the merge order decided the outcome.

Replaced rather than deleted. 495 built the receipt through the real
AppendToolDisclosure instead of a string literal, which is better than
what 496 carried, so the positive assertion takes that helper and the
literal in mentionurl_test.go goes. The prose test covering bold and
quoted names is untouched and still passes.

closes #505

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops

2026-08-13 14:43:16 +00:00

closed this pull request
requested review from coilysiren

ci / image-build (pull_request) Successful in 18s

Details

ci / test (pull_request) Successful in 32s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-gaming/sirens-echo!507

No description provided.

Rows
Columns