fix(progress): the line answers the member, like the reply does #394

Merged

coilysiren merged 3 commits from fix/the-progress-line-is-a-reply-too into main

2026-08-13 12:22:54 +00:00

coilyco-ops commented

2026-08-13 11:46:28 +00:00

Member

closes #393

Part of #376. Kai wrote "unsure how that's even happening" — it has a one-line answer.

The cause

discordTurnProgress.Post sent with no Reference. discordMessageTurn.Reply sets Reference: t.message.SoftReference(). Two halves of one exchange, posted two different ways.

The sink held a channel id and never held the message, so it had nothing to reference even if it had wanted to. It carries the message now.

Two details

RepliedUser: false, matching the reply path. A line that answered a member and pinged them would be a new annoyance introduced by a fix for a cosmetic one.

A sink with no message still posts, without a reference. Losing the progress line entirely would be worse than losing the reference, so the absence degrades rather than fails.

Not in this PR

#375, the buffer length, carries a live claim from another Angie seat.

ward exec gate green: build, policy-check, vet, test, test-skips, pre-commit.

closes #393 Part of https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/376. Kai wrote *"unsure how that's even happening"* — it has a one-line answer. ## The cause `discordTurnProgress.Post` sent with **no `Reference`**. `discordMessageTurn.Reply` sets `Reference: t.message.SoftReference()`. Two halves of one exchange, posted two different ways. The sink held a channel id and never held the message, so it had nothing to reference even if it had wanted to. It carries the message now. ## Two details `RepliedUser: false`, matching the reply path. A line that answered a member **and pinged them** would be a new annoyance introduced by a fix for a cosmetic one. A sink with no message still posts, without a reference. Losing the progress line entirely would be worse than losing the reference, so the absence degrades rather than fails. ## Not in this PR https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/375, the buffer length, carries a live claim from another Angie seat. `ward exec gate` green: build, policy-check, vet, test, test-skips, pre-commit.

coilyco-ops added 1 commit

2026-08-13 11:46:28 +00:00

fix(progress): the line answers the member, like the reply does

ci / test (pull_request) Successful in 30s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ci / image-build (pull_request) Successful in 20s

Details

645a081ab6

The progress line posted as a bare channel message while the reply that
replaces it posted as a reply. One exchange, two shapes.

The cause is that the sink held a channel id and never held the message, so it
had nothing to reference even if it had wanted to. It carries the message now.

RepliedUser stays false, matching the reply path. A line that answered a member
and also pinged them would be a new annoyance introduced by a fix for a
cosmetic one.

A sink with no message still posts, without a reference. Losing the line
entirely would be worse than losing the reference, so the absence degrades
rather than fails.

closes #393

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 11:46:28 +00:00

coilyco-ops referenced this pull request

2026-08-13 11:46:52 +00:00

the thinking message doesn't generate as a reply, but the final message does #376

coilyco-ops added 1 commit

2026-08-13 11:51:16 +00:00

Merge branch 'main' into fix/the-progress-line-is-a-reply-too

ci / test (pull_request) Successful in 41s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details