fix(grounding): make the two lookup verbs able to match, and the next one too #350

Merged

coilyco-ops merged 1 commit from fix/look-up-verbs-cannot-match into main

2026-08-13 10:45:55 +00:00

coilyco-ops commented

2026-08-13 10:44:28 +00:00

Member

closes #344

look\s+up and looking\s+up were written with a doubled backslash inside a raw string literal, so the expression asked for the word, then a literal backslash, then one or more letter-s, then up. No reply contains that. Three of the five verbs that commit added worked; two were decoration.

Both copies change together — the pattern is duplicated verbatim into agent/evaluation.yaml and a pin fails when they drift. That pin is why this is a one-line fix instead of a red main, exactly as the filer said.

The one-character change is not the interesting part

A dead alternative in a list of live ones reads as coverage that is not there, and nothing in the suite could tell the difference. The same edit would produce the same defect the next time somebody adds a multi-word verb.

So the test derives its cases from the live pattern: it lifts the trailing alternation out, builds a reply for each alternative, and asserts every one can match. A verb added with a bad escape now fails on the verb it was added for, by name.

Verified against the original defect

Reverted the pattern, ran the new tests, confirmed they fail — and on which verbs:

--- FAIL: TestEveryContinuingWorkVerbCanActuallyMatch/looking\\s+up
    the verb "looking\\s+up" is in the pattern and cannot match
--- FAIL: TestEveryContinuingWorkVerbCanActuallyMatch/look\\s+up
--- FAIL: TestTheLookupPhrasingsAreCaught
--- FAIL: TestThePatternCarriesNoLiteralBackslash

Then restored the fix and confirmed they pass. A test that has never been seen to fail is not evidence.

The must-not-fire side

Checked in the same commit, because widening this pattern is where it has produced false positives before. A member being told they can look up an issue, and a refusal to look one up, both stay clean.

ward exec gate green: build, policy-check, vet, test, test-skips, pre-commit.

closes #344 `look\s+up` and `looking\s+up` were written with a **doubled** backslash inside a raw string literal, so the expression asked for the word, then a literal backslash, then one or more letter-`s`, then `up`. No reply contains that. Three of the five verbs that commit added worked; two were decoration. Both copies change together — the pattern is duplicated verbatim into `agent/evaluation.yaml` and a pin fails when they drift. That pin is why this is a one-line fix instead of a red main, exactly as the filer said. ## The one-character change is not the interesting part A dead alternative in a list of live ones reads as coverage that is not there, and **nothing in the suite could tell the difference**. The same edit would produce the same defect the next time somebody adds a multi-word verb. So the test derives its cases from the live pattern: it lifts the trailing alternation out, builds a reply for each alternative, and asserts every one can match. A verb added with a bad escape now fails on the verb it was added for, **by name**. ## Verified against the original defect Reverted the pattern, ran the new tests, confirmed they fail — and on which verbs: ``` --- FAIL: TestEveryContinuingWorkVerbCanActuallyMatch/looking\\s+up the verb "looking\\s+up" is in the pattern and cannot match --- FAIL: TestEveryContinuingWorkVerbCanActuallyMatch/look\\s+up --- FAIL: TestTheLookupPhrasingsAreCaught --- FAIL: TestThePatternCarriesNoLiteralBackslash ``` Then restored the fix and confirmed they pass. A test that has never been seen to fail is not evidence. ## The must-not-fire side Checked in the same commit, because widening this pattern is where it has produced false positives before. A member being told they *can* look up an issue, and a refusal to look one up, both stay clean. `ward exec gate` green: build, policy-check, vet, test, test-skips, pre-commit.

coilyco-ops added 1 commit

2026-08-13 10:44:28 +00:00

fix(grounding): make the two lookup verbs able to match, and the next one too

ci / test (pull_request) Successful in 29s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ci / image-build (pull_request) Successful in 19s

Details

981bc39a3d

look and looking were spelled with a doubled backslash inside a raw string
literal, so the expression asked for the word, then a literal backslash, then
one or more letter-s, then up. No reply contains that. Three of the five verbs
that commit added worked and two were decoration.

Both copies change together, because the pattern is duplicated verbatim into
agent/evaluation.yaml and a pin fails when they drift. The pin is the reason
this was a one-line fix rather than a red main.

The one-character change is not the interesting part. A dead alternative in a
list of live ones reads as coverage that is not there, and nothing in the
suite could see the difference, so the same edit would produce the same defect
next time somebody adds a multi-word verb.

So the test derives its cases from the live pattern: it lifts the trailing
alternation out, builds a reply for each alternative, and asserts every one of
them can actually match. A verb added with a bad escape now fails on the verb
it was added for, by name. Verified against the original defect: it fails on
both dead verbs and passes on the fix.

The must-not-fire side is checked in the same commit, because widening this
pattern is where it has produced false positives before. A member being told
they can look up an issue, and a refusal to look one up, both stay clean.

closes #344

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 10:44:28 +00:00

coilyco-ops referenced this pull request

2026-08-13 10:44:53 +00:00

Two of the five verbs a7c503a added to the continuing-work check cannot match anything #344

coilyco-ops merged commit 831c4384f8 into main

2026-08-13 10:45:55 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 10:45:56 +00:00

Merge pull request 'fix(grounding): make the two lookup verbs able to match, and the next one too' (#350) from fix/look-up-verbs-cannot-match into main