test(gate): one pack-coverage guard, not two #321

Merged

coilysiren merged 1 commit from test/consolidate-pack-coverage into main

2026-08-13 09:30:01 +00:00

coilyco-ops commented

2026-08-13 09:22:47 +00:00

Member

75b8db0 (mine) and 9bd5970 (Angie's) landed the same check within an hour, from two agents who each found the defect independently. Both assert that every agent/*.yaml is named in policy-check's hand-written list.

This keeps one.

Which one, and why

pack_coverage_test.go is the superset — it also holds the reverse direction, a path listed in main.go that is no longer on disk. coverage_test.go covered only the forward direction, so deleting it loses nothing.

Taking the better failure message from the file being removed. Angie's says what to do; mine only said where to look:

agent/decoy-pack.yaml is verified by nothing. Add it to the right verify
call in main.go, or delete it if it is no longer tracked.

Both directions re-verified after the merge

a new pack nobody listed     named, with the instruction above
a listed pack that is gone   named, with the stat error

Net one file and one test fewer for identical coverage.

Why this happened, since it is the third time today

Two agents independently found the same defect and each shipped a guard. That is the duplicated-work cost measured on #307 showing up as code rather than as a wasted diagnosis, and it is the better failure of the two — we ended with two correct tests rather than none.

Worth noting the pairing Angie drew on #291 is genuinely good and survives here: a skip stops running a check that exists, an unlisted pack never gets one at all, and both print success. The consolidated test covers the second half; ward exec test-skips covers the first.

75b8db0 (mine) and 9bd5970 (Angie's) landed **the same check within an hour**, from two agents who each found the defect independently. Both assert that every `agent/*.yaml` is named in policy-check's hand-written list. This keeps one. ## Which one, and why `pack_coverage_test.go` is the superset — it also holds the reverse direction, a path listed in `main.go` that is no longer on disk. `coverage_test.go` covered only the forward direction, so deleting it loses nothing. **Taking the better failure message from the file being removed.** Angie's says what to do; mine only said where to look: ``` agent/decoy-pack.yaml is verified by nothing. Add it to the right verify call in main.go, or delete it if it is no longer tracked. ``` ## Both directions re-verified after the merge ``` a new pack nobody listed named, with the instruction above a listed pack that is gone named, with the stat error ``` Net one file and one test fewer for identical coverage. ## Why this happened, since it is the third time today Two agents independently found the same defect and each shipped a guard. That is the duplicated-work cost measured on https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/307 showing up as code rather than as a wasted diagnosis, and it is the better failure of the two — we ended with two correct tests rather than none. Worth noting the pairing Angie drew on https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/291 is genuinely good and survives here: a skip stops running a check that exists, an unlisted pack never gets one at all, and both print success. The consolidated test covers the second half; `ward exec test-skips` covers the first.

coilyco-ops added 1 commit

2026-08-13 09:22:47 +00:00

test(gate): one pack-coverage guard, not two

ci / test (pull_request) Successful in 32s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ci / image-build (pull_request) Successful in 23s

Details

3865b7ecfb

75b8db0 and 9bd5970 landed the same check within an hour of each other,
from two agents who each found the defect independently. Both assert that
every agent/*.yaml is named in policy-check's hand-written list.

Keeping the superset and deleting the duplicate. pack_coverage_test.go
also holds the reverse direction, a listed path that is no longer on
disk, which coverage_test.go did not.

Taking the better failure message from the file being removed. "Verified
by nothing, add it to the right verify call or delete it" says what to do;
mine only said where to look.

Both directions re-verified after the merge:

  a new pack nobody listed    named, with the instruction
  a listed pack that is gone  named, with the stat error

Net one file and one test fewer for the same coverage.

Refs #291

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 09:22:47 +00:00

coilyco-ops referenced this pull request

2026-08-13 09:23:14 +00:00

A skipped test reports ok, and two security guards were silently unguarded because of it #291