docs(agents): declare the pull-request lane this repo actually runs #1163

Merged
coilyco-ops merged 2 commits from agent/994-declare-pull-request-lane into main 2026-08-27 05:14:03 +00:00
Owner

Refs agentic-os#994. Frontmatter said pull-request-and-merge while the prose said the merge stays director-gated. Kai settled it: this repo gates the merge, so the lane is pull-request.

  • Frontmatter declares workflow: pull-request.
  • The hand-written stamp is replaced by the managed block, rendered from the declared lane, so the prose cannot drift from it again.
  • The old stamp claimed to be byte-identical across five repos, which it was not.
  • The repo-local note that Ward honors the lane only after ward#1661 is kept beside the block.

pre-commit run --all-files passes. Left for you to merge, since this lane is the reason the branch stops here.

Refs agentic-os#994. Frontmatter said `pull-request-and-merge` while the prose said the merge stays director-gated. Kai settled it: this repo gates the merge, so the lane is `pull-request`. - Frontmatter declares `workflow: pull-request`. - The hand-written stamp is replaced by the managed block, rendered from the declared lane, so the prose cannot drift from it again. - The old stamp claimed to be byte-identical across five repos, which it was not. - The repo-local note that Ward honors the lane only after ward#1661 is kept beside the block. `pre-commit run --all-files` passes. Left for you to merge, since this lane is the reason the branch stops here.
docs(agents): declare the pull-request lane this repo actually runs
Some checks failed
ci / image-build (pull_request) Successful in 53s
ci / test (pull_request) Failing after 1m6s
ci / publish-echo-image (pull_request) Has been skipped
ci / publish-observed (pull_request) Has been skipped
83385a6d8e
Refs agentic-os#994. The frontmatter said `pull-request-and-merge` while
the prose said the merge stays director-gated, and the two lanes mean
opposite things about who merges. Kai settled it: this repo gates the
merge, which is what `pull-request` names.

The hand-written stamp is replaced by the managed block, rendered from
the declared lane, so the prose can no longer drift from it. The stamp
also claimed to be byte-identical across five repos, which it was not.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Agent-Role: platform
fix(gate): refuse main on every review lane, not one of them
All checks were successful
ci / image-build (pull_request) Successful in 1m4s
ci / test (pull_request) Successful in 1m26s
ci / publish-echo-image (pull_request) Has been skipped
ci / publish-observed (pull_request) Has been skipped
23680e5718
Declaring `pull-request` switched the main-push guard off. The gate keyed its
refusal on the literal `pull-request-and-merge`, so renaming the lane made the
condition false and main became pushable with every check green. That is the
exact failure sirens-echo#329 built the guard to prevent, reintroduced by the
declaration this branch changes.

`TestTheGateReadsTheDeclaredWorkflow` did not catch it because it keyed on the
same literal and skipped instead, which is what CI's unreviewed-skip guard was
reporting.

The gate now enumerates the lanes that land through review, and both tests
follow. `TestTheLaneGateRefusesAGateRunFromMain` covers all three rather than
one, and the negative control gains a genuinely undeclared fixture, since the
old one declared `push-to-main` while claiming to declare nothing.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Agent-Role: platform
coilyco-ops deleted branch agent/994-declare-pull-request-lane 2026-08-27 05:14:04 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-gaming/sirens-echo!1163
No description provided.