The coalescing lane's mark paths have no substitution point, so none of them can be tested #1122

New issue

Closed

opened 2026-08-23 00:19:22 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-23 00:19:22 +00:00

Member

Split out of #988, whose first item is the structural one and whose other two need a proxy or a live guild.

The gap

internal/community/coalescing.go reaches Discord through discordMessageTurn.React and Unreact, which call *discordgo.Session methods directly. There is no interface to substitute, so discordAck.Queued, discordAck.Shed, clearArrivalMark, settle, and batchShelf.Shelve cannot be reached by a test without a network.

What is smaller than it looks

Most of the interfaces already exist. a.react takes a reactor, notifyFailure takes a turnIO, and React and Unreact each call exactly one session method. So the messageReader comparison in #988 holds, and the missing piece is a two-method interface plus two signatures that named the concrete turn where an interface would do.

Acceptance

A two-method messageMarker over MessageReactionAdd and MessageReactionRemove, nil taking the session, so nothing production sets it.
clearArrivalMark and recoverTurn take the interfaces they already only need.
The tests #988 names for the mark and hold paths become ordinary tests.

Not this issue

The reply path. Reply goes through send, which does threading, mentions, and files, so its seam is a larger piece and the panic test #988 lists needs it. The rate measurement and the six live observations stay on #988 too.

Refs #988

Split out of #988, whose first item is the structural one and whose other two need a proxy or a live guild. ## The gap `internal/community/coalescing.go` reaches Discord through `discordMessageTurn.React` and `Unreact`, which call `*discordgo.Session` methods directly. There is no interface to substitute, so `discordAck.Queued`, `discordAck.Shed`, `clearArrivalMark`, `settle`, and `batchShelf.Shelve` cannot be reached by a test without a network. ## What is smaller than it looks **Most of the interfaces already exist.** `a.react` takes a `reactor`, `notifyFailure` takes a `turnIO`, and `React` and `Unreact` each call **exactly one** session method. So the `messageReader` comparison in #988 holds, and the missing piece is a two-method interface plus two signatures that named the concrete turn where an interface would do. ## Acceptance * A two-method `messageMarker` over `MessageReactionAdd` and `MessageReactionRemove`, nil taking the session, so nothing production sets it. * `clearArrivalMark` and `recoverTurn` take the interfaces they already only need. * The tests #988 names for the mark and hold paths become ordinary tests. ## Not this issue The reply path. `Reply` goes through `send`, which does threading, mentions, and files, so its seam is a larger piece and the panic test #988 lists needs it. The rate measurement and the six live observations stay on #988 too. Refs #988

coilyco-ops referenced this issue from a pull request that will close it,

2026-08-23 00:19:36 +00:00

test(coalesce): a seam over the marks, so the Discord half is reachable #1123

coilyco-ops closed this issue

2026-08-23 00:21:27 +00:00

coilyco-ops referenced this issue

2026-08-23 00:22:14 +00:00

Testing the coalescing lane owes: a seam for the Discord adapter, one measured rate, and six live observations #988

coilyco-ops referenced this issue

2026-08-23 00:28:07 +00:00

test(coalesce): a panicking batch settles its holds and tells the member #1124

coilyco-ops referenced this issue from a commit