Stop chasing stale Unity/NuGet tests in factory-game CI #10

New issue

Closed

opened 2026-07-09 18:09:07 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-09 18:09:07 +00:00

Member

Current state:

#7/#8/#9 tried to make CI green by bounding or replacing the old dotnet test tests.csproj path.
Main is still red. Latest workflow run 7 failed on commit 0b288f1a33697d00043eb48176c6a2b5ac4cfcf2.
Current scripts/test-gate.sh runs pre-commit run --all-files with a timeout, and CI calls that script directly.
The important product decision is: do not spend more work fixing stale NuGet/Unity tests for this repo.

Requested implementation:

Make factory-game main CI green by removing or bypassing the stale Unity/NuGet test surface entirely.
Keep a truthful lightweight gate for the migration baseline, such as syntax/config/docs/LFS/pre-commit checks that can pass today. If pre-commit is the chosen gate, fix its current failures rather than reintroducing dotnet/NuGet.
Remove misleading docs that describe tests.csproj as the active validation target, or mark it explicitly as stale/reference-only.
Keep LFS setup from #4/#6 and aos baseline from #5 intact.
Do not try to repair dotnet test tests.csproj as part of this issue.

Acceptance:

A fresh push to main has green CI.
README, AGENTS, docs/FEATURES, .ward/ward.yaml, and scripts/test-gate.sh all agree that the active gate is the lightweight migration-baseline gate, not the old NuGet tests.
tests.csproj is either removed from the active path or clearly documented as stale/reference-only.

Kai clarified that trying to green the old NuGet/Unity test surface is a fool's errand. The repo is in Unity-to-Rust/Bevy transition, and the old C# NuGet tests are not a valid target to fix right now. Current state: * #7/#8/#9 tried to make CI green by bounding or replacing the old `dotnet test tests.csproj` path. * Main is still red. Latest workflow run 7 failed on commit `0b288f1a33697d00043eb48176c6a2b5ac4cfcf2`. * Current `scripts/test-gate.sh` runs `pre-commit run --all-files` with a timeout, and CI calls that script directly. * The important product decision is: do not spend more work fixing stale NuGet/Unity tests for this repo. Requested implementation: * Make factory-game main CI green by removing or bypassing the stale Unity/NuGet test surface entirely. * Keep a truthful lightweight gate for the migration baseline, such as syntax/config/docs/LFS/pre-commit checks that can pass today. If pre-commit is the chosen gate, fix its current failures rather than reintroducing dotnet/NuGet. * Remove misleading docs that describe `tests.csproj` as the active validation target, or mark it explicitly as stale/reference-only. * Keep LFS setup from #4/#6 and aos baseline from #5 intact. * Do not try to repair `dotnet test tests.csproj` as part of this issue. Acceptance: * A fresh push to main has green CI. * README, AGENTS, docs/FEATURES, `.ward/ward.yaml`, and `scripts/test-gate.sh` all agree that the active gate is the lightweight migration-baseline gate, not the old NuGet tests. * `tests.csproj` is either removed from the active path or clearly documented as stale/reference-only.

coilyco-ops commented

2026-07-09 18:09:31 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-factory-game-v3-10 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T18:09:28Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-gaming/factory-game-v3#10 · branch issue-10 · harness codex · workflow direct-to-main
Run: engineer-codex-factory-game-v3-10 · ward v0.493.0 · dispatched 2026-07-09T18:09:28Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-factory-game-v3-10` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T18:09:28Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-gaming/factory-game-v3#10` · branch `issue-10` · harness `codex` · workflow `direct-to-main` - **Run:** `engineer-codex-factory-game-v3-10` · ward `v0.493.0` · dispatched `2026-07-09T18:09:28Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from a commit

2026-07-09 18:12:51 +00:00

fix(ci): make migration baseline the active gate

coilyco-ops closed this issue

2026-07-09 18:13:14 +00:00

coilyco-ops commented

2026-07-09 18:13:33 +00:00

Author

Member

WARD-OUTCOME: done ✅

details

workflow: direct-to-main; review summary: review gate skipped by ~/.ward/config.yaml default
felt: straightforward cleanup, no product code changes
confidence: high
surprises: ward needed a tracked upstream before running the repo verb; .ward-run-provenance.json needed a gitignore entry
follow-ups: none

WARD-OUTCOME: done ✅ <details><summary>details</summary> workflow: direct-to-main; review summary: review gate skipped by ~/.ward/config.yaml default felt: straightforward cleanup, no product code changes confidence: high surprises: ward needed a tracked upstream before running the repo verb; .ward-run-provenance.json needed a gitignore entry follow-ups: none </details>