fix(social): newArrivals says when it truncates #273

Merged

coilysiren merged 1 commit from coilyco-ops/arrivals-says-when-it-truncates into main

2026-08-13 22:54:08 +00:00

AGit

coilyco-ops commented

2026-08-13 21:55:28 +00:00

Member

closes #286 - the only silent truncation in the suite: 60 rows returned, 124 present, warnings empty

One of five pull requests against #286. Slice of #267, which stays open.

closes #286 - the only silent truncation in the suite: 60 rows returned, 124 present, warnings empty One of five pull requests against #286. Slice of #267, which stays open.

coilyco-ops added 1 commit

2026-08-13 21:55:28 +00:00

fix(social): newArrivals says when it truncates 8f15756ee0

get_social returned totalFirstLogins: 124 with 60 rows in newArrivals and
an empty warnings list. #267 records it as the only silent truncation
across all 25 tools, and a silent cap is worse than an unbounded array: a
caller reading the 60 has no way to know 124 exist.

The cap itself is unchanged. MAX_NEW_ARRIVALS stays where it is and stays
configurable through ECO_SOCIAL_ARRIVALS. Choosing a different number is a
decision; saying which number was applied is not.

Wording follows the reference the issue names, the shown-of-total warnings
get_civics already emits, and points at totalFirstLogins as the field that
still covers every row.

An untruncated list stays quiet. A warning on every call would make the
honest case indistinguishable from the capped one, which is the same
confusion in the other direction, so both paths have a test.

Mutation: silencing the warning fails the truncating test and nothing else.

Slice of #267, which stays open. reputationEdges is still unbounded, the
four tools with no limit parameter are untouched, and the 25-tool audit
plus generic invariant test its acceptance asks for is not this.

Refs #267

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 21:55:28 +00:00

coilyco-ops referenced this pull request

2026-08-13 21:55:50 +00:00

Invariant: limit must bound every unbounded array, and truncation must always warn — sweep all 25 MCP tools #267

coilyco-ops referenced this pull request

2026-08-13 22:09:05 +00:00

Invariant: limit must bound every unbounded array, and truncation must always warn — sweep all 25 MCP tools #267

coilyco-ops referenced this pull request

2026-08-13 22:12:51 +00:00

Invariant: limit must bound every unbounded array, and truncation must always warn — sweep all 25 MCP tools #267

coilyco-ops referenced this pull request