Design a real required CI path for C# / NuGet checks #111

New issue

Open

opened 2026-07-09 18:14:04 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-07-09 18:14:04 +00:00

Member

Deferred follow-up. Kai does want the C# / NuGet checks brought into the normal required-CI fold eventually, but not as part of today's CI-green cleanup.

Context:

Today's decision is to stop treating the current never-green C# / NuGet checks as required CI. See eco-app#110 and factory-game-v3#10.
The current eco-app mods job has historically failed or hung, then was made fail-fast, but it still is not a trustworthy required signal.
The factory-game Unity/NuGet test surface is also stale during the Rust/Bevy migration, so fixing it today is the wrong work.
This issue is the follow-up for doing that properly later, not abandoning the checks permanently.

Requested design/implementation when picked up:

Define what C# / NuGet validation should prove for each repo or package family.
Make the checks reproducible in dev-base or a dedicated pinned CI image.
Avoid indefinite restore hangs; use clear restore/build/test phases, bounded timeouts, and actionable logs.
Decide whether shared NuGet caching/proxying is needed before making the checks required.
For eco-app, determine whether the C# mods gate should be a required job, a manual diagnostic first, or split per mod.
For factory-game-v3, revisit only after the Rust/Bevy migration plan clarifies whether the old Unity C# tests remain useful.
Once the path is reliable, wire it into required CI and update docs to say it is required.

Acceptance:

A documented required-CI design exists for the C# / NuGet checks.
The implementation is green repeatedly before being marked required.
The checks are bounded and diagnosable, not a long-running silent restore sink.

Deferred follow-up. Kai does want the C# / NuGet checks brought into the normal required-CI fold eventually, but not as part of today's CI-green cleanup. Context: * Today's decision is to stop treating the current never-green C# / NuGet checks as required CI. See eco-app#110 and factory-game-v3#10. * The current eco-app `mods` job has historically failed or hung, then was made fail-fast, but it still is not a trustworthy required signal. * The factory-game Unity/NuGet test surface is also stale during the Rust/Bevy migration, so fixing it today is the wrong work. * This issue is the follow-up for doing that properly later, not abandoning the checks permanently. Requested design/implementation when picked up: * Define what C# / NuGet validation should prove for each repo or package family. * Make the checks reproducible in dev-base or a dedicated pinned CI image. * Avoid indefinite restore hangs; use clear restore/build/test phases, bounded timeouts, and actionable logs. * Decide whether shared NuGet caching/proxying is needed before making the checks required. * For eco-app, determine whether the C# mods gate should be a required job, a manual diagnostic first, or split per mod. * For factory-game-v3, revisit only after the Rust/Bevy migration plan clarifies whether the old Unity C# tests remain useful. * Once the path is reliable, wire it into required CI and update docs to say it is required. Acceptance: * A documented required-CI design exists for the C# / NuGet checks. * The implementation is green repeatedly before being marked required. * The checks are bounded and diagnosable, not a long-running silent restore sink.

coilyco-ops added the

consult

labels

2026-07-10 09:00:46 +00:00