coilyco-flight-deck/ward
Watch
2
0
Code Issues 14 Pull requests Projects Releases 818 Packages 1 Wiki Activity Actions

Update engineer QA skip wording #1578

Merged
coilysiren merged 1 commit from issue-1577 into main 2026-07-28 03:07:18 +00:00
Conversation 1 Commits 1 Files changed 3 +30 -11
coilyco-ops commented 2026-07-28 02:56:17 +00:00
Member
Copy link

Update engineer QA skip wording

Ward now describes the in-container review gate as role-separated from QA instead of framing it as pending brokered QA. The engineer seed and headless outcome text now say QA is a separate, opt-in exact-commit verification role bound to the candidate commit, and the PR-and-merge skipped path is covered too.

  • Replaced the stale temporary skip reason in cmd/ward/agent.go.
  • Updated prompt tests to pin the new wording in engineer, pull-request, and pull-request-and-merge flows.
  • Verified ward exec vet, ward exec lint, and pre-commit run --all-files pass.
  • ward exec test is currently blocked by an unrelated TestBuildUpPlanTailnet failure in cmd/ward/container_hostnet_test.go.

closes #1577

Update engineer QA skip wording Ward now describes the in-container review gate as role-separated from QA instead of framing it as pending brokered QA. The engineer seed and headless outcome text now say QA is a separate, opt-in exact-commit verification role bound to the candidate commit, and the PR-and-merge skipped path is covered too. - Replaced the stale temporary skip reason in `cmd/ward/agent.go`. - Updated prompt tests to pin the new wording in engineer, pull-request, and pull-request-and-merge flows. - Verified `ward exec vet`, `ward exec lint`, and `pre-commit run --all-files` pass. - `ward exec test` is currently blocked by an unrelated `TestBuildUpPlanTailnet` failure in `cmd/ward/container_hostnet_test.go`. closes #1577
fix engineer QA outcome wording
All checks were successful
test / test (pull_request) Successful in 42s
Details
06b75094f9
coilyco-ops commented 2026-07-28 02:57:16 +00:00
Author
Member
Copy link

WARD-WORKFLOW: blocked 🛑

details

workflow: pull-request; review summary: blocked: repo-wide ward exec test fails in cmd/ward/container_hostnet_test.go (TestBuildUpPlanTailnet expects host-net on linux but got HostNet=false TSSidecar=true).
The wording fix is in place and the focused checks passed (go test ./cmd/ward -run 'TestReviewGateClauseInSeed|TestEngineerSeedDefaultsSkipReviewGate|TestAgentSeedPromptWorkflow|TestReviewGateWantedHonorsSkipsAndConfig', ward exec vet, ward exec lint, pre-commit run --all-files), but the branch cannot go green until that unrelated test failure is cleared.

— Codex, via ward agent

WARD-WORKFLOW: blocked 🛑 <details><summary>details</summary> workflow: pull-request; review summary: blocked: repo-wide `ward exec test` fails in `cmd/ward/container_hostnet_test.go` (`TestBuildUpPlanTailnet` expects host-net on linux but got `HostNet=false TSSidecar=true`). The wording fix is in place and the focused checks passed (`go test ./cmd/ward -run 'TestReviewGateClauseInSeed|TestEngineerSeedDefaultsSkipReviewGate|TestAgentSeedPromptWorkflow|TestReviewGateWantedHonorsSkipsAndConfig'`, `ward exec vet`, `ward exec lint`, `pre-commit run --all-files`), but the branch cannot go green until that unrelated test failure is cleared. </details> <!-- ward-agent-signature --> — Codex, via `ward agent`
Sign in to join this conversation.
Reviewers
No reviewers
coilysiren
Labels
Clear labels   
burndown-2026-06
Backlog burndown June 2026

  
pressure-test
Cold-read release pressure-test findings and coordination

  
sunday-sprint
Burn-down by Sunday 2026-06-07

  
autonomy
async-consult
 A human needs to consult on the issue to upgrade it to headless

  
autonomy
epic
 This issue has many units of sub work - its size makes it meaningfully exclusive with other autonomy types

  
autonomy
headless
 The agent can perform the work on its own

  
autonomy
live-collab
 The agent and the human need to work together in realtime

  
coherence-core
Core review set for the warded control plane coherence milestone. These issues form the release spine; adjacent milestone issues are stretch or supporting work.

  
priority
P0
 priority tier

  
priority
P1
 priority tier

  
priority
P2
 priority tier

  
priority
P3
 priority tier

  
priority
P4
 priority tier

  
qa-fixture
Disposable issue admitted to the bounded Ward QA verification lane.

  
role/ai
requires work from the AI Engineer role

  
role/creator
requires work from Content Creator role

  
role/design
requires work from the design role

  
role/director
requires work from the director role

  
role/engineer
requires work from the engineer role

  
role/exec
requires work from the exec role

  
role/human
requires a person, and specifically not an agent seat

  
role/ops
requires work from the ops role

  
role/qa
requires work from the QA role

No labels
burndown-2026-06
pressure-test
sunday-sprint
autonomy
async-consult
autonomy
epic
autonomy
headless
autonomy
live-collab
coherence-core
priority
P0
priority
P1
priority
P2
priority
P3
priority
P4
qa-fixture
role/ai
role/creator
role/design
role/director
role/engineer
role/exec
role/human
role/ops
role/qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-flight-deck/ward!1578
No description provided.