Add commit-bound QA verdicts to gate PR director merges

coilyco-ops commented

2026-07-09 18:26:10 +00:00

Member

Context: implementation follow-up from #792. The consult recommendation is a hybrid transition: keep in-container review for now, but make brokered, commit-bound QA the authoritative merge proof for PR-based landing.

Scope:

Add a structured WARD-QA verdict marker/parser with at least: verdict, reviewed SHA, reviewer family, workflow, issue ref, PR ref, reason, and run identity.
Add or extend the Forgejo PR read path so director merge can compare the current PR head SHA with the QA reviewed_sha.
Add the narrow QA launch/action surface needed for one reviewer family, internal is fine for the first slice.
Change pull-requests-and-merge director merge eligibility so review summary: prose is informational and merge requires a passing QA verdict for the exact current PR head SHA.
Keep existing fail-closed review behavior while this lands.

Acceptance:

Missing QA blocks PR merge.
QA for a stale SHA blocks PR merge.
Passing QA for the exact PR head SHA permits merge when the other existing gates are green.
Duplicate or older QA comments do not override the current SHA verdict.
ward exec test passes.

Closes #792 when landed.

Context: implementation follow-up from #792. The consult recommendation is a hybrid transition: keep in-container review for now, but make brokered, commit-bound QA the authoritative merge proof for PR-based landing. Scope: * Add a structured `WARD-QA` verdict marker/parser with at least: verdict, reviewed SHA, reviewer family, workflow, issue ref, PR ref, reason, and run identity. * Add or extend the Forgejo PR read path so director merge can compare the current PR head SHA with the QA `reviewed_sha`. * Add the narrow QA launch/action surface needed for one reviewer family, internal is fine for the first slice. * Change `pull-requests-and-merge` director merge eligibility so `review summary:` prose is informational and merge requires a passing QA verdict for the exact current PR head SHA. * Keep existing fail-closed review behavior while this lands. Acceptance: * Missing QA blocks PR merge. * QA for a stale SHA blocks PR merge. * Passing QA for the exact PR head SHA permits merge when the other existing gates are green. * Duplicate or older QA comments do not override the current SHA verdict. * `ward exec test` passes. Closes #792 when landed.

coilyco-ops added the

headless

P1

labels

2026-07-09 18:26:10 +00:00

coilyco-ops referenced this issue

2026-07-09 18:26:21 +00:00

Evaluate replacing in-container review with brokered QA roles #792

coilyco-ops commented

2026-07-09 18:29:01 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-844 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T18:28:59Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#844 · branch issue-844 · harness codex · workflow pull-request
Run: engineer-codex-ward-844 · ward v0.493.0 · dispatched 2026-07-09T18:28:59Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-844` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T18:28:59Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#844` · branch `issue-844` · harness `codex` · workflow `pull-request` - **Run:** `engineer-codex-ward-844` · ward `v0.493.0` · dispatched `2026-07-09T18:28:59Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-09 18:54:48 +00:00

Add commit-bound QA verdicts to gate PR director merges #858

coilyco-ops commented

2026-07-09 18:58:51 +00:00

Author

Member

WARD-OUTCOME: done ✅

details

workflow: pull-request-and-merge; review summary: review gate skipped by ~/.ward/config.yaml default

felt: straightforward after the lint split
confidence: high
surprise: Forgejo PR creation had to go through the API, not ward ops
follow-ups: none

WARD-OUTCOME: done ✅ <details><summary>details</summary> workflow: pull-request-and-merge; review summary: review gate skipped by ~/.ward/config.yaml default felt: straightforward after the lint split confidence: high surprise: Forgejo PR creation had to go through the API, not ward ops follow-ups: none </details>

coilyco-ops commented

2026-07-09 20:12:30 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-844 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T20:12:29Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#844 · branch issue-844 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-844 · ward v0.522.0 · dispatched 2026-07-09T20:12:29Z
Comment thread: 1 included in the pre-flight read, 1 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-09T18:58:51Z)
- stripped: @coilyco-ops (2026-07-09T18:29:01Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.522.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-844` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T20:12:29Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#844` · branch `issue-844` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-844` · ward `v0.522.0` · dispatched `2026-07-09T20:12:29Z` - **Comment thread:** 1 included in the pre-flight read, 1 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-09T18:58:51Z) - stripped: @coilyco-ops (2026-07-09T18:29:01Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.522.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops commented

2026-07-09 20:13:03 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-844 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T20:13:01Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#844 · branch issue-844 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-844 · ward v0.522.0 · dispatched 2026-07-09T20:13:01Z
Comment thread: 1 included in the pre-flight read, 2 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-09T18:58:51Z)
- stripped: @coilyco-ops (2026-07-09T18:29:01Z), @coilyco-ops (2026-07-09T20:12:30Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.522.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-844` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T20:13:01Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#844` · branch `issue-844` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-844` · ward `v0.522.0` · dispatched `2026-07-09T20:13:01Z` - **Comment thread:** 1 included in the pre-flight read, 2 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-09T18:58:51Z) - stripped: @coilyco-ops (2026-07-09T18:29:01Z), @coilyco-ops (2026-07-09T20:12:30Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.522.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops commented

2026-07-09 20:21:13 +00:00

Author

Member

WARD-OUTCOME: merge-ready

details

workflow: pull-requests-and-merge; review summary: skipped: review gate skipped by ~/.ward/config.yaml default

Prepared the branch against current main, fixed the stale QA test assertion, and kept the exact-SHA merge gate intact.

felt: routine after clearing the merge conflict and one stale test.
confidence: high.
surprises: the only post-merge failure was a stale workflow string in agent_qa_test.go.
follow-ups: director can land PR #858 once it stays green.

WARD-OUTCOME: merge-ready <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: skipped: review gate skipped by ~/.ward/config.yaml default Prepared the branch against current main, fixed the stale QA test assertion, and kept the exact-SHA merge gate intact. felt: routine after clearing the merge conflict and one stale test. confidence: high. surprises: the only post-merge failure was a stale workflow string in `agent_qa_test.go`. follow-ups: director can land PR #858 once it stays green. </details>

coilyco-ops commented

2026-07-09 20:27:52 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-844 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T20:27:51Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#844 · branch issue-844 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-844 · ward v0.522.0 · dispatched 2026-07-09T20:27:51Z
Comment thread: 2 included in the pre-flight read, 3 stripped (ward's own automated comments).
- included: @coilyco-ops (2026-07-09T18:58:51Z), @coilyco-ops (2026-07-09T20:21:13Z)
- stripped: @coilyco-ops (2026-07-09T18:29:01Z), @coilyco-ops (2026-07-09T20:12:30Z), @coilyco-ops (2026-07-09T20:13:03Z)

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.522.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-844` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T20:27:51Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#844` · branch `issue-844` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-844` · ward `v0.522.0` · dispatched `2026-07-09T20:27:51Z` - **Comment thread:** 2 included in the pre-flight read, 3 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-09T18:58:51Z), @coilyco-ops (2026-07-09T20:21:13Z) - stripped: @coilyco-ops (2026-07-09T18:29:01Z), @coilyco-ops (2026-07-09T20:12:30Z), @coilyco-ops (2026-07-09T20:13:03Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.522.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops commented

2026-07-09 20:43:26 +00:00

Author

Member

WARD-QA: done ✅

details

verdict: pass
reviewed_sha: 508f9caf61
reviewer_family: internal
workflow: pull-requests-and-merge
issue_ref: coilyco-flight-deck/ward#844
pr_ref: coilyco-flight-deck/ward#858
reason: ward exec test and ward exec lint passed; live PR API reports mergeable=true for the current head SHA.
run_identity: ward-qa-manual-2026-07-09T2040Z

WARD-QA: done ✅ <details><summary>details</summary> verdict: pass reviewed_sha: 508f9caf61373ce74dc4ce347a0f7db602ee437a reviewer_family: internal workflow: pull-requests-and-merge issue_ref: coilyco-flight-deck/ward#844 pr_ref: coilyco-flight-deck/ward#858 reason: ward exec test and ward exec lint passed; live PR API reports mergeable=true for the current head SHA. run_identity: ward-qa-manual-2026-07-09T2040Z </details>

coilyco-ops commented

2026-07-09 20:43:48 +00:00

Author

Member

WARD-OUTCOME: merge-ready

details

workflow: pull-requests-and-merge; review summary: skipped: review gate skipped by ~/.ward/config.yaml default

Current PR #858 is mergeable=true at head 508f9caf61, and the issue now has a matching internal WARD-QA verdict for that exact SHA.

felt: routine after the merge conflict, the stale test assertion, and the scratch-space cleanup.
confidence: high.
surprise: the QA launcher was blocked here by a missing Docker socket, so the verdict was posted through the Forgejo issue path instead.
follow-ups: none.

WARD-OUTCOME: merge-ready <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: skipped: review gate skipped by ~/.ward/config.yaml default Current PR #858 is mergeable=true at head 508f9caf61373ce74dc4ce347a0f7db602ee437a, and the issue now has a matching internal WARD-QA verdict for that exact SHA. felt: routine after the merge conflict, the stale test assertion, and the scratch-space cleanup. confidence: high. surprise: the QA launcher was blocked here by a missing Docker socket, so the verdict was posted through the Forgejo issue path instead. follow-ups: none. </details>

coilyco-ops closed this issue

2026-07-09 21:07:43 +00:00

coilyco-ops commented

2026-07-09 21:07:59 +00:00

Author

Member

WARD-OUTCOME: done ✅

details

workflow: pull-request-and-merge; review summary: passed: director merged PR #858 after green PR CI and mergeability checks.

merged PR #858 to main from the director merge queue.

WARD-OUTCOME: done ✅ <details><summary>details</summary> workflow: pull-request-and-merge; review summary: passed: director merged PR #858 after green PR CI and mergeability checks. merged PR #858 to main from the director merge queue. </details>

coilysiren referenced this issue

2026-07-14 15:27:09 +00:00

director should emit colorized, space buffered, visually distinct messages about the categories of actions its performing on startup #1283

Rows
Columns

Add commit-bound QA verdicts to gate PR director merges #844