coilyco-flight-deck/ward
2
0
Fork 0
Code Issues 108 Pull requests 1 Projects Releases 737 Packages Wiki Activity Actions 1

Fix closed-unmerged launched PR reaping #1292

Merged
coilyco-ops merged 2 commits from issue-1007 into main 2026-07-14 19:22:22 +00:00
Conversation 1 Commits 2 Files changed 2 +107
coilyco-ops commented 2026-07-14 19:06:43 +00:00
Member
Copy link

This patch teaches the container reaper to notice a launched run whose submitted PR later closes without merging, then comment failure and release the reservation instead of leaving the issue silently stuck.

Why:

  • It closes the gap where a closed-unmerged PR path left the carried issue reserved.
  • It keeps the fix on consumer code only.

Checks:

  • Targeted go test on the reaper paths passed before the local scratch exhaustion hit broader linting.
  • ward exec test could not complete in this container because the overlay ran out of temp space.

closes #1007
ward.workflow: pull-request-and-merge

This patch teaches the container reaper to notice a launched run whose submitted PR later closes without merging, then comment failure and release the reservation instead of leaving the issue silently stuck. Why: - It closes the gap where a closed-unmerged PR path left the carried issue reserved. - It keeps the fix on consumer code only. Checks: - Targeted `go test` on the reaper paths passed before the local scratch exhaustion hit broader linting. - `ward exec test` could not complete in this container because the overlay ran out of temp space. closes #1007 ward.workflow: pull-request-and-merge
Fix closed-unmerged launched PR reaping
Some checks failed
test / test (pull_request) Failing after 1m2s
Details
c7bd5c7d73
coilyco-ops commented 2026-07-14 19:13:17 +00:00
Author
Member
Copy link

PR #1292 failed in Forgejo Actions at golangci-lint after go vet and go test passed. The same scratch-space limit also showed up locally while reproducing the lint stage. Please rerun after the runner scratch cache has room again.

PR #1292 failed in Forgejo Actions at `golangci-lint` after `go vet` and `go test` passed. The same scratch-space limit also showed up locally while reproducing the lint stage. Please rerun after the runner scratch cache has room again.
Refactor closed-unmerged PR reap check
All checks were successful
test / test (pull_request) Successful in 37s
Details
f9508a36e7
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
burndown-2026-06
Backlog burndown June 2026

  
pressure-test
Cold-read release pressure-test findings and coordination

  
sunday-sprint
Burn-down by Sunday 2026-06-07

  
coherence-core
Core review set for the warded control plane coherence milestone. These issues form the release spine; adjacent milestone issues are stretch or supporting work.

  
consult
A human decision, design, or external action must happen first. Fail-closed default for unlabeled/low-confidence.

  
headless
Agent can take it from open issue to merged change with no human in the loop. The auto-burndown queue.

  
interactive
Agent does the work but pauses at a human checkpoint mid-flight (design choice, destructive step, human-only verification).

  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
burndown-2026-06
pressure-test
sunday-sprint
coherence-core
consult
headless
interactive
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/ward!1292
No description provided.