fix(goose): require close commit before teardown #1285

Merged

coilyco-ops merged 1 commit from issue-998 into main

2026-07-14 15:47:05 +00:00

coilyco-ops commented

2026-07-14 15:37:04 +00:00

Member

That keeps the deterministic success path on the happy side of teardown while leaving the existing fail-closed reaper repair and diagnostics in place for residual work that still slips through.

closes #998
ward.workflow: pull-request-and-merge
Validation: pre-commit run --all-files passed. TMPDIR=/workspace/ward/.tmp go test ./cmd/ward -run 'TestGooseLandingClause|TestAgentSeedPromptHeadlessReflection|TestReapTargetTreeDirtyOnlyResidualRunRepairsAndLands' passed.
Note: ward exec test still hits unrelated environment-sensitive failures in cmd/ward on this container (TestPrepareScratchSpace, TestCloneGate).

Goose now gets an explicit landing rule in the engineer seed: if the run changes files, it must keep going until a same-repo closing commit exists before it emits the terminal completion line that tears the container down. That keeps the deterministic success path on the happy side of teardown while leaving the existing fail-closed reaper repair and diagnostics in place for residual work that still slips through. - closes #998 - ward.workflow: pull-request-and-merge - Validation: `pre-commit run --all-files` passed. `TMPDIR=/workspace/ward/.tmp go test ./cmd/ward -run 'TestGooseLandingClause|TestAgentSeedPromptHeadlessReflection|TestReapTargetTreeDirtyOnlyResidualRunRepairsAndLands'` passed. - Note: `ward exec test` still hits unrelated environment-sensitive failures in `cmd/ward` on this container (`TestPrepareScratchSpace`, `TestCloneGate`).

coilyco-ops added 1 commit

2026-07-14 15:37:05 +00:00