Make director-surface Docker socket fix reach live first-run cleanup #1018

Closed
coilyco-ops wants to merge 3 commits from issue-1011 into main
Member

closes #1011

ward.workflow: pull-requests-and-merge

closes #1011 ward.workflow: pull-requests-and-merge
fix: point director reap at brokered cleanup
Some checks failed
test / test (pull_request) Failing after 18s
316979c8b5
Author
Member

WARD-OUTCOME: blocked 🛑

details workflow: pull-requests-and-merge; review summary: review gate skipped by ~/.ward/config.yaml default

CI failed on go test for PR #1018. Local ward exec test and go test ./... reproduction in this checkout also fail on repo-baseline drift: missing generated .ward/ward-kdl/*.guardfile.kdl source files and the neutral WARD_CONFIG_REF bundle state.

The reap-hint patch is committed, but this branch is blocked until the generated ward-kdl source bundle or the test harness inputs are restored and the repo-wide test suite can pass.

WARD-OUTCOME: blocked 🛑 <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: review gate skipped by ~/.ward/config.yaml default CI failed on `go test` for PR #1018. Local `ward exec test` and `go test ./...` reproduction in this checkout also fail on repo-baseline drift: missing generated `.ward/ward-kdl/*.guardfile.kdl` source files and the neutral `WARD_CONFIG_REF` bundle state. The reap-hint patch is committed, but this branch is blocked until the generated ward-kdl source bundle or the test harness inputs are restored and the repo-wide test suite can pass. </details>
Author
Member

verdict: block
confidence: high
summary: PR #1018 is mergeable, but the required test / test (pull_request) context is red. The failure is not in the small reap-hint diff itself; the current ward test gate is failing because the .ward/ward-kdl/* source bundle files are missing.
findings:

  • severity: high
    file: n/a
    line: n/a
    problem: Actions run 1618 fails in cmd/ward: TestDefaultsAssetsMirrorWardKDL, TestFleetAssetsMirrorWardKDL, TestOpsAssetsMatchWardKDL, TestTopologyAssetsMirrorWardKDL, TestRunDoctorWithValidBundle, and TestRunSetupWithFixtureRef all fail on missing .ward/ward-kdl/* or ward-kdl.forgejo.guardfile.kdl inputs.
    impact: The director cannot merge this PR while the required check is red. This appears to be blocked on the source-bundle restoration tracked by ward#1014; after that lands, this branch needs a rebase/rerun or a replacement PR.
    conclusion: Review blocks PR #1018 for the red required check. The reap hint may be a reasonable small fix, but it cannot land until the ward-kdl source-bundle test gate is restored and this PR is rerun green.
verdict: block confidence: high summary: PR #1018 is mergeable, but the required `test / test (pull_request)` context is red. The failure is not in the small reap-hint diff itself; the current ward test gate is failing because the `.ward/ward-kdl/*` source bundle files are missing. findings: - severity: high file: n/a line: n/a problem: Actions run 1618 fails in `cmd/ward`: `TestDefaultsAssetsMirrorWardKDL`, `TestFleetAssetsMirrorWardKDL`, `TestOpsAssetsMatchWardKDL`, `TestTopologyAssetsMirrorWardKDL`, `TestRunDoctorWithValidBundle`, and `TestRunSetupWithFixtureRef` all fail on missing `.ward/ward-kdl/*` or `ward-kdl.forgejo.guardfile.kdl` inputs. impact: The director cannot merge this PR while the required check is red. This appears to be blocked on the source-bundle restoration tracked by `ward#1014`; after that lands, this branch needs a rebase/rerun or a replacement PR. conclusion: Review blocks PR #1018 for the red required check. The reap hint may be a reasonable small fix, but it cannot land until the ward-kdl source-bundle test gate is restored and this PR is rerun green.
coilyco-ops closed this pull request 2026-07-10 19:30:21 +00:00
All checks were successful
test / test (pull_request) Successful in 26s

Pull request closed

Sign in to join this conversation.
No description provided.