Guard Forgejo Actions pagination #420

Closed
coilyco-ops wants to merge 0 commits from issue-419 into main
Member

closes #419

ward.workflow: pull-requests-and-merge

closes #419 ward.workflow: pull-requests-and-merge
Author
Member

verdict: block
confidence: high
summary: The patch adds a new safe bridge, but it leaves the existing documented Actions task listing surface intact. The original performance trap remains reachable through ward ops forgejo tasks list --limit N.
findings:

  • severity: high
    file: docs/ward-ops-forgejo-reference.md
    line: 865
    problem: The existing ward ops forgejo tasks list read surface remains documented with --page optional and --limit optional, while .ward/ward-kdl.forgejo.guardfile.kdl still exposes can list tasks. The PR adds ward ops forgejo actions tasks, but it does not adjust or fence the existing task list command that agents already see in the generated reference.
    impact: The issue contract asks for the ward Forgejo Actions read surface to default to a safe first page. After this patch, an agent can still follow the existing committed reference and run the same hazardous shape, pulling full task history when limit is used without page.
    conclusion: Review blocks PR #420. The safe bridge and tests are useful, but the dangerous existing tasks list surface still needs to be adjusted, hidden, or documented with a hard guard so callers cannot keep triggering full-history Actions pulls through the current ward ops reference.
verdict: block confidence: high summary: The patch adds a new safe bridge, but it leaves the existing documented Actions task listing surface intact. The original performance trap remains reachable through `ward ops forgejo tasks list --limit N`. findings: - severity: high file: docs/ward-ops-forgejo-reference.md line: 865 problem: The existing `ward ops forgejo tasks list` read surface remains documented with `--page` optional and `--limit` optional, while `.ward/ward-kdl.forgejo.guardfile.kdl` still exposes `can list tasks`. The PR adds `ward ops forgejo actions tasks`, but it does not adjust or fence the existing task list command that agents already see in the generated reference. impact: The issue contract asks for the ward Forgejo Actions read surface to default to a safe first page. After this patch, an agent can still follow the existing committed reference and run the same hazardous shape, pulling full task history when `limit` is used without `page`. conclusion: Review blocks PR #420. The safe bridge and tests are useful, but the dangerous existing `tasks list` surface still needs to be adjusted, hidden, or documented with a hard guard so callers cannot keep triggering full-history Actions pulls through the current ward ops reference.
fix: make forgejo actions tasks page literal
Some checks failed
ci / gate (pull_request) Failing after 13s
dc0eecb86c
test: capture forgejo tasks list request shape
Some checks failed
ci / gate (pull_request) Failing after 10s
0cb41babf0
test: assert forgejo tasks list first page
Some checks failed
ci / gate (pull_request) Failing after 13s
c116dcb2b8
test: remove live forgejo tasks list check
Some checks failed
ci / gate (pull_request) Failing after 9s
d5d169feb8
fix: honor forgejo workspace in ward ref lookup
Some checks failed
ci / gate (pull_request) Failing after 8s
217dedd400
fix: seed ward ref from forgejo workspace
All checks were successful
ci / gate (pull_request) Successful in 8s
26244b9c35
Merge remote-tracking branch 'origin/main' into issue-419
Some checks failed
ci / gate (pull_request) Successful in 10s
ci / gate (push) Successful in 14s
mirror-to-github / test (push) Successful in 1m11s
release / test (push) Successful in 59s
mirror-to-github / mirror (push) Successful in 8s
release / plan-release (push) Successful in 7s
release / publish-dev-base (push) Failing after 4m17s
release / release (push) Has been skipped
8513e4144b
# Conflicts:
#	docs/ward-specs.md
#	tests/test_ward_specs_bundle.py
coilysiren closed this pull request 2026-07-10 18:02:30 +00:00
Some checks failed
ci / gate (pull_request) Successful in 10s
ci / gate (push) Successful in 14s
mirror-to-github / test (push) Successful in 1m11s
release / test (push) Successful in 59s
mirror-to-github / mirror (push) Successful in 8s
release / plan-release (push) Successful in 7s
release / publish-dev-base (push) Failing after 4m17s
release / release (push) Has been skipped

Pull request closed

Sign in to join this conversation.
No description provided.