chore(pre-commit): drop the dead typos entry from ECO_HOOK_SKIPS #1156

Merged

coilysiren merged 3 commits from chore/eco-hook-skips-typos into main

2026-08-20 09:01:59 +00:00

coilyco-ops commented

2026-08-20 08:26:34 +00:00

Member

hook_ids_for() filters DEFAULT_HOOK_IDS, and typos is not in that list. It is the crate-ci/typos block managed_block() emits unconditionally, so the entry never fired: every eco-* repo got the hook regardless of the declared intent.

Resolves #1155 the second way. Keeping the hook is the better outcome:

It caught real typos in eco-app's own Python (Overrideable, mis-label, a thr local).
The skip is repo-prefix-shaped while the actual concern is tree-shaped. The stated rationale names the Strange Loop Games Unity SDK, which lives in eco-mods' unity-embedded/, not in every eco-* repo.
_typos.toml targets the tree directly, and eco-app and eco-mods both already declare their exclusions that way.

No behavior change, since the entry was inert. This removes a declaration that read as an opt-out and was not one.

Closes #1155

`hook_ids_for()` filters `DEFAULT_HOOK_IDS`, and `typos` is not in that list. It is the `crate-ci/typos` block `managed_block()` emits unconditionally, so the entry never fired: every eco-* repo got the hook regardless of the declared intent. Resolves #1155 the second way. Keeping the hook is the better outcome: * It caught real typos in eco-app's own Python (`Overrideable`, `mis-label`, a `thr` local). * The skip is repo-prefix-shaped while the actual concern is tree-shaped. The stated rationale names the Strange Loop Games Unity SDK, which lives in eco-mods' `unity-embedded/`, not in every eco-* repo. * `_typos.toml` targets the tree directly, and eco-app and eco-mods both already declare their exclusions that way. No behavior change, since the entry was inert. This removes a declaration that read as an opt-out and was not one. Closes #1155

coilyco-ops added 1 commit

2026-08-20 08:26:34 +00:00

chore(pre-commit): drop the dead typos entry from ECO_HOOK_SKIPS

ci / aos-cli-tests (pull_request) Successful in 16s

Details

ci / ward-doctor (pull_request) Successful in 11s

Details

ci / aos-eval-tests (pull_request) Failing after 54s

Details

ci / gate (pull_request) Successful in 1m48s

Details

1030ace70d

hook_ids_for() filters DEFAULT_HOOK_IDS, and typos is not in that list. It
is the crate-ci/typos block managed_block() emits unconditionally, so the
entry never fired and every eco-* repo got the hook regardless.

Keeping the hook is the right outcome: it caught real typos in eco-app's own
Python, the skip is repo-prefix-shaped while the concern is tree-shaped, and
_typos.toml targets the tree directly. eco-app and eco-mods both already
declare their exclusions that way.

Closes #1155

coilyco-ops requested review from coilysiren

2026-08-20 08:26:34 +00:00

coilysiren added 1 commit

2026-08-20 08:47:32 +00:00

Merge branch 'main' into chore/eco-hook-skips-typos

ci / aos-cli-tests (pull_request) Successful in 21s

Details

ci / ward-doctor (pull_request) Successful in 12s

Details

ci / aos-eval-tests (pull_request) Failing after 49s

Details

ci / gate (pull_request) Failing after 1m8s