feat(documentation-layout): a vendored tree takes no size cap #1116

Merged
coilysiren merged 1 commit from aos/claude/aw85-vendored into main 2026-08-17 17:53:41 +00:00
Member

Kai's call on the eco-mods wall, and the half of #1115 that merged without it - that PR landed the org-profile-README exemption but not this commit, which arrived after the merge.

A repo may declare vendored path prefixes whose Markdown takes no size cap, because the shape is owned outside the repo. eco-mods carries both kinds:

  • unity/Assets/EcoModKit/ - the Eco SDK as upstream ships it, citing wiki.play.eco and Eco 0.9.6 release notes. Cutting its docs forks upstream.
  • mods/Mods/UserCode/ - one README per mod, each rendering as that mod's mod.io store page. Cutting one changes what a player reads.

Two bounds keep this from being the escape hatch #1108 removed

  • Prefixes only, never a bare basename. A basename would exempt one filename everywhere, which is exactly what the per-file exemptions did. test_a_vendored_prefix_is_not_a_basename pins it.
  • Size only. Placement and flatness stay with excludes, so declaring a tree vendored cannot quietly widen where Markdown may live. test_a_vendored_tree_still_takes_the_placement_rules pins that.

It is still a repo-declared exemption, which this rule otherwise refuses, so the doc says the reason belongs beside the declaration - and eco-mods writes one per entry.

Also corrects a drifted inventory

docs/documentation-bands.md carried three statements the bands had already falsified: an 80-line / 4000-char cap the bands replaced, excludes described as exempting size checks, and docs/FEATURES.md described as carrying a special cap.

eco-mods is red on main waiting for this

The fleet migration (coilysiren/inbox#374) asked for the hook suite on every repo that lacked it, so eco-mods now carries it pinned at aos-precommit-v0.27.0 and three checks are red against exactly the two files above. A repo silently missing the suite is a worse state than one carrying it with a tracked blocker, so the red is deliberate and visible.

vendored is already declared in that repo's pyproject.toml, where the released checker ignores it as an unknown key. Once this merges and the train cuts a rev, the fix there is one line: advance the pin.

Verified

533 tests pass, pre-commit run --all-files is green, branched from current main.

Kai's call on the eco-mods wall, and **the half of #1115 that merged without it** - that PR landed the org-profile-README exemption but not this commit, which arrived after the merge. A repo may declare `vendored` path prefixes whose Markdown takes no size cap, because the shape is owned outside the repo. eco-mods carries both kinds: * `unity/Assets/EcoModKit/` - the Eco SDK as upstream ships it, citing wiki.play.eco and Eco 0.9.6 release notes. **Cutting its docs forks upstream.** * `mods/Mods/UserCode/` - one README per mod, each rendering as that mod's mod.io store page. **Cutting one changes what a player reads.** ## Two bounds keep this from being the escape hatch #1108 removed * **Prefixes only, never a bare basename.** A basename would exempt one filename everywhere, which is exactly what the per-file exemptions did. `test_a_vendored_prefix_is_not_a_basename` pins it. * **Size only.** Placement and flatness stay with `excludes`, so declaring a tree vendored cannot quietly widen where Markdown may live. `test_a_vendored_tree_still_takes_the_placement_rules` pins that. It is still a repo-declared exemption, which this rule otherwise refuses, so the doc says the reason belongs beside the declaration - and eco-mods writes one per entry. ## Also corrects a drifted inventory `docs/documentation-bands.md` carried three statements the bands had already falsified: an 80-line / 4000-char cap the bands replaced, `excludes` described as exempting size checks, and `docs/FEATURES.md` described as carrying a special cap. ## eco-mods is red on main waiting for this The fleet migration (coilysiren/inbox#374) asked for the hook suite on every repo that lacked it, so eco-mods now carries it pinned at `aos-precommit-v0.27.0` and **three checks are red against exactly the two files above**. A repo silently missing the suite is a worse state than one carrying it with a tracked blocker, so the red is deliberate and visible. `vendored` is already declared in that repo's `pyproject.toml`, where the released checker ignores it as an unknown key. **Once this merges and the train cuts a rev, the fix there is one line: advance the pin.** ## Verified 533 tests pass, `pre-commit run --all-files` is green, branched from current main.
feat(documentation-layout): a vendored tree takes no size cap
All checks were successful
ci / aos-eval-tests (pull_request) Successful in 4s
ci / ward-doctor (pull_request) Successful in 15s
ci / aos-cli-tests (pull_request) Successful in 21s
ci / gate (pull_request) Successful in 54s
324061d722
Kai's call on the eco-mods wall, and the half of #1115 that merged without it.
A repo may declare `vendored` path prefixes whose Markdown takes no size cap,
because the shape is owned outside the repo: an SDK it vendors, or copy an
external surface renders. eco-mods carries both, an EcoModKit tree upstream
owns and per-mod README copy mod.io renders, and neither is that repo's prose
to cut.

Two bounds keep this from being the escape hatch #1108 removed:

* Prefixes only, never a bare basename. A basename would exempt one filename
  everywhere, which is exactly what the per-file exemptions did.
* Size only. Placement and flatness stay with `excludes`, so declaring a tree
  vendored cannot quietly widen where Markdown may live.

It is still a repo-declared exemption, which this rule otherwise refuses, so
the doc says the reason belongs beside the declaration.

Also corrects the carve-out inventory in documentation-bands.md, which had
drifted to three wrong statements: an 80-line / 4000-char cap the bands
replaced, `excludes` described as exempting size checks, and docs/FEATURES.md
described as carrying a special cap.

533 tests pass and pre-commit run --all-files is green.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
coilysiren deleted branch aos/claude/aw85-vendored 2026-08-17 17:53:42 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-flight-deck/agentic-os!1116
No description provided.