code-comments: skip the apply-agentic-os-hooks managed marker region #993

New issue

Closed

opened 2026-08-11 08:09:54 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-11 08:09:54 +00:00

Member

The problem

check_code_comments.scan_yaml flags every YAML comment below the first content line. Three such comments in .pre-commit-config.yaml are emitted by scripts/apply-agentic-os-hooks.py itself, at fixed positions:

BEGIN_MARKER (apply-agentic-os-hooks.py:103)
END_MARKER (apply-agentic-os-hooks.py:104)
the actionlint note (apply-agentic-os-hooks.py:262)

None can move to a top header without breaking the block delimiters the rollout script parses, and any in-repo edit is overwritten on the next rollout. So the hook flags output its own sibling generator produces.

Current state

Every consumer works around it with the same exclude, including agentic-os for its own copy:

coilyco-flight-deck/agentic-os - pyproject.toml
coilyco-flight-deck/infrastructure - pyproject.toml
coilyco-bridge/deploy - pyproject.toml
coilyco-bridge/agentic-os-kai - pyproject.toml
coilyco-gaming/sirens-echo - pyproject.toml, re-confirmed in coilyco-gaming/sirens-echo#103

A fleet-wide identical exclude is the signal the rule has a gap, not that five repos are dirty. It also over-excludes: the whole file goes unchecked, so a genuinely misplaced hand-written comment elsewhere in .pre-commit-config.yaml is invisible.

Proposed fix

Teach scan_yaml to skip comment lines inside a # BEGIN managed by ... / # END managed by ... region. The markers already exist as a recognized shape in the rollout script's LEGACY_BLOCKS list, so the convention is established. That keeps the rest of each file enforced and lets all five repos drop the exclude.

Wants a new aos-precommit-v* tag and a repin sweep once landed.

## The problem `check_code_comments.scan_yaml` flags every YAML comment below the first content line. Three such comments in `.pre-commit-config.yaml` are emitted by `scripts/apply-agentic-os-hooks.py` itself, at fixed positions: * `BEGIN_MARKER` (`apply-agentic-os-hooks.py:103`) * `END_MARKER` (`apply-agentic-os-hooks.py:104`) * the actionlint note (`apply-agentic-os-hooks.py:262`) None can move to a top header without breaking the block delimiters the rollout script parses, and any in-repo edit is overwritten on the next rollout. So the hook flags output its own sibling generator produces. ## Current state Every consumer works around it with the same exclude, including agentic-os for its own copy: * `coilyco-flight-deck/agentic-os` - `pyproject.toml` * `coilyco-flight-deck/infrastructure` - `pyproject.toml` * `coilyco-bridge/deploy` - `pyproject.toml` * `coilyco-bridge/agentic-os-kai` - `pyproject.toml` * `coilyco-gaming/sirens-echo` - `pyproject.toml`, re-confirmed in coilyco-gaming/sirens-echo#103 A fleet-wide identical exclude is the signal the rule has a gap, not that five repos are dirty. It also over-excludes: the whole file goes unchecked, so a genuinely misplaced hand-written comment elsewhere in `.pre-commit-config.yaml` is invisible. ## Proposed fix Teach `scan_yaml` to skip comment lines inside a `# BEGIN managed by ...` / `# END managed by ...` region. The markers already exist as a recognized shape in the rollout script's `LEGACY_BLOCKS` list, so the convention is established. That keeps the rest of each file enforced and lets all five repos drop the exclude. Wants a new `aos-precommit-v*` tag and a repin sweep once landed.

coilyco-ops added the

labels

2026-08-17 02:36:09 +00:00

coilyco-ops referenced this issue

2026-08-22 20:54:50 +00:00

Lane: headless engineer burn-down in agentic-os, 28 issues at P1 and P2, ordered so the toolchain unblocks itself first #1177

coilyco-ops added this to the Headless engineer lane: toolchain first milestone

2026-08-22 20:58:12 +00:00