Self-dogfood: bring agentic-os into compliance with the deferred skill-discipline hooks #96

New issue

Open

opened 2026-05-29 01:03:31 +00:00 by coilysiren · 0 comments

coilysiren commented

2026-05-29 01:03:31 +00:00

Owner

Context

agentic-os ships the skill-discipline / catalog pre-commit hooks but dogfoods them via a local block (it cannot reference itself by remote tag). Until now that local block only ran catalog-block-present, closes-issue, and warp-go-vet. validate-skills is now wired: all 56 skills pass the 10000-byte / 500-line cap, and the new role: thin 1/4 cap (1000 bytes / 20 lines) is enforced on agents-* / models-* via the new .agents/skills/categories.yaml.

The remaining shipped hooks are still deferred on this repo. This issue brings agentic-os into compliance so they can be restored to the local dogfood block.

Deferred hooks + measured blast radius

documentation-layout (4000 chars / 80 lines per .md): 23 of 56 skills over. Worst offenders: tooling-honeycomb-ui (9657B / 133L), coding-github-pr-workflow (8747B / 305L), tooling-capability-scout (184L), coding-terraform-module-library (251L), vault-obsidian-markdown (196L). Each needs a split into a sibling reference file or a trim.
- Decision required before splitting: check_skill_flatness forbids ANY subdirectory inside a skill folder, but the references/ pattern is already pervasive (tooling-capability-scout, tooling-product-brainstorming, tooling-skill-authoring, and the freshly-split tooling-warp all use it). Compliance must either (a) exempt references/ in check_skill_flatness (code fix, preferred) or (b) eliminate references/ everywhere (disruptive). Settle this first or the splits will thrash.
catalog-doc-size: enumerate and fix any oversized catalog docs.
catalog-trifecta: README.md and docs/FEATURES.md need their required See-also / H2 sections.
code-comments: contiguous >2-line comment blocks across .agents/skills/*/script.py and library code. Trim, or move longer explanation into docs/.
dead-cross-links: ~20 cross-repo skill links plus a few illustrative placeholders. The name-based stale-ref check trips on the [`prefix-name`](../../../../<repo>/.../SKILL.md) form. Decide the canonical cross-repo reference form, then sweep. (One such link was already de-linked for the validate-skills wiring.)
repo-pointer-skills: generate any missing repo-pointer skills and their kind: repo entries in categories.yaml.
description tightening (optional): 14 skills have descriptions over 200 bytes (the cap here is currently 500). Tighten if adopting the 200-byte cap.

Acceptance

All deferred hooks pass on agentic-os and are restored to the local dogfood block in .pre-commit-config.yaml.
.agents/skills/categories.yaml remains the source of truth (already added).

## Context agentic-os ships the skill-discipline / catalog pre-commit hooks but dogfoods them via a local block (it cannot reference itself by remote tag). Until now that local block only ran `catalog-block-present`, `closes-issue`, and `warp-go-vet`. `validate-skills` is now wired: all 56 skills pass the 10000-byte / 500-line cap, and the new `role: thin` 1/4 cap (1000 bytes / 20 lines) is enforced on `agents-*` / `models-*` via the new `.agents/skills/categories.yaml`. The remaining shipped hooks are still deferred on this repo. This issue brings agentic-os into compliance so they can be restored to the local dogfood block. ## Deferred hooks + measured blast radius - **documentation-layout** (4000 chars / 80 lines per `.md`): 23 of 56 skills over. Worst offenders: `tooling-honeycomb-ui` (9657B / 133L), `coding-github-pr-workflow` (8747B / 305L), `tooling-capability-scout` (184L), `coding-terraform-module-library` (251L), `vault-obsidian-markdown` (196L). Each needs a split into a sibling reference file or a trim. - **Decision required before splitting:** `check_skill_flatness` forbids ANY subdirectory inside a skill folder, but the `references/` pattern is already pervasive (`tooling-capability-scout`, `tooling-product-brainstorming`, `tooling-skill-authoring`, and the freshly-split `tooling-warp` all use it). Compliance must either (a) exempt `references/` in `check_skill_flatness` (code fix, preferred) or (b) eliminate `references/` everywhere (disruptive). Settle this first or the splits will thrash. - **catalog-doc-size**: enumerate and fix any oversized catalog docs. - **catalog-trifecta**: `README.md` and `docs/FEATURES.md` need their required See-also / H2 sections. - **code-comments**: contiguous >2-line comment blocks across `.agents/skills/*/script.py` and library code. Trim, or move longer explanation into `docs/`. - **dead-cross-links**: ~20 cross-repo skill links plus a few illustrative placeholders. The name-based stale-ref check trips on the ``[`prefix-name`](../../../../<repo>/.../SKILL.md)`` form. Decide the canonical cross-repo reference form, then sweep. (One such link was already de-linked for the validate-skills wiring.) - **repo-pointer-skills**: generate any missing repo-pointer skills and their `kind: repo` entries in `categories.yaml`. - **description tightening (optional)**: 14 skills have descriptions over 200 bytes (the cap here is currently 500). Tighten if adopting the 200-byte cap. ## Acceptance - All deferred hooks pass on agentic-os and are restored to the local dogfood block in `.pre-commit-config.yaml`. - `.agents/skills/categories.yaml` remains the source of truth (already added).

coilysiren referenced this issue

2026-05-29 01:28:48 +00:00

Tier A: wire validate-skills + role:thin + references flatness exemption #98

coilysiren added the

label

2026-05-31 01:54:06 +00:00

coilysiren added

and removed

labels

2026-05-31 07:00:05 +00:00