coilyco-flight-deck/agentic-os
2
0
Fork 0
Code Issues 30 Pull requests Projects Releases 230 Packages 1 Activity Actions 1

Stop requiring manual WARD_CONFIG_REF overrides for warded surfaces #426

Closed
coilyco-ops wants to merge 1 commit from issue-422 into main
pull from: issue-422
merge into: coilyco-flight-deck:main
Conversation 2 Commits 1 Files changed 7 +99 -11
coilyco-ops commented 2026-07-10 09:45:52 +00:00
Member
Copy link

closes #422

ward.workflow: pull-requests-and-merge

closes #422 ward.workflow: pull-requests-and-merge
coilyco-ops commented 2026-07-10 09:46:58 +00:00
Author
Member
Copy link

verdict: block
confidence: high
summary: The patch improves host shell entrypoints, but it does not fix the read-only director surface where the problem was observed. In this current director surface both WARD_CONFIG_REF and AOS_REPO_ROOT are unset unless the command is manually prefixed.
findings:

  • severity: high
    file: shell/common.sh
    line: 16
    problem: The implementation only derives WARD_CONFIG_REF when shell/common.sh is sourced, and the shell entrypoint changes only cover shell/bashrc and shell/zshrc.
    impact: The failing surface is a warded read-only director container. That session is not getting either WARD_CONFIG_REF or AOS_REPO_ROOT from these rc files, so warded list --json and warded engineer ... still require the manual inline override in the actual surface this issue is about.
  • severity: medium
    file: shell/common.sh
    line: 21
    problem: _siren_aos_repo_root falls back to git rev-parse --show-toplevel before the canonical aos checkout.
    impact: If common.sh is sourced without AOS_REPO_ROOT while the current directory is another repo, it can build an agentic-os WARD_CONFIG_REF using a non-agentic-os commit SHA.
    conclusion: Review blocks PR #426. The host-shell cleanup is useful, but the issue contract requires read-only director/surface sessions and child warded invocations to inherit the current aos .ward ref automatically; this diff does not change that path.
verdict: block confidence: high summary: The patch improves host shell entrypoints, but it does not fix the read-only director surface where the problem was observed. In this current director surface both `WARD_CONFIG_REF` and `AOS_REPO_ROOT` are unset unless the command is manually prefixed. findings: - severity: high file: shell/common.sh line: 16 problem: The implementation only derives `WARD_CONFIG_REF` when `shell/common.sh` is sourced, and the shell entrypoint changes only cover `shell/bashrc` and `shell/zshrc`. impact: The failing surface is a warded read-only director container. That session is not getting either `WARD_CONFIG_REF` or `AOS_REPO_ROOT` from these rc files, so `warded list --json` and `warded engineer ...` still require the manual inline override in the actual surface this issue is about. - severity: medium file: shell/common.sh line: 21 problem: `_siren_aos_repo_root` falls back to `git rev-parse --show-toplevel` before the canonical aos checkout. impact: If `common.sh` is sourced without `AOS_REPO_ROOT` while the current directory is another repo, it can build an agentic-os `WARD_CONFIG_REF` using a non-agentic-os commit SHA. conclusion: Review blocks PR #426. The host-shell cleanup is useful, but the issue contract requires read-only director/surface sessions and child `warded` invocations to inherit the current aos `.ward` ref automatically; this diff does not change that path.
coilyco-ops closed this pull request 2026-07-10 10:13:11 +00:00
coilyco-ops commented 2026-07-10 10:13:31 +00:00
Author
Member
Copy link

Closing this PR as superseded. Review blocked #426 because it only changed host shell rc files and missed the read-only director container startup path. Replacement PR #430 covers that path, removes the foreign-repo SHA fallback, and has a pass review: #430 (comment)

Closing this PR as superseded. Review blocked #426 because it only changed host shell rc files and missed the read-only director container startup path. Replacement PR #430 covers that path, removes the foreign-repo SHA fallback, and has a pass review: https://forgejo.coilysiren.me/coilyco-flight-deck/agentic-os/pulls/430#issuecomment-29930

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
burndown-2026-06
Backlog burndown June 2026

  
coherence-core
Core review set for the warded control plane coherence milestone. These issues form the release spine; adjacent milestone issues are stretch or supporting work.

  
consult
A human decision, design, or external action must happen first. Fail-closed default for unlabeled/low-confidence.

  
headless
Agent can take it from open issue to merged change with no human in the loop. The auto-burndown queue.

  
interactive
Agent does the work but pauses at a human checkpoint mid-flight (design choice, destructive step, human-only verification).

  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
burndown-2026-06
coherence-core
consult
headless
interactive
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/agentic-os!426
No description provided.