Point DEFAULT_HOOK_IDS at the split documentation hooks #1396

Merged

coilysiren merged 1 commit from aos/claude/ee98-hookids into main

2026-08-29 09:52:20 +00:00

coilyco-ops commented

2026-08-29 09:18:53 +00:00

Owner

main is latently red. aos-precommit-v0.60.0, cut by #1392's merge, dropped documentation-layout and shipped documentation-placement and documentation-size. DEFAULT_REV resolves to the newest matching tag on its own, so DEFAULT_HOOK_IDS started naming a hook absent from the rev it points at.

AssertionError: DEFAULT_HOOK_IDS reference hooks absent from aos-precommit-v0.60.0:
['documentation-layout']

Read off the gate log for run 4330. #1392's own CI was green because it ran before that tag existed.

I filed #1393 to do this swap as a follow-up, on the reasoning that #187's ordering test forbids naming an id before a release carries it. That reasoning is right for adding an id and backwards for removing one: because DEFAULT_REV moves by itself, a removal has to land with the release that drops the id, not after it. The comment above the list now says so, so the next reader gets both directions.

Verified aos-precommit-v0.60.0:.pre-commit-hooks.yaml carries both new ids and not the old one, so the swap is correct against the rev in force today.

Closes #1393

**main is latently red.** `aos-precommit-v0.60.0`, cut by #1392's merge, dropped `documentation-layout` and shipped `documentation-placement` and `documentation-size`. `DEFAULT_REV` resolves to the newest matching tag on its own, so `DEFAULT_HOOK_IDS` started naming a hook absent from the rev it points at. ``` AssertionError: DEFAULT_HOOK_IDS reference hooks absent from aos-precommit-v0.60.0: ['documentation-layout'] ``` Read off the gate log for run 4330. #1392's own CI was green because it ran before that tag existed. I filed #1393 to do this swap as a follow-up, on the reasoning that #187's ordering test forbids naming an id before a release carries it. That reasoning is right for **adding** an id and backwards for **removing** one: because DEFAULT_REV moves by itself, a removal has to land with the release that drops the id, not after it. The comment above the list now says so, so the next reader gets both directions. Verified `aos-precommit-v0.60.0:.pre-commit-hooks.yaml` carries both new ids and not the old one, so the swap is correct against the rev in force today. Closes #1393

coilyco-ops added 1 commit

2026-08-29 09:18:54 +00:00

fix(hooks): point DEFAULT_HOOK_IDS at the split documentation hooks

ci / aos-cli-tests (pull_request) Successful in 10m51s

Details

ci / gate (pull_request) Successful in 11m21s

Details

696b1d9554

`aos-precommit-v0.60.0`, cut by #1392's merge, dropped `documentation-layout`
and shipped `documentation-placement` and `documentation-size`. DEFAULT_REV
resolves to the newest tag on its own, so the id list started naming a hook
absent from the rev it points at and `test_default_hook_ids_present_at_default_rev`
went red on main the moment that tag existed.

The ordering rule is asymmetric and now says so in the code: ADDING an id
waits for a release to carry it, REMOVING one must land with the release that
drops it.

Closes coilyco-flight-deck/agentic-os#1393

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Agent-Role: platform