Swap DEFAULT_HOOK_IDS to the split documentation hooks once a release carries them #1393

Closed
opened 2026-08-29 09:06:36 +00:00 by coilyco-ops · 0 comments
Owner

#1392 split documentation-layout into documentation-placement and documentation-size. It deliberately left DEFAULT_HOOK_IDS naming the old id.

test_default_hook_ids_present_at_default_rev asserts every id in DEFAULT_HOOK_IDS exists at DEFAULT_REV, so the generator may not emit an id before a tagged release carries it (#187). Adding them in the same PR fails that test.

What is left

  1. Confirm the aos-precommit-v* release cut by #1392's merge is tagged and carries both hook ids in its .pre-commit-hooks.yaml.
  2. Bump DEFAULT_REV in scripts/apply-agentic-os-hooks.py to that tag.
  3. Replace documentation-layout in DEFAULT_HOOK_IDS with documentation-placement and documentation-size, and update the module docstring's hook list at line 14.
  4. Re-run the generator across the fleet so every consumer's managed block swaps.

Until step 4 lands, a consumer that bumps its pin without rerunning the generator names a hook id absent from the new ref. That fails loudly rather than silently, and rerunning the infra script fixes it.

Blocks the website half of #1111.

#1392 split `documentation-layout` into `documentation-placement` and `documentation-size`. It deliberately left `DEFAULT_HOOK_IDS` naming the old id. `test_default_hook_ids_present_at_default_rev` asserts every id in `DEFAULT_HOOK_IDS` exists at `DEFAULT_REV`, so the generator may not emit an id before a tagged release carries it (#187). Adding them in the same PR fails that test. ## What is left 1. Confirm the `aos-precommit-v*` release cut by #1392's merge is tagged and carries both hook ids in its `.pre-commit-hooks.yaml`. 2. Bump `DEFAULT_REV` in `scripts/apply-agentic-os-hooks.py` to that tag. 3. Replace `documentation-layout` in `DEFAULT_HOOK_IDS` with `documentation-placement` and `documentation-size`, and update the module docstring's hook list at line 14. 4. Re-run the generator across the fleet so every consumer's managed block swaps. Until step 4 lands, a consumer that bumps its pin without rerunning the generator names a hook id absent from the new ref. That fails loudly rather than silently, and rerunning the infra script fixes it. Blocks the website half of #1111.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-flight-deck/agentic-os#1393
No description provided.