lockdown renders .claude/settings.json without trailing newline #32

New issue

Closed

opened 2026-05-28 07:06:04 +00:00 by coilysiren · 0 comments

coilysiren commented

2026-05-28 07:06:04 +00:00

Owner

Problem lockdown.BuildPlan / writeSettingsJSON render .claude/settings.json with no trailing newline.

json.MarshalIndent output was written verbatim, so generated settings.json ended without a final newline. In any repo where the end-of-file-fixer pre-commit hook runs, the committed copy gains a trailing newline, but coily regenerates without one. Every coily lockdown --apply --replace / coily setup re-baseline re-dirties the file; the next commit re-adds the newline; the two tools fight forever.

lockdown/user_hook.go already appended '\n' to the user-settings render, so this was an inconsistency between the three marshal sites, not a deliberate choice.

Fix Append '\n' after json.MarshalIndent in both claudeCodeBuildSettings (per-repo render) and writeSettingsJSON (recursion-root merge), matching user_hook.go. Added TestBuildPlan_AfterEndsWithNewline to lock it.

User-facing symptom tracked at coilysiren/coily#135.

**Problem** `lockdown.BuildPlan` / `writeSettingsJSON` render `.claude/settings.json` with no trailing newline. `json.MarshalIndent` output was written verbatim, so generated `settings.json` ended without a final newline. In any repo where the `end-of-file-fixer` pre-commit hook runs, the committed copy gains a trailing newline, but coily regenerates without one. Every `coily lockdown --apply --replace` / `coily setup` re-baseline re-dirties the file; the next commit re-adds the newline; the two tools fight forever. `lockdown/user_hook.go` already appended `'\n'` to the user-settings render, so this was an inconsistency between the three marshal sites, not a deliberate choice. **Fix** Append `'\n'` after `json.MarshalIndent` in both `claudeCodeBuildSettings` (per-repo render) and `writeSettingsJSON` (recursion-root merge), matching `user_hook.go`. Added `TestBuildPlan_AfterEndsWithNewline` to lock it. User-facing symptom tracked at coilysiren/coily#135.

coilysiren referenced this issue from a commit

2026-05-28 07:13:33 +00:00

fix(lockdown): emit trailing newline on rendered settings.json

coilysiren closed this issue

2026-05-28 07:13:33 +00:00

coilysiren referenced this issue from coilyco-bridge/coily

2026-05-28 07:14:10 +00:00

coily lockdown writes .claude/settings.json without trailing newline, fighting end-of-file-fixer #135